From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 489CBE5D for <dev@dpdk.org>; Mon, 11 Dec 2017 13:52:15 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 04:52:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="17275729" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by orsmga002.jf.intel.com with SMTP; 11 Dec 2017 04:52:12 -0800 Received: by (sSMTP sendmail emulation); Mon, 11 Dec 2017 12:52:11 +0000 Date: Mon, 11 Dec 2017 12:52:10 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Elza Mathew <elza.mathew@intel.com> Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Message-ID: <20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com> References: <1509991442-26391-1-git-send-email-elza.mathew@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509991442-26391-1-git-send-email-elza.mathew@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 1/3] hash: run-time function selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 11 Dec 2017 12:52:15 -0000 On Mon, Nov 06, 2017 at 10:04:02AM -0800, Elza Mathew wrote: > Compile-time function selection can potentially lead to > lower performance on generic builds done by distros. > Replaced compile time flag checks with run-time function > selection. > > Signed-off-by: Elza Mathew <elza.mathew@intel.com> > --- > lib/librte_hash/rte_cuckoo_hash.c | 10 +++++++++- > lib/librte_hash/rte_cuckoo_hash.h | 6 ------ > 2 files changed, 9 insertions(+), 7 deletions(-) > Looks good to me. Acked-by: Bruce Richardson <bruce.richardson@intel.com>