From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 77F26271 for ; Mon, 11 Dec 2017 15:15:59 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id b199so10985466wme.1 for ; Mon, 11 Dec 2017 06:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7kJe3Jd9yESHFUS0NixNf6mgnGNMiPPPGKjrZYSfr+I=; b=hlpmJPORR2uP3ThYzDALeqfBFQ6cbNskuexYFg/Ch2FKriGiO0ELBnN0ina/6A9OOm PgcY8dY4R436pUQdmsU2fhdnFiqV3jMoIlDgQoIg41FRgPnKAFZKT8hymfX5zVnxApIs Skgr7/8gwUpSBktQAbUQpWniDytJZXzCe1K1L/PjlaIIBLl3Xe1658S9butD2mp2qVNM VAomhqKa39rFOTh7kcWdQHdQbn3ALFvaxl0qi3h0TfGRnSPYLYOPPKVxhy6d7YQT28n5 lXmMjwJUPBcNiHbbps4j+S4thQzxmnpeJJs/IZuiXJzPnIFHrdsacXI3ZpJEi2zFkHUg kYHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7kJe3Jd9yESHFUS0NixNf6mgnGNMiPPPGKjrZYSfr+I=; b=jy7qiSdxmJGrAwj25LFAyqT5bztAde+sjXnRq2+/pOPYQals25c7DNmgLtr/vxwkIm afNinqd/8BDrlh+qNrns4PDjYMRWDPM5y7zaouos9ERc/A4rW09xP3HwulO41CTakld5 KjNWxzaD9PLRbMIZcjBipRgFPS1Dozjr5R0l44toXCsSCfy7irDuelszgHJBLfQSNmL/ U7Y0GQxK8epRGBbLu34nbXuoGKq1rC/Nldfvp1XNJ+gvdqroOqOEFl6i7YbyqcOD4Aqj gJ211BNiUh+bUIzmSncy3l0JU30mhwu7FCv/BgzNvuJMW85vyyQPCrRNewt7R3r+5jiD evOw== X-Gm-Message-State: AKGB3mKMMFOrV75C1KkWYMS8CgJ0fteLFxc/g1/4+kdf2gm6SDn+6xtm CzVdSLUU7DznCtnU1e8eFNcT X-Google-Smtp-Source: ACJfBotDUaoDzBOIwiG7JUAy8jFWbWQ/QJ3JQDLK+RwmeE0iDxXj4DmDcY+1Kz1cZUWCvvmSk132hw== X-Received: by 10.28.226.214 with SMTP id z205mr960449wmg.149.1513001759193; Mon, 11 Dec 2017 06:15:59 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p90sm9293335wmf.3.2017.12.11.06.15.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 06:15:58 -0800 (PST) Date: Mon, 11 Dec 2017 15:16:26 +0100 From: Nelio Laranjeiro To: "De Lara Guarch, Pablo" Cc: Akhil Goyal , "Doherty, Declan" , "dev@dpdk.org" , Gaetan Rivet , "stable@dpdk.org" Message-ID: <20171211141626.ervyhyzchhsfvxl5@laranjeiro-vm.dev.6wind.com> References: <1c3b73f0912ad4b3da8423590dc76fc83df16b80.1511338151.git.nelio.laranjeiro@6wind.com> <20171211124249.xti6cebljmllzygb@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 14:15:59 -0000 On Mon, Dec 11, 2017 at 01:54:22PM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Monday, December 11, 2017 12:43 PM > > To: De Lara Guarch, Pablo > > Cc: Akhil Goyal ; Doherty, Declan > > ; dev@dpdk.org; Gaetan Rivet > > ; stable@dpdk.org > > Subject: Re: [PATCH v2 2/3] crypto: fix pedantic compilation errors > > > > Hi Pablo, > > > > On Mon, Dec 11, 2017 at 11:49:39AM +0000, De Lara Guarch, Pablo wrote: > > > > > > > > > > -----Original Message----- > > > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > > > Sent: Thursday, November 23, 2017 10:03 AM > > > > To: Akhil Goyal ; Doherty, Declan > > > > > > > > Cc: dev@dpdk.org; Gaetan Rivet ; De Lara > > > > Guarch, Pablo ; stable@dpdk.org > > > > Subject: [PATCH v2 2/3] crypto: fix pedantic compilation errors > > > > > > > > > > ... > > > > > > > --- a/lib/librte_cryptodev/rte_crypto.h > > > > +++ b/lib/librte_cryptodev/rte_crypto.h > > > > @@ -121,7 +121,7 @@ struct rte_crypto_op { > > > > rte_iova_t phys_addr; > > > > /**< physical address of crypto operation */ > > > > > > > > - RTE_STD_C11 > > > > + __extension__ > > > > > > Hi Nelio, > > > > > > Since RTE_STD_C11 is basically __extension__ when __STDC_VERSION__ > > is > > > not defined, Is this forcing __extension__ to be used no matter what? > > (even if C11 is not supported). > > > > Yes > > > > Right, and are we sure that this is OK? If C11 is supported, do we > still want extension? Having an array with an empty size inside a union does not make part of any standard, it is an extension of the language. Regards, -- Nélio Laranjeiro 6WIND