From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id AFFEB201
 for <dev@dpdk.org>; Tue, 12 Dec 2017 02:28:22 +0100 (CET)
Received: by mail-pf0-f193.google.com with SMTP id y89so12961138pfk.0
 for <dev@dpdk.org>; Mon, 11 Dec 2017 17:28:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=xiibwgILzLGn8blIaKhkzJl/0mPF0tcmIqY6tfsHy0c=;
 b=gSXjK35z/ZYeW6eRiygJJgqAtm/K/YVZPEkpYB/2GvOj/DSQ5aDQq9TS5C3/Hb5juA
 WgNFvYvml2pmnAM4KeTCKDyNoOfmYbEvIaULL56BVTb+R5ieMzP++PVUYUIgUo/VC3vu
 A4tMkA5s/iXLOaLTpqAr4nkvl+c+xxHADK0UXj58ZjfSWoYh9/fGivkRvq7eK+7iAevq
 jZdlTqGH15pU5v2b+AtzyEbvt3dZVia7Ja7ZHgx/c34CanDBXnpCFkNNTHByg4309g+D
 Q0Ho/GcZF0urK45D43DIVE0CaIlPB84z1zWjmw/HcBefcP7+W21NEnwx1kuidXIr/9p8
 zkvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=xiibwgILzLGn8blIaKhkzJl/0mPF0tcmIqY6tfsHy0c=;
 b=T9/pg9Ekw3/XneBarRRXfynePIiz3F87FXr30rMhx62Qb8K8u8jA+OLKxhhk14u/fy
 cSK/YqZ6ymlnj21BDkO9SeHB20xqwad1HJNwcScEwjoMGjwr9QuwHrWYjFSb04XoeLRB
 4oSPxscjD65haQhfj0m9Cw49y9WSgL2oTc1yq/JDzfZVIbfO8pP3+M/0dTdCMoXVZZjl
 VUKqSU3C8DAn48I9/254FSeHju2r8T0FmMD31ZxFfxZ2qsH0vC/+PJmfUtiDOLpYvNJn
 v7EhV+0rVfZu4BWGxx3c0IPgwZBCq7d0PecJupWa3o2fw8v7SN/QmcCUWTkSzDvRrcmF
 2xJg==
X-Gm-Message-State: AKGB3mKqbOgG0W0wP9fuE6TqmZUp12NfTh5JLXTzyaJCppQJD/e0EIz/
 jUsT6LUIYVU/AqCpL+qrbaNHdRfDGQE=
X-Google-Smtp-Source: ACJfBosMJpF6NH4o/rqqmh2DwSvcoJ2P5C/QpDM8XmmVyjrjrBCbMm2V/cWM5PVDDAnfihvWC/bx+A==
X-Received: by 10.98.5.196 with SMTP id 187mr521689pff.66.1513042101844;
 Mon, 11 Dec 2017 17:28:21 -0800 (PST)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id b10sm27894435pfj.20.2017.12.11.17.28.21
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 11 Dec 2017 17:28:21 -0800 (PST)
Date: Mon, 11 Dec 2017 17:28:19 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <shreyansh.jain@nxp.com>
Message-ID: <20171211172819.7ac102b6@xeon-e3>
In-Reply-To: <1512710487-32388-9-git-send-email-hemant.agrawal@nxp.com>
References: <1512710487-32388-1-git-send-email-hemant.agrawal@nxp.com>
 <1512710487-32388-9-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 08/14] net/dpaa2: add Rx queue count support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2017 01:28:23 -0000

On Fri, 8 Dec 2017 10:51:21 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> @@ -1737,6 +1769,7 @@ static struct eth_dev_ops dpaa2_ethdev_ops = {

I know this is not part of the patch, but this diff highlighted another thing
to addreess in this family of driver.  The eth_dev_ops should be const if possible
that reduces change of bugs and other  issues.