From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id BE6AD2A5D; Mon, 11 Dec 2017 19:58:58 +0100 (CET) Received: from cpe-2606-a000-111b-423c-e874-da8e-c543-d863.dyn6.twc.com ([2606:a000:111b:423c:e874:da8e:c543:d863] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1eOTHp-0006Sy-Eb; Mon, 11 Dec 2017 13:58:53 -0500 Date: Mon, 11 Dec 2017 13:58:13 -0500 From: Neil Horman To: Bruce Richardson Cc: Hemant Agrawal , dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org, Jun Yang Message-ID: <20171211185813.GE18284@hmswarspite.think-freely.org> References: <1509617335-6354-1-git-send-email-hemant.agrawal@nxp.com> <20171211124032.GA11536@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171211124032.GA11536@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 18:59:01 -0000 On Mon, Dec 11, 2017 at 12:40:32PM +0000, Bruce Richardson wrote: > On Thu, Nov 02, 2017 at 03:38:51PM +0530, Hemant Agrawal wrote: > > cross compiling DPDK for BE mode on ARM results into errors > > > > "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" > > > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") > > Cc: Neil Horman > > Cc: stable@dpdk.org > > > > Signed-off-by: Jun Yang > > Signed-off-by: Hemant Agrawal > > --- > > buildtools/pmdinfogen/pmdinfogen.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Comment could be a bit more specific about what the problem is and how > changing the hard-coded "32" fixes it. > > Haven't tested the cross compilation part myself, but this causes no > errors for 32-bit or 64-bit builds on my system. So, with some more > detail on the specifics of the fix in the commit message: > > Acked-by: Bruce Richardson > I'm with Bruce. I'd like to know exactly whats going on here. I dont have an ARM system handy, so could you please post the errors that you are seeing here? Is ADDR_SIZE not defined on BE for ARM or some such? That seems like it should be fixed, rather than this change. Neil > > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c > > index e73fc76..9119e52 100644 > > --- a/buildtools/pmdinfogen/pmdinfogen.c > > +++ b/buildtools/pmdinfogen/pmdinfogen.c > > @@ -181,7 +181,7 @@ static int parse_elf(struct elf_info *info, const char *filename) > > sechdrs[i].sh_offset = > > TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_offset); > > sechdrs[i].sh_size = > > - TO_NATIVE(endian, 32, sechdrs[i].sh_size); > > + TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_size); > > sechdrs[i].sh_link = > > TO_NATIVE(endian, 32, sechdrs[i].sh_link); > > sechdrs[i].sh_info = > > -- > > 2.7.4 > > >