From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0057.outbound.protection.outlook.com [104.47.37.57]) by dpdk.org (Postfix) with ESMTP id 60173293B for ; Tue, 12 Dec 2017 09:18:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EpYw/oMzM3WtwIfFCLkGBi6jUGdaxYq4VrBnbK7MkGA=; b=V+1NsiKBVHMYaDH5dWM9sIem4qxILFGFspdfJtRAJCdE5aYmMb7ft+/2hOp5cX/qFI/9L+4ZMH8WcFr0S3SCu0lpPX3EKVxmntnXRygy1ctIlgZkZUOnFTSRn9k+PGM8t2mCM2VIg8dfhv5LcLodDciY5X43/j+dhseHKNwISlg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by CY4PR07MB3461.namprd07.prod.outlook.com (10.171.252.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 08:18:09 +0000 Date: Tue, 12 Dec 2017 13:47:58 +0530 From: Pavan Nikhilesh Bhagavatula To: "Eads, Gage" , "jerin.jacobkollanukkaran@cavium.com" , "Van Haaren, Harry" , nikhil.rao@intel.com, "hemant.agrawal@nxp.com" , "Ma, Liang J" Cc: dev@dpdk.org Message-ID: <20171212081757.aarmhwpaduvgjaic@Pavan-LT> References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-2-pbhagavatula@caviumnetworks.com> <9184057F7FC11744A2107296B6B8EB1E2BB1623A@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E2BB1623A@FMSMSX108.amr.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MWHPR1001CA0025.namprd10.prod.outlook.com (10.174.165.38) To CY4PR07MB3461.namprd07.prod.outlook.com (10.171.252.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea8b28d2-42ca-413d-55ce-08d54138e2ad X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:CY4PR07MB3461; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 3:YptMSCniUyHdeBuTsq0quahq6H+HWwLhjUtXzZ8CKMLiIRk0rosKtw7lbtD6/qICfjKp1WsDgycBVrv6chmsozTVSLDxY36sIUY1vZ/I7ZNFoHrzNktaWnI2wBhTdd5FZRcVKb0L/8rLwT5mZtlwNRjnrXKNXZJioSchU7J62u16h4IsiGzRNJHFCkm55pLPEbhvyVgugHlN91gk9GVZf0KnPunaLCqv9wTwWfRKAentAyzj7PIbKIQStvQv5pIT; 25:zOR69p5B+AKVS2ArrdQPZwiDi7udRvJY9GbnPWvKCeZ95oWtUxdhugxX95/2Z5o36qbqddiFZCEyEcDTxp0SknbqPvtLjZUAgtn21NtX0OWt2OlmvaPEZjf9allQOJQJwDuusoMtv+ZvjmQ/ZEYdLCHvk+kK8Y4aonmb85Dn+zL1HWw5j0usZiGNC7SlbKeVlnzhvyAqjj4ZS56xg3uoxRskUhKk8c+GPbrTlvMIdADLBEtVtDC9uPp5zfWclmT3gOgkmWCObb85E2eBpoEuCcAsFAKQaeHxu1aHTv0sGE8DqmQdG4uOrB9++Lv70Qde0i7zHQ0tSnnUyG9jXy0szQ==; 31:Mrr0A/U2BikSc0/7YfSbO0slSiKXIzUVcXHJULJxWm1qDmZimyWB6/ubpddM1ayqQ/qVjaSQdXMcvZ0PK51aW8dnWbhwqKfQXDXSX1Zu1ypTNzvUORn3oqkg0QEJn2rGtpIIqNt9aVKcA8gmLPguA5k5JuIxxmQGKFnfbqrFJeEqsdbLuChZVizqE3OF3uqTe0ko4IhXYZdyp94mRc11GjmnBHDedMHRLCtr71WYDH8= X-MS-TrafficTypeDiagnostic: CY4PR07MB3461: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 20:FLa+2eyJn8zUrVXfnnm7kESI8jmSvnr0ZVsyMbaymgy4PGGNvZoGhlrHxmcS1v5mGmwcQjVbqid50T3I0gSRdbejR2QjKQ6EBAEG4N5XF2lyNNZIKDIMUdQnOKqAouTmRdcanGGP0cNtyrw7/PyUVT6LQY2p+QpMeqFsrt7zNXNpb5FGDDfYzzLfR7sMhn5dH5D2zr0PcxNslnCa/MXIDTWsUyqv1etwhuS5Bm8CW63q0WZFXuFTbzaije89f7akTOMHQZoFZsDzuZ/YgzuXlpIwOlcxlWK37PH8JJdWI/7O7ilrw6ZPv0PFP5zGrnvoY90E03Ybv2CKkiYrwEmMdfBqqOXWt4N5K1VQtqjTlfAJAr538P16uliy8CfFP/slY7Cdq+K8iAO2vT31c2ykFt5ao9sgcOt8QvEKCOG/poiMgtuuVIpxAJ7AQZX5m0T6hxar8yg+4dDyz91BauwE1DIgWyiecN7MFOn+c1qy6bOpzg2Zd2Jnfa9x1ZNElEqC+TCEzS984t2T0ZTz5R/8sbhLCq+DJqQ13Oi9KjGsD9ONFD4qqVog7WreHOJv1WxG+u90jGefvR0ZC05r6iqcvElc8BHcgGj6W1Bmp0xe64A=; 4:GqqY8KZqR9dC76q0Zy6s3eSVyEqR8y+H3l7xljFNQDnW4vO8BoD9G0yNkwQ38Eife+1zkUfj8M0LEZhGsj+N5bhJN+LFe6+u/qeEmoerv5BaEpN8q2u2FOTUGjyH99nKruXKODqUqo8+PJZEZ+/g3lulkDNgEe7Pm8wgF35yJvQ+eb3z2ZI++VvAJipJ+TzUGFzljh6s5XvInguHBB4DOAsPMyOfODN5rV1TnY/KuVbE3C0DAbrKx1yRrXV17eT58zloXLaRyKrSZP2UK0IbdA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(10201501046)(3231023)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(6072148)(201708071742011); SRVR:CY4PR07MB3461; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR07MB3461; X-Forefront-PRVS: 051900244E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(24454002)(189003)(199004)(1076002)(25786009)(2501003)(6246003)(59450400001)(33896004)(2906002)(9686003)(50466002)(5660300001)(229853002)(42882006)(7736002)(2950100002)(16526018)(305945005)(58126008)(110136005)(16586007)(52116002)(8676002)(76176011)(83506002)(316002)(6496006)(106356001)(23726003)(105586002)(5009440100003)(3716004)(3846002)(4326008)(6116002)(81156014)(81166006)(68736007)(6666003)(8936002)(72206003)(97736004)(8656006)(53936002)(478600001)(33716001)(55016002)(47776003)(66066001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3461; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3461; 23:mHbDaViJpU8kiHjzKsCL024f3Na1/zOtR0U6b+aw7?= =?us-ascii?Q?2N3uqqPKRJuqvWSyR03EYmSQsZ9czs/eZMUWYaNDGkuRX1d/OjZgHwJCeSZQ?= =?us-ascii?Q?qGSmbxRyYIcTYT8zJvyOlSSlVIdoonJWrHYc+E3XqhMrWE/oNnTqdOWmaRP0?= =?us-ascii?Q?c31BmjSe+hJrJ/p+nFwGQ3eHAXKCQ+2Bj/fWnUY6fio/AnINXZtyumuCDPMJ?= =?us-ascii?Q?zCX33gUwp+x/QeodY2JlkisZCvD0eEea7ByuTEHGjo25t2fhF2ne0Ck3A2nL?= =?us-ascii?Q?rIcbjkvTluYmDfWw5Xg2ljncYAKwgm5GaatlWVP3qYpQfKu48L1j1LLY/5JD?= =?us-ascii?Q?uylNnbAXNSkSzYfZ959VDXEPQVHiuImNb3dDXtU7a8l7wvf1lC2V/O85Qw15?= =?us-ascii?Q?hB7RAhJ9YJztQnsjdZJDVUnBKFjT6EaWLvFAZuWbTqfVt2YgFtR3CDNdl6Hy?= =?us-ascii?Q?JOMA/Y3lh/a99Zi55ivKwWQbd4MSSRmMCOk4x5Nq/DSei3v98VeTGnaS04TJ?= =?us-ascii?Q?ufVtHJh8JM2VpowLZqtPIrncmf7/DV/O5yrkzmtu6jkdiSlYPu3D9zHdCldW?= =?us-ascii?Q?UGHMKX4MS6gOjNLdKiRkwfI0GK7CczUXZTxBfhFm1Yp/p5lEkL8ualg3LnTi?= =?us-ascii?Q?Q39N5T4bHdMWEbiqwo5hpNUlNXsICPQz23DNbIjMGFYqgzEE5zZ6LfikNK1p?= =?us-ascii?Q?m1lDPpOABDBxFu9qJgOnXHI3uquRYJda4Plw2HXDjQKi1F1LbHiVoB+BsX/W?= =?us-ascii?Q?OKl5yvpNQYbwKeOrFl+56q3La5TmS3J8Nyhfej0KTRqmyWc8lna6jEihhism?= =?us-ascii?Q?iJ86HV/avQTWSN2/XgOEy7+XR5dOcyHOtaHY3+88sJLHpSO9UPuf5kqjSx02?= =?us-ascii?Q?vgp4gIn+vDkbuBPUN7nTlUKbIKRvtGEmFO29dbZja2OI9DXL3kKKkf7BD0am?= =?us-ascii?Q?Y+c3DqDfY497lXadTh7lr291+ODh93868nhX4h0mGD3bHO6rRJDzCmjR09tC?= =?us-ascii?Q?y2nMMGpdz4y5wxMuis5/slODcf6OXspoYZ9Ilgy6wlldmEw0LjRpv997Riza?= =?us-ascii?Q?jGO+MPGGFj1UndLD2zVPM7xWzuqf3dmRlPRUl5+aB6Yi1k598Rp9rfbou806?= =?us-ascii?Q?Ewus4ADiKl8thQqxVV+ynR7g+WilF6f3wKE+VKwxTvK9dAhCQk6qwMGcOlfd?= =?us-ascii?Q?+UTKLc2d3MY0ell8yhBPzXs5Cc/c1IBC7/cEZRYw4oBA8TUb5trgttn0e0Q3?= =?us-ascii?Q?kukdRBjUZdaQVyR8q8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 6:wQuClZ6YwxAINhaw9Ypr4qs/yt0SUPqsmFFcErHS+SzpVF+fs2DogNmA83cydavR1n8D1Ekcbg7Bd7OlVHhC+bIHyRjOH/NKSuTi1q9qcPFPhoqStVxIneNo886TwZPlFuIwgwgUrgMCNs6tFwxHYKwAjJeDc+4rxc5N3sN01DXmZigRV6E5xFInw1oYNLRplnzCwJ4hcBn8mIWvrknhOlZErwryEMElwKhdlXSM5i/mEc+3jskkEN2ycAgMY3SzY3hq34NzfQkq56laXt6iuX7fpl/sI1G/HGZNN4SWUU8KbgDDf4+P7V3o+q69IQFw3rmeMUeKObVtbiKkJvs3XWm7UEyn4UqwrIhtNorhFS8=; 5:9PG6hf+jr/Pk3OKOUmpB23OZgr6MJtmbM91knQI8zEQI26GBb07y1za2MqgQzSWFwmZ5AV2y4VbtfjE2TIDNdM5g8xJCAak8E8ySR7GY6fS0jJ1z4OmhDtLmYMKOnYYO/h5cXfr0I4ZKS7axG9+sTE9sYj5fCa/ufUOlyxoHx1Q=; 24:C/SYwWesa9tnecjvsOda1a6rEFeTJ9gKN1Gj3bOU4k4uJLdyD7oeBgwTXM1jpJCZ3H46pKnGO+2IxmNG3YoGTKCZlz18VhXMsTO0vi/R3nE=; 7:sQebyRs8b+9KOlO6jHfcO8DaOUr6MuJUI4EpaX5uthieopTZ0ax/fBGH0iJSn5tY0QnXQsqQXPLN0M7V13cTLeNEUOQV1zMv6r+hz8OzdL0ZwNp6K8jmVjK+HHwxW5F10bslzxPxbZiwjEolBp/N0yw5FuUzZBaczkRDd5Uvcu3gzwjk09Fs5HkBtot84vLjY80N4ddLEVQUc8QS/5ovZyIub+x/yqEgyfHSYwQDxvfkGptO7O02B8/ptd7kfU8d SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 08:18:09.6394 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea8b28d2-42ca-413d-55ce-08d54138e2ad X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3461 Subject: Re: [dpdk-dev] [PATCH 01/13] examples/eventdev: add Rx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 08:18:14 -0000 On Mon, Dec 11, 2017 at 04:15:41PM +0000, Eads, Gage wrote: > Hi Pavan, > > > > > static inline void > > schedule_devices(unsigned int lcore_id) { > > if (fdata->rx_core[lcore_id] && (fdata->rx_single || > > rte_atomic32_cmpset(&(fdata->rx_lock), 0, 1))) { > > - producer(); > > + rte_service_run_iter_on_app_lcore(fdata->rxadptr_service_id, > > 1); > > rte_atomic32_clear((rte_atomic32_t *)&(fdata->rx_lock)); > > } > > The (rx_single || cmpset(rx_lock)) check should no longer be needed -- this logic is provided in rte_service_run_iter_on_app_lcore() and service_run(). The rx_lock can be dropped in general. > we could either remove the example level locks (or) keep the locks at application level and disable them in service api through rte_service_run_iter_on_app_lcore(, 0). If we choose to remove example level locks we could do something like rte_service_run_iter_on_app_lcore(id, !rx_single) > > > > + if (port_needed) > > + prod_data.port_id = cons_data.port_id + 1; > > + prod_data.dev_id = evdev_id; > > + prod_data.qid = cdata.qid[0]; > > + > > Is prod_data still needed? Looks like we're only using it in main() to print the port ID (which may not be valid, depending on if port_needed is true). Prod data is not needed I left it there to be consistent with the old example, I will clean it up in the next version. > > Thanks, > Gage Thanks, Pavan