From: Olivier MATZ <olivier.matz@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, santosh.shukla@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
Date: Tue, 12 Dec 2017 15:33:10 +0100 [thread overview]
Message-ID: <20171212143309.flenkqvsp4inlpz4@platinum> (raw)
In-Reply-To: <20171119045531.25165-1-jerin.jacob@caviumnetworks.com>
On Sun, Nov 19, 2017 at 10:25:31AM +0530, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> test/test/test_mempool_perf.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
My checkpatch sees this minor issue:
WARNING:TYPO_SPELLING: 'allow to' may be misspelled -
perhaps 'allow (without "to", see
http://english.stackexchange.com/questions/60271/grammatical-complements-for-allow/60285#60285)'?
I don't this it's critical, and the official checkpatch did not see it, so
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
next prev parent reply other threads:[~2017-12-12 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 4:55 Jerin Jacob
2017-12-12 14:33 ` Olivier MATZ [this message]
2018-01-18 14:12 ` Thomas Monjalon
2017-12-12 15:12 ` santosh
2018-01-17 23:18 ` Thomas Monjalon
2018-01-18 2:36 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212143309.flenkqvsp4inlpz4@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).