From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id B59941D7 for ; Wed, 13 Dec 2017 11:26:05 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id 9so3921812wme.4 for ; Wed, 13 Dec 2017 02:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5c/ECoTD0huGGiJgmHj44ka652CcbY/6rKWkLckcSvk=; b=n4yyBJHiJAS2b91hz9cPCABSr5ZnO83qwZA/l8sf1ZZXMI+ppmXawDJ1rux+zDOvdS jibhgKgrxYrbBhT9vg9nWboKSBUIqIW9SBdun+dyOA288xymL/LnCSbbThacSribAVVP P0hTQuQWsnXKKK/7mSmUuNcPwEtj/k5XiZjjc9iuQgQCw2sE1I/hV7RuUlUV6kt/1N7o NtjjQbpGoBf1t7h4K0HMufHKUMcGbHgp8T3UId8lnoGlThJRLnlYiWjqatTIkJqXkmwz L2IzTWbu9WWpPgHMWJi9sVdbs0ykSN5RtChetJyXStCy05QaBl0DBkxPVelLCD0Bt16O S49w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=5c/ECoTD0huGGiJgmHj44ka652CcbY/6rKWkLckcSvk=; b=hkEjmG57Af5TxNtHvKJpbjAIUNR8XwJ238poHzobtoXq1r4YG9atZ7P7BV16XBhp5x b+HPQnsdJU466SDjpyFA8yWVigTpzN+zWWD8NVfqXEDK5LwtZroZVOENzYhmuA67su5X GdaO1Knmd0cvv4yBXdX8xpy/FnMJbfCCnQpbjr4r4aFKh/+TVyPFyiFK46ZMZvSsKJiR eSq9LEOftZr8xfUDmqMY9d4ALYbbQ0IgtdIzDgzjWH1VI0984kws2w2/0dOJLsGoqanR DCi6r8L4RaxSkRfH+GhaFjaSFmU2BHIR9ogLYagJGgkq4zbLofdIbmTfDaB/+Qw13aud xCuA== X-Gm-Message-State: AKGB3mJHch0vXk3QfdxbsMxddWSxD/HeBCYlUbifdcawCckpf++5n4W4 Tp16+8yh4Xdp3PuvhOVcehKqmGTX X-Google-Smtp-Source: ACJfBov8CuMXIccRDMmLCnFvThJRVgrwJVeveFEVcClaDzxHTEeMz/q5IaPT/dAPs9HPck9usl8JJg== X-Received: by 10.80.244.141 with SMTP id s13mr7087280edm.222.1513160765216; Wed, 13 Dec 2017 02:26:05 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w2sm1141947edb.4.2017.12.13.02.26.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Dec 2017 02:26:04 -0800 (PST) Date: Wed, 13 Dec 2017 11:25:52 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Shreyansh Jain Cc: dev@dpdk.org Message-ID: <20171213102552.nmrf73y7yvzexkz7@bidouze.vm.6wind.com> References: <3930fcee-7ff6-c6f9-273b-14c16bef6ab1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3930fcee-7ff6-c6f9-273b-14c16bef6ab1@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 18/18] doc: remove devargs deprecation notices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 10:26:05 -0000 Hello Shreyansh, On Wed, Dec 13, 2017 at 03:47:04PM +0530, Shreyansh Jain wrote: > Hello Gaetan, > > On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: > > These actions have been enacted. > > > > Signed-off-by: Gaetan Rivet > > --- > > doc/guides/rel_notes/deprecation.rst | 13 ------------- > > 1 file changed, 13 deletions(-) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index ef2264f..23faa19 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -16,19 +16,6 @@ Deprecation Notices > > - ``rte_set_log_type``, replaced by ``rte_log_set_level`` > > - ``rte_get_log_type``, replaced by ``rte_log_get_level`` > > -* eal: several API and ABI changes are planned for ``rte_devargs`` in v17.11. > > - The format of device command line parameters will change. The bus will need > > - to be explicitly stated in the device declaration. The enum ``rte_devtype`` > > - was used to identify a bus and will disappear. > > - The structure ``rte_devargs`` will change. > > - The ``rte_devargs_list`` will be made private. > > - The following functions are deprecated starting from 17.08 and will either be > > - modified or removed in 17.11: > > - > > - - ``rte_eal_devargs_add`` > > - - ``rte_eal_devargs_type_count`` > > - - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse`` > > - > > * eal: An ABI change is planned for 17.11 to make DPDK aware of IOVA address > > translation scheme. > > Reference to phys address in EAL data-structure or functions may change to > > > > Once this patch is formalized, the documentation reference for rte_devargs.h > also needs to be changed as it still refers to RTE devargs as: > > "...These devices can be PCI devices or virtual devices....". > > Similarly, the rte_devargs_parse too has PCI traces. > > Next step would be to remove the "pci"/"vdev" reference from > rte_eal_dev_attach. > Noted, thanks. > Former can be part of this series, but the later needs to be a separate > patch, I think. Let me know if you want me to work on these (or later). > > Other than that, I think I am OK with overall patch. If you can push the > final series (I am not sure it would be with or without bus control), I can > give it a spin (to vaildate if non-PCI like FSLMC bus can work fine). Indeed, I also think everything should be settled first. I have mostly finished working on this series yesterday, I will integrate your above remarks which will be short. (Well, by finished I mean I finished the first 90%. The other 90% is still in progress...) I removed the rte_devargs unit test and am not too happy about it. There are parsing functions there, which are extremely error-prone and would like to have at least the basis for some tests, that we could populate as we go. If I have the courage I will try to write it and send it with this series. I would certainly appreciate if you are able to fix the pci / vdev limitation in rte_eal_dev_attach, as I am starting to be overwhelmed with work (trying to finish a lot of things before the holidays). Thanks for the review! -- Gaëtan Rivet 6WIND