From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Pavan.Bhagavatula@cavium.com> Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0088.outbound.protection.outlook.com [104.47.41.88]) by dpdk.org (Postfix) with ESMTP id EE5EA14E8 for <dev@dpdk.org>; Wed, 13 Dec 2017 12:20:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=J5RvLNc6ovb13KiVOCCNJKceBYKxGgqsogbJarpuvgI=; b=liNcpgLUqYlEu0RiwEA6tJaICbLkWRsZS/UpOXzm5L9lQzgXjNdAH61BTZNYJwmU+UGE/1hOU3Q37myMemkc6bVGpQeSyfdF737N12p9egH+8vQbsEil8zG6I+qJqPtLZycsDB3kWDwR/XDjgYJsyd8e2J5hIS3X44pB4E1rdhU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 11:20:08 +0000 Date: Wed, 13 Dec 2017 16:49:47 +0530 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Eads, Gage" <gage.eads@intel.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "Ma, Liang J" <liang.j.ma@intel.com> Cc: dev@dpdk.org Message-ID: <20171213111946.p7g7dk4gaugpxseu@Pavan-LT> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <E923DB57A917B54B9182A2E928D00FA650FE12A5@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FE12A5@IRSMSX102.ger.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR06CA0108.apcprd06.prod.outlook.com (10.170.138.34) To DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7113f82-d656-4b48-0cb7-08d5421b79a0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:15pbSnDiIdJxvPyhL76RNVg4Fd2ut9gZ55VCt6v/pgFkF6BsOZcdeqgGQLQZFe5Dwc+vlk1Amo06YWBHEcIDfB7pDoiJStdOyXc8gTFg3LaNYOEVPtNerkoi7zWIpjiUBRrI1ikEgyc3R2yBQ3kjdwwVLg7o7iUPh6aN2xLhveqd8Cjgd4ADhG+OCP/nICbtzTMjIW6A+hkj96NrYdHDGqfEtJKO7anUOTMhrgzJmeCwi384LIxDyq6z+2VFEsLu; 25:eCd/2xDdn84zo7uKAVCnjzj7LbaY8LEgGgXRuef9Qec8E8ldX+IuosM4bhx/8hMQpXV4iEBaxeSFG2sguEucu3Hib3Me7+2y4VcNKhTGkzg4Q+qjAZI116iNkybcAYdg39HLL5rdf5na9+Rv4oxnpE4/U/3G+LPgz8qOFu9NyBtnwHQD4Qy9hZ5AD8T/UY0La41zErYDgO6FnTrBqJRmnaILkHmwMfI2LIXhZeClKYufwQxLTIcDP+OrIdcnye6wRXC4hVqTt0qtELv7xoL77iK45hBLMKQCMnINIdpaf4iNp98Dfr4qgLIXcHXzfwKJN9RpxsnymPXaVYA7mFRDjA==; 31:+mJbN1Z+CvxcChObDVwdrVYT5c0VREGf5gHwvl1CAeNgQfC7fC6y8jNonIAXsQQMUJXfEIvq3myPYAcfZguf5vOBKhu1DsWOiOoTF2cUK1BdASyEAK3tmr/zaT+OthxNIoVHZdA2fr+zS1iAWFukzJ4H7yKojCY5FdT/LnQgewp2/LYtjcM0busQXIpiqIPqi0ZVOjkpic2gPUh7kxmeS0lHVoXYofUv3QIjSYCQ4Fo= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:mfiOi0kkgLoqNtNzlRdLGj5bgTfuvpFGLlDKkkgYgduKivJVrQjB3jpVTkZRIt586uewI/DH3hWke8JV2Qkk5J890g1e3i08GuFQo2KeMn5sYAiSdw9D/HjmA8ZNyi6Vh2JgBAjrTHlv466UhIPPzsF0fAHwjpDKk/52l/GYuDdqNO5ag2pVCUeRquM98KFx+Y6r4GjcY6TTn+8dF50zR0Iq+fJJy2gJtev+phHZIA8LKMiVsHR9CiW980DHRTryMBLQ4un8SNJN/9nqZajFOY+p2auV70dG0pSfSnXCBf5pwmO+9qlkM94S67OziaVQp6XR5X97UeMlajG3xs0Awh5tUltRAZwnoWAGOE8gASU+h5hc2iu9EY7tIR1URn6/nyYI6niZDmP99now8iw8A57H66lkhwUxi+wQvEkLKuGNrTXlPCRSwBAti6wxn90wy5+gHaApuGdArxzJxEncUJ7Ago1YbgTTFnmolNwCpWqsmxrkJBWRPNUEwKUoR8zc4dUabP7bvmFnM5RQQirOqU4x+0+kIvcLioi44pj7ARlp+8Q3SXYb9gC0yXa4P8giE6DBLzferw0FImsjKtWyDBKzhwLAFhky3JhGlINTTzU= X-Microsoft-Antispam-PRVS: <DM5PR07MB3465FEE607877FDB5B7534B280350@DM5PR07MB3465.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(3231023)(93006095)(10201501046)(6041248)(20161123558100)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 4:d8Uqw8cqLXywwaIVYzSEY3zmqAybPDWehBVDDsJbIYJr1nRoJQfwAsaj/dT+3E8Do+/c0OhjmwipUSHqZGyvrAekFAKnkzUpamQs8nN7qXniHpKaNbFDabkID/GWMszHDypRnPSN+owUCOUjZir/MkxCd67xTtcGue/oVk7jOlKQWpKkrP9q3QUlVxIScJWR2evt5MBtm3aaKVBRwCKge+hszcrVhSKI0cq2yDrA2Nc8opZ+7GxawFhKt1NQcw1JucsAGsY7zqU1905ppD1BMuGYYatWFi6NYwHmbfR7KGD206BRaWMXb8caYFC1lKqRkhkP4ZjkV9n1Ncxq/1MFOMbV8vyP5EzbE05jCMldQrY= X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(13464003)(189003)(199004)(24454002)(7736002)(58126008)(52116002)(83506002)(8656006)(8936002)(33896004)(9686003)(72206003)(2906002)(76176011)(68736007)(478600001)(53546011)(229853002)(106356001)(2501003)(55016002)(105586002)(4326008)(2201001)(25786009)(6246003)(305945005)(53936002)(8676002)(81156014)(66066001)(81166006)(47776003)(5660300001)(6116002)(6496006)(23726003)(50466002)(33716001)(42882006)(5009440100003)(6666003)(316002)(1076002)(16526018)(97736004)(110136005)(2950100002)(3846002)(386003)(16586007)(107986001)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3465; 23:ocZCVmCkpR4wKBtX1+iE0+gR6gh+1OB0ztksxgbt8?= =?us-ascii?Q?pDEz0Pv3/4UfBVI6jol5YUF+3/NF5OoqQIAnbsAlI2Owws17U4IbfyQYxjB7?= =?us-ascii?Q?ovUOnx0JRqde/nMHvfTq3hojMpFNrHaLcoAirfMntybAxEzS0OBT2cvrZuCi?= =?us-ascii?Q?9ZnxtF9Y8Fnt4xA8MfMgAB4OdGbrXVY6/2Xn3mrzs0b680XbpnJWPCNDqlEZ?= =?us-ascii?Q?64Q+kQbm36nFC4JuitQpDUZ7rOhwijsGUHTvwmqsfOMgb+7dOzeVvwFLwCxb?= =?us-ascii?Q?JKVzNixsxu2tS/IqyumeaeVdlX0BWtaLB3HhCLaaki8F9c5K0e0q401Y3/aa?= =?us-ascii?Q?1H2oeaWMJOy3QvyA/TcZ0jzRIRcyLFDFIfKa4A/TDi/+YwgmxBpSIqDqD0JA?= =?us-ascii?Q?M5U12VLtzSJdQMUFCu4WACju9lp7/CXB1Ycce0WEIz/gJpaJBWokOtmXMvY3?= =?us-ascii?Q?j+uGUH0Czp6PMK3hGDY9jMkwKMw7D7pMHJCUn00qxR5ChAv4Ez8UzqFMCEDj?= =?us-ascii?Q?8qp8pwCJ33Rv+SHVTcPrLcmXJN2jIrKFXyL1ReA2yrB+B/fOr0k/WUi2ipZa?= =?us-ascii?Q?+UbWWsyOxqg5xdu5mi/BBBLznGwAGGmguLDhGibltpYdE77/VZ0pB9uYY0bq?= =?us-ascii?Q?HCJ26RgDYPTWP91aNEXzRi/E6xBDp6NdSGmDDyy12OZQZRQXW+iEYOiCq2GY?= =?us-ascii?Q?FTi1KSNJgY/5loO6xQuXuPW0zDT3ZskUToVoKcIwMJ5VzJt+tnoh5UJc6FY5?= =?us-ascii?Q?FArrVY+lUGa1WxBUhL3yqT2ZVLH9nYNxktBclNE8eEyy4Wq4yXTHz69KMl8N?= =?us-ascii?Q?FVGTXiWZa5KtfewHkxZb0aA2gckHfnhJjgbwpJ1nDc2QQxXEekpXsAIjheFj?= =?us-ascii?Q?r7ePYVQj5iKtYs6L466xSxAabk8Go/BVFltTAHLtZqQifqfPtrfLZbaqUavu?= =?us-ascii?Q?3/nfPjiqzYXB0wpZ369DPaSg+XxvAschIIqmj3TRh3MqIwmCjtURrFN06/W5?= =?us-ascii?Q?wJdP4460G1yO9z3oWAWpyH3+OiW1lZVov2kSlmoWO//6cd9J3w0REIm2y4Ug?= =?us-ascii?Q?vOvHY6QZzwG68WBivNnfnnXOM0yGj0yEW3I2CzvaNL+X3Lk6LecciXoRPHBN?= =?us-ascii?Q?HpVZEoksV4MqSqCS1O0mpNu0JMR6wAOJJ3SwFI/JxnplRbIKbQSMhljgJMon?= =?us-ascii?Q?319z8ctdRzs+X9jDn/i4NyKQ6JxxO5fZ2ogVk/CsKrJ8Z8U0RLcQZtgCeoiB?= =?us-ascii?Q?TjS0+7JEteFRwl0AUDgjUApq5Bxv9DQvX7anKSbB7TTZBbLDDJRXuy5wyS8T?= =?us-ascii?Q?82wpjpklef+EbQM+eGQ058=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:AHdKEENcfbfnHHfuA98w06WIhbNm3+ous52Qf5cjvkKgGxYM4SlxxXy0CpUYIwUXEZW9ZKTxo0a2DmyYiyMYuKAtOfCIax7duvpQ6OO+kb9fDHLEHFJD57kz8rxiMaXli6x6zibaXWO0qLRy+XiYnwJTMDIlMGQXZzT1QxiIdHaO7YOTn59lvmhHGSxdznMt4y/um8/MMIqgKVGVSSZdW/1N/xxDWyiNq/IYVpLCzsiYNhgSg0r9V5YHIFNPXljsTWzsU3kmgGWQQ8JKV0WErqg1DPbgc0T+jFrR3aYc4NXJ7dFOkyu9Zp+kJgTyecwLWCi1GHPJHGexEWsk1hXO1yJTWk39+ZHAuIMfxeu63D4=; 5:ADts9skMGrP9jSX9b4UlOocM6IJpi79JO0/XkoXNgpRfmBIHtE+/IdfpVIOJxK1hoCIjMH6/RLfvpAcB36MQSWmlVg5JP2VpO3jHR9ZaUi2jdmUMfYu1dq8xGAnYcFHxtEgnfDQTwf2fXHEvVGPRsal9FR22uDL606kRnJxRYbY=; 24:dDsOWkqIoQA3KQbXjfSuPMqO4erlmV+vuukdlwQMTICojCgqmNzotFhBDHC5Kc28CisAVcI/Uxs2ZtZAQf8yEllcr+tY5ZNIto00v7br33g=; 7:MHXNj4SHr7DsYQUOaB6ExemzextTaiwSKs469WaQbQRoDJlPc50HNQ1iBl4fKSTXpqALoS0rE9XrylqqlH25bSl6ans9+uD9JFFQGuKPWz8RsFpVOUp3kzOe55bVwl5/Yxe3pfIswBqbfsV/PLXRmU7sY5WSwpiCmE+visEgYxDmvq7HfTNGsVIz9y8y/onRE+9m2iWvHYBHu4cU76NVHHqODmmfdv5OcULvM2njgJaNbixO3SPkTdU6pKwQjED/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 11:20:08.7062 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7113f82-d656-4b48-0cb7-08d5421b79a0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: Re: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 13 Dec 2017 11:20:13 -0000 On Wed, Dec 13, 2017 at 10:19:51AM +0000, Van Haaren, Harry wrote: > > -----Original Message----- > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Tuesday, December 12, 2017 7:27 PM > > To: jerin.jacob@caviumnetworks.com; Richardson, Bruce > > <bruce.richardson@intel.com>; Van Haaren, Harry > > <harry.van.haaren@intel.com>; Eads, Gage <gage.eads@intel.com>; > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > <liang.j.ma@intel.com> > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test > > to driver > > > > Move octeontx eventdev specific test (test_eventdev_octeontx.c) to > > driver/event/octeontx. > > <snip patch content> > > Replying to 1st patch, as no cover letter; > > Summary of patchset: > - Move tests for a specific Eventdev PMD into the PMD dir: drivers/event/x/x_selftest.c > - Enable self tests to run when passed the vdev arg "self-test=1" > > > A few comments on this change; > > 1) We should not lose the capability to run tests as part of the existing unit testing infrastructure. We should not fragment the testing tool - requiring multiple binaries to test a single component. > > From discussion on #IRC, it seems reasonable to call rte_eal_vdev_init() with "self-test=1" from the test/test/ code, and then we can continue to use the existing test infrastructure despite that the actual tests are now part of each PMD. > > 2) We should not copy/paste TEST_ASSERT macros into new test files. Abstracting the TEST_ASSERT and other macros out to a header file would solve this duplication. > I initially thought of abstracting the macros but couldnt find a suitable file to place them in we have two options here, one is to use CFLAGS and include test.h directly (dirty) or have rte_assert/test in eal/common/inlcude. Thoughts? > > Specific comments will be sent as replies to the patches. Cheers, -Harry