From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0061.outbound.protection.outlook.com [104.47.37.61]) by dpdk.org (Postfix) with ESMTP id E543814E8 for ; Wed, 13 Dec 2017 12:24:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9+13zh72fbnaqujgpDDkLEFK+RhthbPUjfYTIU72Dok=; b=jwhVM/NVr/E4enMQuC5Xr9sCBLMXAFsfV4ClxtRGOYtc1EhQhfr6xefjB68YaxlrzneHgwnv+HQ9HJAv7ciDV58ZjywNBQWDitzaoKmsK2Iz8HWAD4CbEwEkZNHk05ZQydCrGxz/flhILSQrLq5OgTaiPOlCxrnV8FV+dbU4thE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 11:24:43 +0000 Date: Wed, 13 Dec 2017 16:54:29 +0530 From: Pavan Nikhilesh Bhagavatula To: Bruce Richardson , "jerin.jacob@caviumnetworks.com" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" Cc: dev@dpdk.org Message-ID: <20171213112428.fcjxjtfy65zevqhj@Pavan-LT> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171213103427.GA14464@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213103427.GA14464@bricha3-MOBL3.ger.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR01CA0100.apcprd01.prod.exchangelabs.com (10.170.138.154) To DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4298975e-d216-4cd4-a27f-08d5421c1d1d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 3:orobzu2eEd2xnXt3kGxpOuHFzyMLtGIUGgSfLjnqFMIdPop0vtspDgRpNTbwvGVkkdN/rlWAxx0fM3O/gjFbKKBzve+9ziR4ULmFfZDOsXVcajgdZha8+mdJgQS4exaP/pR/NeoVFyMDeqAop4zMtZ78bo4nqLTu4vTmHfib+0boBTcTfIssIoEdHoGzNyK6tmRf3cSmerwJ/PI0vhcvngBekkGN2WIYE3x0Qr7czfwUroX71cdDYJLkQ5UCAdde; 25:TSDXHQKAXZMPTtnGEfCPTuPl6DZWSe2adZYP/OR/cisBjh7hGlxMPkhB81rypS3jsZtmYCtAMOpvvfMLDIwx2btQAyNVz7Y5ZupYz8/pyA0nRCgsKHXqR18KN1ADHzlRZ2RPe09TB7kTxfP/NVT27/PHu1OvV+URo/96TuZd7MGNq0SQByPqbh6LqNB1U09ALfRnCRR6Je64UeffpTl3PcU9+mKMW3y0FUi2uST0WHIHfp3UgYs84sTF3Rpz62J6JkDhBfvFcV0qsSozpZviyzJadDqcWLcGtm8qhr1W/AaLOE8N4MN5MdsU+TzMf989xOUSfG4dISvR5UQ8++xTFz4EEfNtsFgCLf9tvtDnufY=; 31:w9nbt5onncOgWcntXjk6oOYsaPnLQijpDV7jIcO6/T6VEjxj4AXILSsFpP+CkbIMjsuUxbrN15kyCYeBpXlLVH+IO6Bxy2knnHGE8EcvSdTuT+mtO04Rk0v+WYOZj5aeuNa4CKqswnbDb4oPYGmL1ylngKT316tRqd9aJNUeKYpObrKkJ8cMj6iEXaVZ1PfPANNz1FKc7S7Dna9sXwafx4bqQMW0+2vue054dzpxj/I= X-MS-TrafficTypeDiagnostic: DM5PR07MB3466: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 20:kD4aXBx4mC4O3Zw/+zDqQEl/UcqKsb9DSUSk7srZ5Y6fwG2RrQOw228hbKwZnKTZ2Pht2HnlXfYE6n/DizsWVtWSbjixAnEgOEyhB4Vm0mEw446t+neUK17V3Z3nqSpx4ZwHfK9BOMaNWGyMtW3N2RmOvXrn60fXwV+CWK7p4PBhihYcfWc5r5umfOKTBGZjtCUmiMCddguSYoUW6JJp9xEuxrkK4GpdcjcWJSJQBhh9v4lF5yPxTzMhJsZJP7MlgSp/w23tugXHV20pUXdKTzhLoBAL4apv8Vfi8TJ8R0ijOJUTJ4GPe5A+KWyNxhe2I5ff6RrX698TCQ0wUGiLEaunu+zN0ws9oHfvktoH0tBv/TVShMyELeVWy/8VG6ymUEfccG0fNiqvto8izsGKPYGdS9ynzkyRhwuTWQDIDyVLFeB1ojNWDxDUIWE4THeaxEN0EOLEcdshVvw0aVqivpiANUKt9g8f+lOLuKjIGCArqinRJ240A+xki4gHMvXmtVnl6GlbGgfCqLjJkUw5Gyh66GGlbRmOftkgnDTmYbk9ALtdDDmn0KTUgrS6H2UK09XCLf+zr5ETwpGPwb1OxB8Xu1r6wNtUi7LZDDoez1E= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197)(228905959029699)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231023)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR07MB3466; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 4:gJJ0t9ELOX27YnG3YIaHD7ih45p8p+a9koRBbhY45bqeWpE0UgLgvtT4j70bxMc2duG1D9xarzDmRT58apqNK2fLjAECeu1kLDyarKwRCTuj57ALTtiX/GPOqRkGsINJwRTAujBVHbJ5fq53ZWTVBF8IKX8UJOIWLUB2zaN59G468FVQmmyk/c9oOu3N+WHJn844XEukiVEi8FEd627k/x/a9x1+XOd0DBN8/BIdTqRevcFG5in1jfJ1UckeBR6geTOcgp7BL4ce5JJpD0rqDmwt+ggdJK94OA6GynUzC39cDbR1HjdHKZMGon7+64YWfZ9VaBm8Ap/hCQEqj88y5DhwuNVQ7qqVu57291NPMEsC50VJg5PJ7fmWpMNL5GA5DpKbfvHLLbsyR0dStVw0OCxMObsqW3xtw4ugJ+pqyz4= X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(199004)(189003)(13464003)(24454002)(47776003)(2950100002)(97736004)(3846002)(2906002)(229853002)(6246003)(83506002)(1076002)(52116002)(5660300001)(105586002)(305945005)(58126008)(6116002)(66066001)(53546011)(7736002)(72206003)(23726003)(25786009)(50466002)(8676002)(81166006)(81156014)(33716001)(478600001)(4326008)(316002)(33896004)(2201001)(110136005)(68736007)(8936002)(9686003)(16586007)(53936002)(6666003)(6496006)(8656006)(55016002)(2501003)(16526018)(76176011)(106356001)(42882006)(386003)(5009440100003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3466; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3466; 23:MArHASw70pUSeqbr92fiTeiOmIvJwQpFuPDfdw+yO?= =?us-ascii?Q?ixnrkCWdIoGiwbBZ/+DrpZeMGpuWhdxOcCO4jmtHLODoAqjIzAU3Xi+bLpxX?= =?us-ascii?Q?uCD5ZI8yil9Qf6nWwyVZXTTKO/OC6bgECanJFOPHMlyCibDHXr+gS6ou/rlv?= =?us-ascii?Q?8C2byYi+Iq/O/d0bys7gJIXXntRnYGZebaIZLjVNUBI8M7SMyJSvXchqzQBy?= =?us-ascii?Q?xbhBiuDQ+gGf9+oroUkBwr+ytJUm/6dGAFF/Gy+c78qgvCfLyI3LUtNAIqvP?= =?us-ascii?Q?bB2pVghWyaEQ9qJkm1vW26Iyc55MVUqncTmG7pdouaE8Fs/jr5KVW+hSc6fg?= =?us-ascii?Q?PzgzijbzrE1W/17PlrecznJuCTGwPfYxNGx9/OSBlXP4jS6ayCSw2+535UP4?= =?us-ascii?Q?qeCNtFUuXx0pnboUsaPduLCDtL/fZyxah5x0mtt6bdz3L3ryE0XgXA6RjMgx?= =?us-ascii?Q?tN4G8eqlqdXdAIuQwHl7VadlYtFCcpClB07DzXZlEI9U1839msisgbBIz4ff?= =?us-ascii?Q?CJbBsfd3tt23gcrO7e9m1u/Dp/phjFA8USE1CVGE9DsGBNnqWZuJDZcarmdp?= =?us-ascii?Q?1rwtwQe4lKYDeAct4X+6KJWNVhSUzu951sx7iwnsBjeA4au5mI+lqJKziJIA?= =?us-ascii?Q?kqA21U0mbknkGvs0ewCUED+lUxod9jaDHYe/gmH+9hgaiehv+s5aCHRJCdLN?= =?us-ascii?Q?xadFLtLn/41gwpCAMilMBU36shg+M/ryu9nKKfD22cgdrxWG/c3GhYjLhNFy?= =?us-ascii?Q?2yPeR0oG4voYytkkbsfGaNmfxWwfElIFvZ3/6nULZdUAQ5PGKR4pamY9FNm2?= =?us-ascii?Q?d8D6L3cq4G2B3EvzNCDsAW4wWNi1zAOfEQCK8gvilLEuUsq+MHixBYtfBdK4?= =?us-ascii?Q?f/sOjkQbjrVXOMLsfAZT1ij383+24OZnTUaz3jXsOi41dK3Y5ZjKf+bARKIz?= =?us-ascii?Q?mfjpO9CHKZpNJL4iGAsIMirehry6VktYSJ4LvOL3ms6FiEvYycjLAE+LzTQJ?= =?us-ascii?Q?54nryC6JLnBW5IBO87b/CSpmfPnhw/xDySOgjyEFZPqYrb6s28v8I1juHnaa?= =?us-ascii?Q?IMBIVXqdMjPfKJikyv6XU14jfxs4sHQ9GKBeQZBmBsE8Pj8pGLlg5Ax5BOil?= =?us-ascii?Q?siKCeinBaYiTuWGq8044s/SRsk+HouJyu8lrl/Dqyw4jH4hvl++m1fNPy88Z?= =?us-ascii?Q?RwHbQgVctIIY96aWfw18VVME0kvVnjME3YRUQijsVfAnr2ZtLkAw3SEUMuH7?= =?us-ascii?Q?PBghsMm6C5PzXqJji8J2KseNW/S3HKa9+5XCG5d?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 6:slIxh3U80FtAQbvUMEDdMiSUKzt3EFugDqhFyJ4jBfAz1EU1YyrNxxI/Z7kUDk8v83G8b0RzG7VxK4uQcjdZxi3xauya94He3yYdm9Ovxx04Eufs2i0Q6fZ+Qnl3CUD/6UHNAKWvSWhjq0esoJXmk0Bb7oBzSv6xufodWTebbNmrdmgT02g9mjDHZfzRhjfGu1hYIaGw3XntfsdHotqYMNDKq3l1lhDbBLZ5eWfYLwprp8qe5JcaKbYIKaTlJ+Eqlbweb7kCsWiQNS+1+1+qX+GD2mzwIsy1k1qIWCc17rZxomak+43mWd1QH8Kysu1LTaUnXf1tQ55zGtNM8DhucXK5ZdPGEb49FRRo5PjfD5A=; 5:E0pSGSty6jjYgmZ8NU8OVIzFhRda1Ei5XVMY7cOrm/nNnjKbOmTFIoTkp/lqIVoZhmBPhyu7080qDH+ZRNfmQRRQAbWkZ3LIKEfDxoQtHBuJml+WgmWtVzIwK2Hj4HlCbm7FOhsbWsMvJCv0wVdFGRxpLjSzf9PH+18oS/vyruk=; 24:E4qR4+2DvY2PmoE5Ak+Szh/QXECcWTYOpcw1Xy8/9L5bhICHbbgxC806kC87zU3og8EsuunsY63c4nCa8IizaL1GebBokT8Qf136u3faNtU=; 7:reqTYLWf82HytPrbtyy3RSVB5lYir32evZPYhkvJgQNtPivjMIcaKRY3tcsVWciBhoKH+JolfpoX/ocbUcCk8lG+3a/KoPoJVZIFqyPrjVxBsyDpilJOMHQ/FyW0SflI7R+I7maRd3DANlSfTBG1jlg1P16U0OuM9NjDRoGS7GSZ2+Ki7PUdDPyzpUe47fst0DW0DgK6cT28dQdtiaM/DMiPwNWr6sq0S1MpYO//2GGGTv8VcIbm9RI0FeEe9Mmn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 11:24:43.2323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4298975e-d216-4cd4-a27f-08d5421c1d1d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3466 Subject: Re: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 11:24:48 -0000 On Wed, Dec 13, 2017 at 10:34:28AM +0000, Bruce Richardson wrote: > On Wed, Dec 13, 2017 at 10:19:51AM +0000, Van Haaren, Harry wrote: > > > -----Original Message----- > > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > > Sent: Tuesday, December 12, 2017 7:27 PM > > > To: jerin.jacob@caviumnetworks.com; Richardson, Bruce > > > ; Van Haaren, Harry > > > ; Eads, Gage ; > > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > Subject: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test > > > to driver > > > > > > Move octeontx eventdev specific test (test_eventdev_octeontx.c) to > > > driver/event/octeontx. > > > > > > > > Replying to 1st patch, as no cover letter; > > > > Summary of patchset: > > - Move tests for a specific Eventdev PMD into the PMD dir: drivers/event/x/x_selftest.c > > - Enable self tests to run when passed the vdev arg "self-test=1" > > > > > > A few comments on this change; > > > > 1) We should not lose the capability to run tests as part of the existing unit testing infrastructure. We should not fragment the testing tool - requiring multiple binaries to test a single component. > > > > From discussion on #IRC, it seems reasonable to call rte_eal_vdev_init() with "self-test=1" from the test/test/ code, and then we can continue to use the existing test infrastructure despite that the actual tests are now part of each PMD. > > > > 2) We should not copy/paste TEST_ASSERT macros into new test files. Abstracting the TEST_ASSERT and other macros out to a header file would solve this duplication. > > > > > > Specific comments will be sent as replies to the patches. Cheers, -Harry > > What I gather from a cursory glance at this set is that the self tests > are designed to be triggered via devargs to the device driver, correct? > I'm not sure I like this approach, though I do agree with having the > tests inside the individual drivers. > > What I think I would prefer to see is the self-tests being called via an > API rather than via devargs. I think we should add a > "rte_event_dev_self_test()" API to the eventdev library, and have that > then call into the driver-provided tests. This means that self-tests can > only be called by applications which are set up to allow the tests to be > called, e.g. the autotest binary, while also avoiding the issue of > having lots of driver specifics clutter up test binaries. Agreed, will modify it to ops based scheme so that application can call driver specific `event_dev_self_test` and register selftest in test/test/test_eventdev.c. Although we would like to retain devargs selftest scheme for event_octeontx. I will remove it for event_sw. Does that sound good? > > Regards, > /Bruce Regards, Pavan