From: Stephen Hemminger <stephen@networkplumber.org>
To: "Liu, Chunmei" <chunmei.liu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk
Date: Wed, 13 Dec 2017 14:51:45 -0800 [thread overview]
Message-ID: <20171213145145.010ac6c3@xeon-e3> (raw)
In-Reply-To: <DC5600B81EFB7C4A9AC03A0808E8AB4A96DD028D@ORSMSX113.amr.corp.intel.com>
On Wed, 13 Dec 2017 22:46:30 +0000
"Liu, Chunmei" <chunmei.liu@intel.com> wrote:
> Hold on, Let me try another place to fix this issue.
>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, December 13, 2017 1:31 PM
> To: Liu, Chunmei <chunmei.liu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk
>
> On Wed, 13 Dec 2017 11:32:32 -0800
> chunmei Liu <chunmei.liu@intel.com> wrote:
>
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> > b/drivers/net/ixgbe/ixgbe_rxtx.c index 1e07895..30fdbc1 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -1589,6 +1589,7 @@ ixgbe_rx_alloc_bufs(struct ixgbe_rx_queue *rxq, bool reset_mbuf)
> > }
> >
> > rte_mbuf_refcnt_set(mb, 1);
> > + mb->next = NULL;
> > mb->data_off = RTE_PKTMBUF_HEADROOM;
> >
>
> This will have measurable performance impact because the next pointer is on the second cache line.
Please do not do top posting on open source mailing lists.
next prev parent reply other threads:[~2017-12-13 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 19:32 chunmei Liu
2017-12-13 21:18 ` Thomas Monjalon
2017-12-13 21:31 ` Stephen Hemminger
2017-12-13 22:34 ` Liu, Chunmei
2017-12-13 22:46 ` Liu, Chunmei
2017-12-13 22:51 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-13 23:44 chunmei Liu
2017-12-14 7:47 ` Thomas Monjalon
2017-12-14 9:24 ` Olivier MATZ
2017-12-14 11:54 ` Ananyev, Konstantin
2017-12-13 23:40 chunmei Liu
2017-12-13 19:28 chunmei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213145145.010ac6c3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=chunmei.liu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).