From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 4C93E14E8 for ; Wed, 13 Dec 2017 23:51:49 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id j9so2068216pgc.11 for ; Wed, 13 Dec 2017 14:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RKKfQpB+ZHWlqsBRfR5Mu9trIO64MNcNJ/ebYONzntU=; b=aHaOFw7huKf6WiMfgRSgpaN8DvGjcEmaDiEktnTNxsrpuE6xv8a0cWJozXc8SVKEBp WzSHsg5uCMlQna4uKHvyCm6uNRQ8p6xH2oApw9iVcDIBKE96upMq+H7MKmRnB6PROZVz 1VjhT0ZJRuJXk8A5sgPCE/pMchWjJpLPIm/qLpuD72WkYj4HD34ypc71oeNyVE7+4jjA yQ8w3AVWlL9vUub+JBj1RyRGgkc/wHZI3TR9QiUfgtmbN+eJH8xYKH3ntcCyl+4cSIYe 1eLGcJoj/PHsMpJKK6FFnlgHqLYixFDXgaekFsZBAJ9qRsRp0n5G3KNthrxTAXE//mPA aaGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RKKfQpB+ZHWlqsBRfR5Mu9trIO64MNcNJ/ebYONzntU=; b=ObikoMD6u5FWBjlH0BkN4ZRQ+a+CiEaWBBTGOWOo15YlaAnqfG2wL2KWlsB+cMcKL5 OcMbSdBFXXkH8saB9aMiOagO/Cp9nvmX5leBVvM1vjJNXSSGb8/BWhyg2uaQ3rEvVfA8 fguAtbJiMgtmQrNojMjWYGaAXS2uSrIOlipovLrQWhICr4nOOKR5aLPJoJ3zfZtquHbk 2PIRRDhOrO3DQy0SH9h0Gz5K4vJDzQQbp3v81e0Sz30xkWogibuqcNrnd5zh2B1HSQkE 2JWPNb/pPQHmFJmgGPy5pF3TDJXA0ko6PayKYVXI+dMGjvD7xwXy9nZm1OFmKpaYt91C I0bg== X-Gm-Message-State: AKGB3mLPM3NWHrqJmYT+qC0SO3pLlMBzBZFiBiXHsDROmqPI/j9EO64d DgY+xf0AcgcSY3xIEzig9xwFgg== X-Google-Smtp-Source: ACJfBouncqhZi2qcc41TBgpxxHQNv7o8DD1C4jwPgBA4aWXNxzqLGHU0I5Ho5Y9XEZCiGu0FDn6bYQ== X-Received: by 10.84.234.193 with SMTP id i1mr7337694plt.146.1513205508291; Wed, 13 Dec 2017 14:51:48 -0800 (PST) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id 75sm5326854pfo.103.2017.12.13.14.51.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Dec 2017 14:51:48 -0800 (PST) Date: Wed, 13 Dec 2017 14:51:45 -0800 From: Stephen Hemminger To: "Liu, Chunmei" Cc: "dev@dpdk.org" Message-ID: <20171213145145.010ac6c3@xeon-e3> In-Reply-To: References: <1513193552-159561-1-git-send-email-chunmei.liu@intel.com> <20171213133100.530518bd@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 22:51:49 -0000 On Wed, 13 Dec 2017 22:46:30 +0000 "Liu, Chunmei" wrote: > Hold on, Let me try another place to fix this issue. > > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, December 13, 2017 1:31 PM > To: Liu, Chunmei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk > > On Wed, 13 Dec 2017 11:32:32 -0800 > chunmei Liu wrote: > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index 1e07895..30fdbc1 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -1589,6 +1589,7 @@ ixgbe_rx_alloc_bufs(struct ixgbe_rx_queue *rxq, bool reset_mbuf) > > } > > > > rte_mbuf_refcnt_set(mb, 1); > > + mb->next = NULL; > > mb->data_off = RTE_PKTMBUF_HEADROOM; > > > > This will have measurable performance impact because the next pointer is on the second cache line. Please do not do top posting on open source mailing lists.