From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0074.outbound.protection.outlook.com [104.47.42.74]) by dpdk.org (Postfix) with ESMTP id 193A32030 for ; Wed, 13 Dec 2017 16:50:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3sFru4vtTKKAsk4HIQIeXa+SFr5jv1Dfhfbp6LJwJ4E=; b=bGmgP/+U2ur8NI0CPhd9RZ83EbHuvGMP1nZatA9KPQH86PQFTtf0WMaeLMjede70Ddp99VnRkIYSPVGJdcf4BB7YandVyBn33eHnApRyAOE/yXir2Ks1QVJPqCEs9Q9SmvvDPtRF2rBuViJv9aKjWr0hiesvxFX1IzKE4x5AMlM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by BN6PR07MB3460.namprd07.prod.outlook.com (10.161.153.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 15:50:49 +0000 Date: Wed, 13 Dec 2017 21:20:24 +0530 From: Pavan Nikhilesh Bhagavatula To: Bruce Richardson , "jerin.jacob@caviumnetworks.com" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" Cc: dev@dpdk.org Message-ID: <20171213155022.q7rmumsi4hcjalqw@Pavan-LT> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171213111946.p7g7dk4gaugpxseu@Pavan-LT> <20171213114155.GC74296@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213114155.GC74296@bricha3-MOBL3.ger.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR06CA0153.apcprd06.prod.outlook.com (10.175.208.159) To BN6PR07MB3460.namprd07.prod.outlook.com (10.161.153.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b03fb56-0e31-4b56-6a23-08d5424149a9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:BN6PR07MB3460; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 3:C+fyOpb4ELiuP7H82/kUdfsuDSS9/Vn3Q1pN0BZVV1R5CUeNlQP4biYkwHQp+EfiubF9BerXm6K6kQOWTdFysB4FR4fd9kD1LdJ4lCsJCEigtrplAcesMZSuCbqEWGClctN08xUvylFpcus+b41CxOrhfBzom6oRlExgXL5VWadAlH38dBgwirD+02g02bvdFcT7w9oditLNTaullA8ltTjsIK6EDQEdp8gUS5pPaqqx/msUnqw7Nah6C4/OPC+k; 25:a9qd96RUr+XPqreIoymoaDAGXoPtZOKbuUNYXzwIlSeL3vUiIa779ZkDqzGv77F1I1HMSb3A0GvYtJv33DVFt071Gz5pNAApXUcrXiOLkcDUscmC/JwcVh39JVTVzGnwrOiD4LMoLJ3vkvjgsQcXY/P4JswY3ul8t/K7wB7uQ6BPHcGOcryiAzyCGCjwX2yDFBQr/wmU+KeDQ8kIc6PRrbSHiaGr7WJiuWztSJBNDKP/SPZVTNyuPNCv6GpFDCSmGH+V64bSnP3RsHGN6vziF0muSf2kPBHkD+7DLhXvgyOuKWyV+fNQ+ixJaBkaDfod+8LzO/x438XGKWdzUkh0yQ==; 31:dJVHHDLt2RRaE/CzTlvLclUGTg+0oQGVmUSxlE9rEOycTwKiKHaa5q+gj2FikVYr9QpYgBPgr2pQPtbwhmT9zd0c5R6u7aCgV60GafFMNOg/In2Lr4/RT4sO3KzerRPFa/8M3yExg+rsMz6xFHIa9LSJ+I314o4GeVwYfSw7dF5mpcV+9VP8paYxkfN9ePKRY47iijJtJaJ7htgMt3fZ1n7rg5JX8+7QagrpaE4zDYc= X-MS-TrafficTypeDiagnostic: BN6PR07MB3460: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 20:+yIP9V6O2y9DUIfStRhlxKXK/YHZ535ceQ6s6mwrqgX59g7TWB8GBsYKzT+HJxXzrWG7BN7WHJMBRDeG5BNgKnEdBDboqBKSupUiJXwAk4pxu1r9nqAi2IT+vShrplHb22NjSsPzhyD+sxd0RTz87PZ2NkEp4jMOj566EaMRm7xN5dl+5ck/sPlBVEBIp/1AjYf4GmIM1CgLAU+bPRJIVrnRmBG5UisQsVITvuZjVLkSMl+6lMqB4lS2atTzcNfuGSvUyMXuy+Rg6nUt193TGJYSlHL2fNfYhf9Ke41BSe/8ED1WDOjZNWCE1G+AB2rQz2+BXZtfD308IxoMKpbyXnf2tPAUf5DFDghtxXoyg6qmIzlGUdQSRVStueYvF9wdZ1l8RJiCUR4VoAq+ZABNwY7W5rRasgGE8AteerrzrQzUdLSMQDwabsjz87vWSaLvNOrS8jfN4Bl47tEDPjoulsUHgnv/z3OMPaFb4VPYU4ZV2356tF27mrAI/ZOBlBf9pEMYeXW2gU+bPUjuiTILm5oomglUkcB64oKeVZRujtJMUzdZ6Imx5YWxok33cjIC4HmH6n+VLvjqnXgAtMRf+bOEo8+tGNCMtwV1lwYtSIQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231023)(10201501046)(93006095)(3002001)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011); SRVR:BN6PR07MB3460; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN6PR07MB3460; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 4:fcb15v1OUpQV8jjniNYamBarbS68zO1c4JaPz9af/e2JCUIhHh3uuq+sqUYsoz1rsrZfxHS4uHzlZhrBxpjH2WLcigh/TWRRjgwSZmcPK0G6nnUviep0Xh1eEMS2Vnfbn42JXSuLRrfQ/gK2gtNhetZbs4dmKIzliHjCtkncG2lCyjlMNKRjMex8GGuNMx4/aWxyh7FuoQWynZkdhO5DmVUwkGypTsXBT5a5x4Jc6JNeCwr4jJkwrt6RFelXP3Zrw+TFBGjXK02uCox3IdoH9I+0Ld4ccsi8m/mAiP1SKqLH/EELbO9h4KdfqzFjtlohMwz4UKcruYcsTXI7TMOaaGT1cAelbS6dZLgq/ZiYnow= X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(199004)(189003)(24454002)(13464003)(7736002)(52116002)(55016002)(50466002)(68736007)(5009440100003)(5660300001)(105586002)(97736004)(33896004)(76176011)(106356001)(66066001)(229853002)(81156014)(6496006)(305945005)(53546011)(83506002)(6666003)(16526018)(2950100002)(478600001)(72206003)(81166006)(8656006)(42882006)(8936002)(2201001)(8676002)(6246003)(9686003)(53936002)(16586007)(58126008)(110136005)(23726003)(47776003)(2501003)(316002)(6116002)(93886005)(1076002)(2906002)(25786009)(3846002)(33716001)(4326008)(386003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3460; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3460; 23:tyVWCsx4/hIugjudKVlPML6KcQPcdbjkR0CEofer0?= =?us-ascii?Q?NTebXoC4nsrDtuShbDn+8pdnj40NSnwWP4kyyPBMvD2MpZiERNUUuUhG368G?= =?us-ascii?Q?aIKmTQsFbcczgg9ej1XGH0mquZqViLMa0SpnaWfLNxmfByT5dgu6cJJTzzyl?= =?us-ascii?Q?gfAGzl32m0KlsVxdMm37hOQCdtJnyTcBuQ5AnJlwJNXt8zN9AdH4ipnfBEoF?= =?us-ascii?Q?19QBVeU/84AFemB30DFQTOCa+LEswHiJj5bzTqQ2q0XBeSh1bCZvi6TvY+Ul?= =?us-ascii?Q?0x82VYiVqhoR5LbyIKm5xTyTbVjfLSq5qEswMNuhK+zb97wanYsdjK/3Kqmo?= =?us-ascii?Q?tTKB1jubL5SkBDqPfdUccKmh1ifyD8OhHywihVyHoNKKAQOa54poKHwGiJnB?= =?us-ascii?Q?UvgbzwGGjQMDzTmQ3Fj4fa6SUzJm/KOrr7irxbnM24PRsD6pWWUvKQVjxukT?= =?us-ascii?Q?HdhGdt31tC9vJ7IXviBPFkfiWD/mQYdKfTkvLT+kjbPeQJF01FHJwSyEqAPA?= =?us-ascii?Q?9sPKnEN4olRxEaX8BJVQ0cyszim8/Iv/XCTd36zRTSa8RoMxx3eI73fi8tkR?= =?us-ascii?Q?C4NCBGM4VBBSlqKwccqM1NnZ3SUCN/bjJn1STCBVel68IorYbkLuC+nDnh0R?= =?us-ascii?Q?83ZGTI6GidO81bMdS41xVnVMleX3LGNrfYkOcQ0V16UAFz44vTn0bgOK65He?= =?us-ascii?Q?ydxfKj6xEx1m7cW+VLh/9yTI3EafyaQfPIfN0tYe7sRFVnMnV30ZwIx1/lcS?= =?us-ascii?Q?Hm0/uvXknMC8bJ+kLXR2S7X1+ft+pZu5Zoe5EePo6Id57u9wpju9KhA0v2Vj?= =?us-ascii?Q?9uhds51j2BVf/AjUJnENdX10a6PjjG8qu+3BtlPBszLVyJW+ONEm8gWbdPdG?= =?us-ascii?Q?KUT8HIxgaJGT60Uh2LVogo+meQsN9HhJp0gxlS0zcpPBSKqWRONWog7ycBF9?= =?us-ascii?Q?A92Ep/c86choIllVectf4ijaiFV9WC7UlSXFR7sgdbdpCb/Up7S17Cpdd/it?= =?us-ascii?Q?/n4hPdKC8rw6d34SttCLHbDNeHgw+mfmZqYa8l58r7QzLVHPVLX6MgdRKGnO?= =?us-ascii?Q?KcVumlP+0tMAm4EF95LiCNM7E/hix1AZhnegrs83OClD1XCwiqEE2Cs1cvvY?= =?us-ascii?Q?wFL4vb6b3iDcWiDrCE4ItrlFlJtEV9ZKzAY4lsSvuT24KniwFvtkQxUgoaQi?= =?us-ascii?Q?YdP8h384QIsMy9KdsNA/xESZ3jY2Qf+nwZR+BIL729uOXlO/0F+0eTNJB7C0?= =?us-ascii?Q?xciCynZdP01VXFnrZFUQiPtGoi2tFjtRZUV0BOKQv3GU+dqeq0/Y/WgoguSc?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 6:gamT8VJ7BJ3z1ce4mbW2N4nKULK1bViO84Dt48oUwK9BazklLrMDrGPaTVH91mW8cVpaK585OqK3Ftn3XdWkXrMuJtkm7qqNrhr76QtDlMvNgzHUzfAEzFoBa7yHgaYHqh9pDfQc7XxeEw3ZaXQZKBfy3XsMhKLlmH22gW6hohr3WpSfwoGdGaB9/DbdxBawffcvWDZSLVjx55ZUZiMcCXTcKWGn1WrOdx8CcJRo5VFkI5o57x5XhB5Y2uQQBDmANOZixLBs5/tV0D7DOzhqjuqOPNFv/DZEss3ppE2Wpf8kHe/IMQrk48SwVwgbfhoEbRQngWSOLH/PbF1br/O2NGy4QGTyrMWE6nmXyAVV9Sg=; 5:mEm5VhahdQjtvhp1ceZYwmuRm82WhXACnOquSmW2cqVrIH+pIw5IrpiykH0CEGT68L0db6ilAW0fREgVrzFH3mr57aHzoMe6s2Yjf4fy0h973miSyAaUsfyXjelp+EkmuiGIr+h1TH/nieETAWN6vHyV1kX19P6vbAc7pZdEOkE=; 24:RoiAUnwvCV2ZoRyfxhHJek9IM+cfWQny11BwcBeZOD/0t2EhM8ADO6ut19fH5Is4A3LQmEPFI2phPXhSO4OQ4UkXNvI0BJn+RA6V8PH5RsI=; 7:dTCnmgO2GmByzFvmkT4YW8jnxN2FvHBQniYxmOJHUcLXvZoxIZPg/VGldUaaew2xyi+StAWBuBRUhA0VjJBm36qgC7fswj2XUxDxYWX9yxj/20AF45EW9X89ihOJgDQf6XIh0eOTkUQX91Pf0hDQtCl+R3olxKEmW/TJ/yVoCUupulK3iQpty/ZopLiL3u/R5i6OtkzQc4YwjJ2mH2NxlPSGzRtV2L4qgCJPCKGxQU42iJXUDYD4MCj1GJvSBzlp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 15:50:49.1127 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b03fb56-0e31-4b56-6a23-08d5424149a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3460 Subject: Re: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 15:50:54 -0000 On Wed, Dec 13, 2017 at 11:41:55AM +0000, Bruce Richardson wrote: > On Wed, Dec 13, 2017 at 04:49:47PM +0530, Pavan Nikhilesh Bhagavatula wrote: > > On Wed, Dec 13, 2017 at 10:19:51AM +0000, Van Haaren, Harry wrote: > > > > -----Original Message----- > > > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > > > Sent: Tuesday, December 12, 2017 7:27 PM > > > > To: jerin.jacob@caviumnetworks.com; Richardson, Bruce > > > > ; Van Haaren, Harry > > > > ; Eads, Gage ; > > > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > > Subject: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test > > > > to driver > > > > > > > > Move octeontx eventdev specific test (test_eventdev_octeontx.c) to > > > > driver/event/octeontx. > > > > > > > > > > > > Replying to 1st patch, as no cover letter; > > > > > > Summary of patchset: > > > - Move tests for a specific Eventdev PMD into the PMD dir: drivers/event/x/x_selftest.c > > > - Enable self tests to run when passed the vdev arg "self-test=1" > > > > > > > > > A few comments on this change; > > > > > > 1) We should not lose the capability to run tests as part of the existing unit testing infrastructure. We should not fragment the testing tool - requiring multiple binaries to test a single component. > > > > > > From discussion on #IRC, it seems reasonable to call rte_eal_vdev_init() with "self-test=1" from the test/test/ code, and then we can continue to use the existing test infrastructure despite that the actual tests are now part of each PMD. > > > > > > 2) We should not copy/paste TEST_ASSERT macros into new test files. Abstracting the TEST_ASSERT and other macros out to a header file would solve this duplication. > > > > > > > I initially thought of abstracting the macros but couldnt find a suitable file > > to place them in we have two options here, one is to use CFLAGS and include > > test.h directly (dirty) or have rte_assert/test in eal/common/inlcude. > > > > Thoughts? > > > If other device types, e.g. ethdev or cryptodev, also take the approach of > having a self_test API (something I think would be a good thing, and I > actually hacked together when working on the i40e rx and tx code), I > think we should look to have an rte_test.h header file for such macros > to avoid duplication. > At this point, moving them to an EAL include may not be worth it for > just eventdev. > I think atleast having a basic version of rte_test.h (macros used by test_event_octeontx) would be good rather than taking a hacky path. Later on more stuff could be added when other devices make use of it. > /Bruce > Thanks, Pavan.