From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 0B7FE14E8 for ; Thu, 14 Dec 2017 10:28:22 +0100 (CET) Received: by mail-lf0-f68.google.com with SMTP id f18so5819603lfg.8 for ; Thu, 14 Dec 2017 01:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=l8YLK+NGqknHRw9b8EPT8HdvlezYTG4khqeW3N+Hhfs=; b=z9OgEqumLE6fVVC/QvFDuF1+Gu5KVdtou+VN93a9nepqFuT/OZMxziW8Nu7uO8cXHs hKIIeIP1Bw+R9B9nhvPz/5l0++nnc5t4HQ2v2b0lo53EJF3+e42Y8W3QB50vH0VqUEZK CFPTNM8HN06ftOMSQGRHBPagTNatxv+vknyJKot9kfZZ8PBAdA1ZZwGgvGZB3i1x2AHx U2YcxxOmHJO0RG4mgHIoSZFHeI4Ps4gq99vcSJdvvbS2S03XpIo/pD8ZLmKCpS65UtDM EDIbWF3Pl3rZ30Bs3pYJUEIOzukfFud9XjBdUaxT1knVh464Hh+xwYmtTZuqQ2zU0wY1 /pAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=l8YLK+NGqknHRw9b8EPT8HdvlezYTG4khqeW3N+Hhfs=; b=rcsre6YaXAsEj1L52I4m65eO7+sLWKXY0NYqSPaLrWaMTP8XGAUusnnq8BqaWugPUM qXgpPEcYQi+HnNsHaBTeGrRq2ZhEmp5SDOshhwgtEA3L75xDzeQZSy1LtdNDQCWidk7q SNq/oqOSe3VuFGPGyJQJdI3MFzlwnWLDiD3HIjRLdk12yu2qxaUodNxY6HuNKpgWA9R0 8bnuapnM1oPCYr/0M9ONr0guqU3rzQ1OmPsitohfW8gSHd9ey2aP0+vtFfbrtTXpFczw El1y1uazzL29IXYB4e6RPzHxXkMwmpCjA3DvbnZvUkRpq7VWgxonn3YFxc5wG+dOd10S yHRw== X-Gm-Message-State: AKGB3mKAUt2fwoelvRXfmTSkCjaVNqvTEqmAlpHOZD5qVvkMmiQWja0x c4q3HS9Nx9fMy/Vg5z7YUgLJbQ== X-Google-Smtp-Source: ACJfBosmYEJy1Xo9QiAbMjOwyDCjdsAj2E8zw5pjdBuX7ZdKqcs/KiiDKSHoNIIDm1eeXv1kOW0uEA== X-Received: by 10.46.22.1 with SMTP id w1mr3308224ljd.69.1513243701561; Thu, 14 Dec 2017 01:28:21 -0800 (PST) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id 91sm705725lfu.83.2017.12.14.01.28.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Dec 2017 01:28:20 -0800 (PST) Date: Thu, 14 Dec 2017 10:28:19 +0100 From: Tomasz Duszynski To: Pablo de Lara Cc: declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, jck@semihalf.com, tdu@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jianbo.liu@arm.org, dev@dpdk.org Message-ID: <20171214092819.GA5495@tdu> References: <20171213155408.83253-1-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20171213155408.83253-1-pablo.de.lara.guarch@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] cryptodev: remove duplicated device name length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 09:28:22 -0000 On Wed, Dec 13, 2017 at 03:54:08PM +0000, Pablo de Lara wrote: > Two macros were defined in cryptodev, to serve the same > purpose: RTE_CRYPTODEV_NAME_LEN (in the config file) and > RTE_CRYPTODEV_NAME_MAX_LEN (in the rte_cryptodev.h file). > Since the second one is part of the external API, > the first one has been removed, avoiding duplications. > > Signed-off-by: Pablo de Lara > --- > app/test-crypto-perf/cperf_options.h | 3 ++- > config/common_base | 1 - > drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h | 2 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 +- > drivers/crypto/armv8/rte_armv8_pmd_private.h | 2 +- > drivers/crypto/kasumi/rte_kasumi_pmd_private.h | 2 +- > drivers/crypto/mrvl/rte_mrvl_pmd_ops.c | 2 +- > drivers/crypto/null/null_crypto_pmd_private.h | 2 +- > drivers/crypto/openssl/rte_openssl_pmd_private.h | 2 +- > drivers/crypto/snow3g/rte_snow3g_pmd_private.h | 2 +- > drivers/crypto/zuc/rte_zuc_pmd_private.h | 2 +- > 12 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto-perf/= cperf_options.h > index da4fb47..04b8c01 100644 > --- a/app/test-crypto-perf/cperf_options.h > +++ b/app/test-crypto-perf/cperf_options.h > @@ -3,6 +3,7 @@ > #define _CPERF_OPTIONS_ > > #include > +#include > > #define CPERF_PTEST_TYPE ("ptest") > #define CPERF_SILENT ("silent") > @@ -102,7 +103,7 @@ struct cperf_options { > > uint16_t digest_sz; > > - char device_type[RTE_CRYPTODEV_NAME_LEN]; > + char device_type[RTE_CRYPTODEV_NAME_MAX_LEN]; > enum cperf_op_type op_type; > > char *test_file; > diff --git a/config/common_base b/config/common_base > index e74febe..9b856cb 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -471,7 +471,6 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=3Dy > CONFIG_RTE_LIBRTE_CRYPTODEV=3Dy > CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=3Dn > CONFIG_RTE_CRYPTO_MAX_DEVS=3D64 > -CONFIG_RTE_CRYPTODEV_NAME_LEN=3D64 > > # > # Compile PMD for ARMv8 Crypto device > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h b/drivers/c= rypto/aesni_gcm/aesni_gcm_pmd_private.h > index 1c8835b..b21b2ba 100644 > --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h > +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h > @@ -84,7 +84,7 @@ struct aesni_gcm_qp { > /**< Session Mempool */ > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > uint8_t temp_digest[DIGEST_LENGTH_MAX]; > /**< Buffer used to store the digest generated > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/cry= pto/aesni_mb/rte_aesni_mb_pmd_ops.c > index 3b3ef0c..ed87247 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c > @@ -409,7 +409,7 @@ aesni_mb_pmd_qp_create_processed_ops_ring(struct aesn= i_mb_qp *qp, > const char *str, unsigned int ring_size, int socket_id) > { > struct rte_ring *r; > - char ring_name[RTE_CRYPTODEV_NAME_LEN]; > + char ring_name[RTE_CRYPTODEV_NAME_MAX_LEN]; > > unsigned int n =3D snprintf(ring_name, sizeof(ring_name), > "%s_%s", > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h b/drivers= /crypto/aesni_mb/rte_aesni_mb_pmd_private.h > index fe3bd73..8314019 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h > @@ -154,7 +154,7 @@ struct aesni_mb_private { > struct aesni_mb_qp { > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > const struct aesni_mb_op_fns *op_fns; > /**< Vector mode dependent pointer table of the multi-buffer APIs */ > diff --git a/drivers/crypto/armv8/rte_armv8_pmd_private.h b/drivers/crypt= o/armv8/rte_armv8_pmd_private.h > index fa31f0a..534945f 100644 > --- a/drivers/crypto/armv8/rte_armv8_pmd_private.h > +++ b/drivers/crypto/armv8/rte_armv8_pmd_private.h > @@ -148,7 +148,7 @@ struct armv8_crypto_qp { > /**< Session Mempool */ > struct rte_cryptodev_stats stats; > /**< Queue pair statistics */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > uint8_t temp_digest[DIGEST_LENGTH_MAX]; > /**< Buffer used to store the digest generated > diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd_private.h b/drivers/cry= pto/kasumi/rte_kasumi_pmd_private.h > index 5f7044b..f48f25f 100644 > --- a/drivers/crypto/kasumi/rte_kasumi_pmd_private.h > +++ b/drivers/crypto/kasumi/rte_kasumi_pmd_private.h > @@ -72,7 +72,7 @@ struct kasumi_private { > struct kasumi_qp { > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > struct rte_ring *processed_ops; > /**< Ring for placing processed ops */ > diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd_ops.c b/drivers/crypto/mrvl= /rte_mrvl_pmd_ops.c > index 434cf85..a1de33a 100644 > --- a/drivers/crypto/mrvl/rte_mrvl_pmd_ops.c > +++ b/drivers/crypto/mrvl/rte_mrvl_pmd_ops.c > @@ -558,7 +558,7 @@ mrvl_crypto_pmd_qp_setup(struct rte_cryptodev *dev, u= int16_t qp_id, > int socket_id, struct rte_mempool *session_pool) > { > struct mrvl_crypto_qp *qp =3D NULL; > - char match[RTE_CRYPTODEV_NAME_LEN]; > + char match[RTE_CRYPTODEV_NAME_MAX_LEN]; > unsigned int n; > > /* Allocate the queue pair data structure. */ > diff --git a/drivers/crypto/null/null_crypto_pmd_private.h b/drivers/cryp= to/null/null_crypto_pmd_private.h > index 7c7852f..58c72ee 100644 > --- a/drivers/crypto/null/null_crypto_pmd_private.h > +++ b/drivers/crypto/null/null_crypto_pmd_private.h > @@ -67,7 +67,7 @@ struct null_crypto_private { > struct null_crypto_qp { > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > struct rte_ring *processed_pkts; > /**< Ring for placing process packets */ > diff --git a/drivers/crypto/openssl/rte_openssl_pmd_private.h b/drivers/c= rypto/openssl/rte_openssl_pmd_private.h > index 26bf862..999bf0b 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd_private.h > +++ b/drivers/crypto/openssl/rte_openssl_pmd_private.h > @@ -98,7 +98,7 @@ struct openssl_private { > struct openssl_qp { > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > struct rte_ring *processed_ops; > /**< Ring for placing process packets */ > diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd_private.h b/drivers/cry= pto/snow3g/rte_snow3g_pmd_private.h > index 7b9729f..5f98a27 100644 > --- a/drivers/crypto/snow3g/rte_snow3g_pmd_private.h > +++ b/drivers/crypto/snow3g/rte_snow3g_pmd_private.h > @@ -72,7 +72,7 @@ struct snow3g_private { > struct snow3g_qp { > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > struct rte_ring *processed_ops; > /**< Ring for placing processed ops */ > diff --git a/drivers/crypto/zuc/rte_zuc_pmd_private.h b/drivers/crypto/zu= c/rte_zuc_pmd_private.h > index a57b8cd..e70b8e6 100644 > --- a/drivers/crypto/zuc/rte_zuc_pmd_private.h > +++ b/drivers/crypto/zuc/rte_zuc_pmd_private.h > @@ -73,7 +73,7 @@ struct zuc_private { > struct zuc_qp { > uint16_t id; > /**< Queue Pair Identifier */ > - char name[RTE_CRYPTODEV_NAME_LEN]; > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > /**< Unique Queue Pair Name */ > struct rte_ring *processed_ops; > /**< Ring for placing processed ops */ > -- > 2.9.4 > As for mrvl crypto pmd: Acked-by: Tomasz Duszynski -- - Tomasz Duszy=C5=84ski