From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 2E37E107A for ; Thu, 14 Dec 2017 14:36:08 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ePTmL-0007YZ-PE; Thu, 14 Dec 2017 14:42:27 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Thu, 14 Dec 2017 14:36:00 +0100 Date: Thu, 14 Dec 2017 14:36:00 +0100 From: Olivier MATZ To: Andrew Rybchenko Cc: dev@dpdk.org Message-ID: <20171214133559.i5ppbar2vko6kocu@platinum> References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC PATCH 0/6] mempool: add bucket mempool driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 13:36:08 -0000 Hi Andrew, Please find some comments about this patchset below. I'll also send some comments as replies to the specific patch. On Fri, Nov 24, 2017 at 04:06:25PM +0000, Andrew Rybchenko wrote: > The patch series adds bucket mempool driver which allows to allocate > (both physically and virtually) contiguous blocks of objects and adds > mempool API to do it. It is still capable to provide separate objects, > but it is definitely more heavy-weight than ring/stack drivers. > > The target usecase is dequeue in blocks and enqueue separate objects > back (which are collected in buckets to be dequeued). So, the memory > pool with bucket driver is created by an application and provided to > networking PMD receive queue. The choice of bucket driver is done using > rte_eth_dev_pool_ops_supported(). A PMD that relies upon contiguous > block allocation should report the bucket driver as the only supported > and preferred one. So, you are planning to use this driver for a future/existing PMD? Do you have numbers about the performance gain, in which conditions, etc... ? And are there conditions where there is a performance loss ? > The number of objects in the contiguous block is a function of bucket > memory size (.config option) and total element size. The size of the bucket memory is hardcoded to 32KB. Why this value ? Won't that be an issue if the user wants to use larger objects? > As I understand it breaks ABI so it requires 3 acks in accordance with > policy, deprecation notice and mempool shared library version bump. > If there is a way to avoid ABI breakage, please, let us know. If my understanding is correct, the ABI breakage is caused by the addition of the new block dequeue operation, right? Thanks Olivier