From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5BEA6397D for ; Fri, 15 Dec 2017 14:50:45 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2017 05:50:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,405,1508828400"; d="scan'208";a="3052668" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga008.jf.intel.com with ESMTP; 15 Dec 2017 05:50:42 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id vBFDofUA019819; Fri, 15 Dec 2017 13:50:41 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id vBFDofOZ008345; Fri, 15 Dec 2017 13:50:41 GMT Received: (from lma25@localhost) by sivswdev01.ir.intel.com with LOCAL id vBFDofsD008341; Fri, 15 Dec 2017 13:50:41 GMT Date: Fri, 15 Dec 2017 13:50:41 +0000 From: "Ma, Liang" To: Neil Horman Cc: jerin.jacob@caviumnetworks.com, dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com, deepak.k.jain@intel.com, john.geary@intel.com, peter.mccarthy@intel.com, seanbh@gmail.com Message-ID: <20171215135041.GB1173@sivswdev01.ir.intel.com> References: <1513337189-137661-1-git-send-email-liang.j.ma@intel.com> <1513337189-137661-2-git-send-email-liang.j.ma@intel.com> <20171215123859.GA6831@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171215123859.GA6831@hmswarspite.think-freely.org> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v2 1/8] event/opdl: add the opdl ring infrastructure library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 13:50:46 -0000 On 15 Dec 07:38, Neil Horman wrote: > On Fri, Dec 15, 2017 at 11:26:22AM +0000, Liang Ma wrote: > > OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library > > provide the core data structure and core helper function set. The Ring > > implements a single ring multi-port/stage pipelined packet distribution > > mechanism. This mechanism has the following characteristics: > > > > • No multiple queue cost, therefore, latency is significant reduced. > > • Fixed dependencies between queue/ports is more suitable for complex. > > fixed pipelines of stateless packet processing (static pipeline). > > • Has decentralized distribution (no scheduling core). > > • Packets remain in order (no reorder core(s)). > > > > Signed-off-by: Liang Ma > > Signed-off-by: Peter, Mccarthy > > --- > > drivers/event/opdl/Makefile | 66 ++ > > drivers/event/opdl/opdl_ring.c | 1232 +++++++++++++++++++++ > > drivers/event/opdl/opdl_ring.h | 601 ++++++++++ > > drivers/event/opdl/rte_pmd_evdev_opdl_version.map | 3 + > > 4 files changed, 1902 insertions(+) > > create mode 100644 drivers/event/opdl/Makefile > > create mode 100644 drivers/event/opdl/opdl_ring.c > > create mode 100644 drivers/event/opdl/opdl_ring.h > > create mode 100644 drivers/event/opdl/rte_pmd_evdev_opdl_version.map > > > > > > > + > > +#endif /* _OPDL_H_ */ > > diff --git a/drivers/event/opdl/rte_pmd_evdev_opdl_version.map b/drivers/event/opdl/rte_pmd_evdev_opdl_version.map > > new file mode 100644 > > index 0000000..5352e7e > > --- /dev/null > > +++ b/drivers/event/opdl/rte_pmd_evdev_opdl_version.map > > @@ -0,0 +1,3 @@ > > +DPDK_17.05 { > > + local: *; > > +}; > you need to ennumerate the functions you want to globally export here, or this won't work > as a shared library. This also suggests you haven't tested this as a DSO yet, > please do so. > > Neil FYI, the subject of email has indicated that's part of the PMD. there is no need to export any function globally. you can reference drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map /drivers/event/dpaa2/rte_pmd_dpaa2_event_version.map drivers/event/sw/rte_pmd_sw_event_version.map BTW: I do test with shared library build. > > > -- > > 2.7.5 > > > > -------------------------------------------------------------- > > Intel Research and Development Ireland Limited > > Registered in Ireland > > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > > Registered Number: 308263 > > > > > > This e-mail and any attachments may contain confidential material for the sole > > use of the intended recipient(s). Any review or distribution by others is > > strictly prohibited. If you are not the intended recipient, please contact the > > sender and delete all copies.