From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0083.outbound.protection.outlook.com [104.47.34.83]) by dpdk.org (Postfix) with ESMTP id 49CBCE5D for ; Mon, 18 Dec 2017 07:30:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=siNElaXfS+H0eBhPbQKlZaPdrd6x/3tP+D4JmzuA8ic=; b=AXz4JBAxKmHevyd/KyHmEuOy1UWbB7JGKu5lJVTyUDW5awry4LZkZY4WZRqVcbejQ2U3gBpF1muBPpONywF1SNu9f01/gxgEKxeopFlJC351q1EUMkDEf3WEHl+N1hv4tJfZejzOfDnNUcoSvgSVFR9YEz0mQGdg6+P1pBcQ/kc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CO2PR07MB2517.namprd07.prod.outlook.com (10.166.200.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Mon, 18 Dec 2017 06:30:47 +0000 Date: Mon, 18 Dec 2017 12:00:17 +0530 From: Jerin Jacob To: "Eads, Gage" Cc: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" , "hemant.agrawal@nxp.com" , "Doherty, Declan" , "nidadavolu.murthy@cavium.com" , "nithin.dabilpuram@cavium.com" , "narayanaprasad.athreya@cavium.com" Message-ID: <20171218063012.GA12857@jerin> References: <1510210453-61428-1-git-send-email-abhinandan.gujjar@intel.com> <20171129114153.GA16467@jerin> <9184057F7FC11744A2107296B6B8EB1E2BB1B296@FMSMSX108.amr.corp.intel.com> <20171214024910.GA10018@jerin> <9184057F7FC11744A2107296B6B8EB1E2BB1B9FF@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E2BB1B9FF@FMSMSX108.amr.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0113.INDPRD01.PROD.OUTLOOK.COM (10.174.56.157) To CO2PR07MB2517.namprd07.prod.outlook.com (10.166.200.151) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 194341cb-53e5-442a-8c84-08d545e0e3fe X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:CO2PR07MB2517; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517; 3:YeNIL/b7wNLCTBMianCsAR5KWO4w+d+VnKQwOQwDWktkqGqkSf8GlCGZtZWTy6El3FMhfpKky65Mg/U2P+J5iwq6GfAtPmfHBX0j3XfTqAwNVCpQpOpOSvyip72wefP303iwmnmgyF/O7QzmaAzBii+DlJ925j44wLRj/I52nHTypP7ob+o4Uhg+y8R29e2IuXm3gIMqohG4uRahbt5hjLj5+k4fUE5iu2BC856oXAU6k8MLbHKxJUDQVEeXdVHz; 25:74ExoGQV7uPNAOZO6+PDAKFOHiyKiE4fnBqMv61nL3ui5xPbV5iNYMJrMZkvlalzeulNx0+KIxP1/ACz3dNxSSMb32oGWCBmFYcJH5bNjjUbX5r5OMifLp/bWa9hIyd6ViYiwtgoHvgBCGG5dQe2ImgIc+welYxsrYj1Cj8zTbOmPYbipXXN9aS5U/ZwGqo2dh5P65HO7CILiT0I4hM6S61rH+b2P1yHS3JwY7Ud9SBTiAMFFZNFeq8ISjhbop+vx8LTHnj0ke2Ao6tjZoJmbXGB24XnSK8CiSiPveaFgcvE735bFlufbs1shB9x7jGw8GXXq5506OyQD13WP+52/A==; 31:bGIeL7EMEPSAwsrDwcg0pJHBQ+wkz2nWw2QipmB5S+SlnZ1xhB4kr56GTyImREA2QjOD0Yr85XEVxIdi7yRjWZFuz8yuSNIzzwNz/cFBl53OMtm9ecnZ9IvMkZmT45uqfokzG7dI5Vu36a+QLqiCQdYhXAMGHcNP2LWYDb8L9iaH2zQOxQBN/efsldd/zGCwgONHQn47p1PmlWDOHhnpP+cb6aum+ZeyaTjRD78QxAE= X-MS-TrafficTypeDiagnostic: CO2PR07MB2517: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517; 20:IfdxE/AZ4Y0T7zcQ3xuly92SCQKW0TEPglZv5C0oYw5iP/UfKGfdkPvKBtIFU6VfPYLz5mVy8TYtAexmMwnN9tKG0HQNLIU1Ql1OaatVPmQz1yYCa+Or2kH5KDn9lNJKoO4UI60Am6z2/OtVFafGbmaZ7plCvbJGcExYk7dbh9zMGuTa/TMsmeOGOgQMBReIhtmsZb1w0voV4Y4jBtVMMrFjvudl7xrmkb2Nfiwehq4j+li11jYBTzhJAX6uJ2jjz8krFjZd84VFOCxXA6kWlECGBTF6AtstiRkU0xqBG7UnDv4fBeRDMt+/1OkAXysRIdHDt+qVTqD7hcs4H0V+iHtYBTCgodXvZOGdrRMQ4L4cGosftKusRohCBJ/JWAvIT/aL0AnMSzIUixKtttYHCdgRXTtMHSfade1E3E3DhCLVk0LPgHs3Iqwo8tVJnf0pPHXx2aoFjNKjcjQ4WFCEVUomATQAXluT5lyj0djn1yqU0tna0DRvmt++M+r6s9G8xFbm95EB0fjstumErH0YcsrF2AcMM1xVV9zw3+sUP5T/tpl0cfbtgntmaWP6RKFSxjOKQKSEYuQVibJNV7LuYO3QJQfB6TT8xEJ2Zw/0BiY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(3231023)(10201501046)(93006095)(6041248)(20161123558100)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011); SRVR:CO2PR07MB2517; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO2PR07MB2517; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517; 4:EIjMaIgRrh3f21wu3hnHvt+YvMv//ZXs/8UbUtaG9BXAvtUnM8ZOxWFlueFxzNpszFedq6CuUUyoIA9kRfUnfSN2DlUrxWzLocmA6nHMY8z49EjvjD0FncyV645izxiP+UkBww6Si3pGKONS5CisV64zVMCCWXVFQC8eiFq22tYL948v80tspGJvbwI8jzaS3czy7yVJteYwUJhPmrqFw3bbwbh/MvEevYrM5Mugjvegx9gLtOeh12PktRZctm7HN4gf0EN/NF8pQVn2F2KFfYHWVSW7hUU+1Y3wZa+pFWY7E/LKgfWtI8wu3TN5qGLvQioUaowDt7xqbB30VxBhIR2LrW6zNil2IM3B36VvAss= X-Forefront-PRVS: 0525BB0ADF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39850400004)(13464003)(199004)(189003)(33716001)(33656002)(8656006)(97736004)(105586002)(4326008)(107886003)(9686003)(106356001)(68736007)(386003)(66066001)(6306002)(7736002)(16586007)(53546011)(58126008)(53936002)(54906003)(53376002)(50466002)(59450400001)(478600001)(72206003)(42882006)(47776003)(5660300001)(6666003)(1076002)(6246003)(55016002)(229853002)(16526018)(81156014)(6916009)(6116002)(316002)(5009440100003)(76176011)(81166006)(33896004)(8676002)(305945005)(8936002)(3846002)(2950100002)(83506002)(52116002)(2906002)(93886005)(6496006)(23726003)(25786009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2517; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2517; 23:G5WMardmnprF/SVkJAwNVsDD/AI5w9TSeCfsxpsFJ?= =?us-ascii?Q?nwQqUO3vmwWZZoGC4vfE7STzAgjVNZNo0OyzW7JChxgAdkpRRlQMWEBvBL7N?= =?us-ascii?Q?Y26SOFr+qQQZ+FaaCoAkjN/RuQQ52Lsi69Jfk6KqLaRtgsXxreUQSF2JP5uQ?= =?us-ascii?Q?8Al7ZOdkvrJRVSX+4ORD1Q7q0hgc+Q/cjdMrx2fed0DzzaqJh1OnRX25ilKM?= =?us-ascii?Q?gcxn7eg6Ef/HwCfNCBqAG738kkWVXOFxSYbpx+xXuxCb1ohwWQyewZDip189?= =?us-ascii?Q?KNteIygOI7fd3HpR9vcAX6fRXWWQc3tI78QWOtJtbojPGW6hfuslxLgYLGtr?= =?us-ascii?Q?NAvbBP4SqC9y0Rfn62ztMDVg2Kbyc5hnT7fe4/KznI2WLSqqUnKU9tQ71uRY?= =?us-ascii?Q?Uq6e5rg4JagVF85TzctAezr6FsDJsF2JyvD2CvuLk6AR2vgshihrw7q7hLCM?= =?us-ascii?Q?NiLOCfWQzvssJgewOYNKLb+t+COH8URTkty1GOkvkFaWul5EgIx+Ztnwg4Bp?= =?us-ascii?Q?d0N5v70ktpS5ywXI2hMm9v8Ie+pOhT2qquNK9oKT6FluSr/c5eqd+YbUNnVC?= =?us-ascii?Q?4s0v2rKyrY2Y/S4WBF6UkUL+RpMe9oaQGDyxNpaztmKhGq54s/eMjB57dF7g?= =?us-ascii?Q?B7adsW+RU74GEmpv5MXaDWwsypVfRRiRJr18HsI+cxZeLic1oR+XEVvxr9Bq?= =?us-ascii?Q?eA5RQoqB9d+n5KJOM/Y1DI0WnYPhouPj2oLCo2P9GoYO921HH+Bs/aP5z+GO?= =?us-ascii?Q?fQ1aHnIq4jhk1PVGnuuW78jF1G9hANg0fZPe3CatzyFyvj1tleb1n7jAf8XD?= =?us-ascii?Q?IA8Q3q8fctnyyKrlF9g/9D9ZZgK9Jd5CYyocVWiCcsiGGrDVKoanEVYpqIoq?= =?us-ascii?Q?cOA4dfHnETZKaaDiHDwTV+xGDeM/7HObUqcfnxWQWUEAJSonc2nTAzi0aOkL?= =?us-ascii?Q?k8k7jtSF/biSwCUSPeHiY7Btc6H7uX4Irkf83Bsqi5yaCwDICqhe45gdj5nL?= =?us-ascii?Q?oJtjByQXP8st6na4ZRWS8yXgCIs40Moc8Lrk5uUzWi350omS0O049TtMLK2t?= =?us-ascii?Q?Js6I2r/oGrhHwHmUet301EtMuuDT3ZVoNqHgIHa4v3+E0AezeXc+n707eD0p?= =?us-ascii?Q?+rYCWH/vpILRL6jy+L0iaXGBY6ufb4eTHFXHjURK0kRGuovQ8po5aIJ56Ud8?= =?us-ascii?Q?3VyEDcEkYQEHWphoovyGqXD5RMJQ7dO93wywa5avG/5mp7Ftn0t8WAlSlmrg?= =?us-ascii?Q?qpr9P6dEzmfMZaidjCup+mn0xRrLRMyRForjUadad6jNMcJevj5BUDWYvqjj?= =?us-ascii?Q?wSqkcQgFxQPYjfKCmVLHBXsDD2eca3NiZ+i7NuhLVwYb/XKRDpgxLVCnvrsr?= =?us-ascii?Q?fGbJ6ZPvSG/nfmEKQR+v7K1EvzEcblQkc6DSjAZdBaNYgMzn9Z0kf+Wy/QW5?= =?us-ascii?Q?uk6iZFwTQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517; 6:1svR/Tbv2xwiKkDM2GSg7Q2l1EFSjcDGJkm1J5TmIGarw4qne8rQ0BWfrCM2nvu05S+89xtmPbqCD/h0uzXP25STLan6lCTE2UMIZKxiJ+trcMS9m010CCnhjZz9HUVN3sPpw2tf2ecQHoW0IpjNqQfutobNqvXReT5kDPN4ergMKqm9zwW9ZgDSWLv0PwuL+0I5u6W6MqfQ7ae9GCKOLhx07FGiizN1cev+TJ1m2EyMv5SXode7y9+oFYVbDIry66u9bkStktAIU27GQtZF1VcFiznWFUjTafp+WASrHpX7rwj/xh4JAqfmnWPcExuzn8xIxLgtElealAc4Bo2shCO58j79exgmqPNhWetgkec=; 5:/cVXdWElapBns0p1piUEgEegTF3vNOhpCeL1tDPdzaNLr0UV2EZhH25MOc1hpYbEypiv2rlxHKlzMkuAonCDcwQ+ZVmpjfkse4ECIcjklmF+Lu9LxXthEEklPzj9AGOnl00QtLly/pa7eaBSlQ7rSCXCg5POuuJPq3Oz8mRmv5k=; 24:tgV1Paqrt9jGyJyJJsA+nsx2QAUdn4N3xdnhNpWYA/PZP/z9sTFam4NA+UNFv9ujF+nmKeGGW51J4KCzyAoRLy0q3ZW2z1Tab1VNFHh4zvo=; 7:1jINM1lfOjqxtssUdkqUdaXWvyLZdjxZvOwTwLD+R2D9D04OTkLQoRfpXGWFvdmGOtHZhJ5EkN0Ktnc+eQiHMdS5KsaECyVxdhXm8iw4HCyQtM6sXT5bB8VGPQFwpo4p4Llgp3jeKeiiolCxZc+UFpcblyEfQWUZuUsyLK5sy/NCLF8aDg38S0JJ0pMANqREzbcuxTIL1VH/lxtelmHDdyd2V9I5TDfrQ6RVkOiVlh2q7HcVb4fge68umY+Ntx9v SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2017 06:30:47.8831 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 194341cb-53e5-442a-8c84-08d545e0e3fe X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2517 Subject: Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 06:30:56 -0000 -----Original Message----- > Date: Thu, 14 Dec 2017 18:52:02 +0000 > From: "Eads, Gage" > To: Jerin Jacob > CC: "Gujjar, Abhinandan S" , "dev@dpdk.org" > , "Vangati, Narender" , "Rao, > Nikhil" , "hemant.agrawal@nxp.com" > , "Doherty, Declan" , > "nidadavolu.murthy@cavium.com" , > "nithin.dabilpuram@cavium.com" , > "narayanaprasad.athreya@cavium.com" > Subject: RE: [RFC] eventdev: add crypto adapter API header > > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, December 13, 2017 8:49 PM > > To: Eads, Gage > > Cc: Gujjar, Abhinandan S ; dev@dpdk.org; > > Vangati, Narender ; Rao, Nikhil > > ; hemant.agrawal@nxp.com; Doherty, Declan > > ; nidadavolu.murthy@cavium.com; > > nithin.dabilpuram@cavium.com; narayanaprasad.athreya@cavium.com > > Subject: Re: [RFC] eventdev: add crypto adapter API header > > > > -----Original Message----- > > > Date: Wed, 13 Dec 2017 23:35:48 +0000 > > > From: "Eads, Gage" > > > To: Jerin Jacob , "Gujjar, Abhinandan S" > > > > > > CC: "dev@dpdk.org" , "Vangati, Narender" > > > , "Rao, Nikhil" , > > > "hemant.agrawal@nxp.com" , "Doherty, Declan" > > > , "nidadavolu.murthy@cavium.com" > > > , "nithin.dabilpuram@cavium.com" > > > , "narayanaprasad.athreya@cavium.com" > > > > > > Subject: RE: [RFC] eventdev: add crypto adapter API header > > > > > > Hey Jerin, > > > > Hey Gage, > > > > > > > > > > > > > > > > + > > > > > + /** > > > > > + * @warning > > > > > + * @b EXPERIMENTAL: this enum may change without prior notice > > > > > + * > > > > > + * Crypto event adapter type > > > > > + */ > > > > > +enum rte_event_crypto_adapter_type { > > > > > + RTE_EVENT_CRYPTO_ADAPTER_RX_ONLY = 1, > > > > > + /**< Start only Rx part of crypto adapter. > > > > > + * Packets dequeued from cryptodev are new to eventdev and > > > > > + * events will be treated as RTE_EVENT_OP_NEW */ > > > > > + RTE_EVENT_CRYPTO_ADAPTER_RX_TX, > > > > > + /**< Start both Rx & Tx part of crypto adapter. > > > > > + * Packet's event context will be retained and > > > > > + * event will be treated as RTE_EVENT_OP_FORWARD */ }; > > > > > > > > How about leveraging ev.op based schematics as mentioned above? > > > > > > That could work, but perhaps the ev.op should be configured once up front, as > > I see it being a function of the application architecture. A couple possible > > designs, for example: > > > - Worker enqueues into cryptodev, adapter polls for response: the adapter > > port would always use OP_NEW here. > > > - Worker sends a crypto request event to the adapter, which gives the > > > request to the cryptodev and polls for response: the adapter port > > > would always use OP_FWD here. (This ties in with my implicit release > > > patch (http://dpdk.org/ml/archives/dev/2017-December/083535.html)) > > > - Etc. > > > > Yes. Semantically both approaches will work. I was trying to avoid extra > > clutter(enum rte_event_crypto_adapter_type) in adapter API. > > I don't see any problem in moving ev.op to adapter configuration time if it helps > > the SW driver. > > > > IMO, We can change RTE_EVENT_CRYPTO_ADAPTER_RX_ONLY and > > RTE_EVENT_CRYPTO_ADAPTER_RX_TX to more appropriate name, something > > like, > > RTE_EVENT_CRYPTO_ADAPTER_TYPE_OP_NEW/RTE_EVENT_CRYPTO_ADAPTE > > R_TYPE_OP_FWD > > or something like that. > > > > I agree that the two naming schemes are equivalent, but since this option would control the adapter's behavior (Rx only vs. Rx + Tx), (IMO) I think Abhinandan's original names do a better job of conveying what effect these two options have on the adapter, compared to the op type names. The only concern with Rx/Tx terminology was, It is mostly used in the ethdev domain. In crypto domain, typically, we use enqueue/dequeue. The only difference between two modes is if adapter enqueue the events with RTE_EVENT_OP_NEW vs RTE_EVENT_OP_FORWARD then (IMO) we can change something related to that name to avoid adding a new terminology. BTW, Based on the earlier discussion, if we need to add opaque eventdev metadata to cryptodev then it may change ABI.If so, I think, we need to announce ABI change notice for cryptodev and plan cryptodev adapter for v18.05.