From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0071.outbound.protection.outlook.com [104.47.41.71]) by dpdk.org (Postfix) with ESMTP id 1EE6E271 for ; Mon, 18 Dec 2017 09:58:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fDdCUHsK2tXASCuR4NzCxMGtSaxnNVAZtxyoe+YAFA0=; b=JLIB/KyKP7SZV7u7dk8FOJ81A2f5qBlRchYqb3awYAzWK54349GaCTDA4qH4sfYJGbrxdZihN636wOmY5eRUGu2+ihQb8b0cthdi3cWdrlqZH5k8/diHyAY31nzzghvLMq85ZpfwifXRz57axxNrSOi48XPd3kz8Mt9vsGndjo0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Mon, 18 Dec 2017 08:57:59 +0000 Date: Mon, 18 Dec 2017 14:27:28 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org Message-ID: <20171218085727.GB20578@jerin> References: <1499170968-23016-1-git-send-email-hemant.agrawal@nxp.com> <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1513333483-4372-3-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513333483-4372-3-git-send-email-hemant.agrawal@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MAXPR0101CA0051.INDPRD01.PROD.OUTLOOK.COM (10.174.63.13) To CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: afbf6b86-7404-48e3-fa57-08d545f571a0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 3:ogbzHdPG68wnmJOkKNsrGE/63pP9tKhuAPkxWXrYZurktvwr9r/OwIwDXPlX8ssEAyv8ZYuEtaHb2fJ4sBEx8mJFUiPtDCq1p1tnsamDbAuO6uDwn/gyxDOzGXofYjaZoGqm8Yrk0lgQLfgquuxNbkTvtgSuxr9fR8P5QGj7LxP/NIpM9nFSRCoch5Op8QIvAIYg9FtGCTbA5PZ9Umqu+MT5N6OlhzTmQtWysSe1VUZoCf8Eji/R2WfmouXe4qje; 25:6a+HTDLhSepYEg9vO/gs9JuClXPjyYpFuvMyGTslCPqsJfa94j8z8rjiaMPQ8n1EDWr9tDbF3QtdZf0II5sJBKN1L1uzq6b4IV5ixiKJCUlgty6DZCv4WCNE956n+KjEHHH4KpZwG5SJNAsN/PrpyXMz44dbjCOb01lsbo2joZ3YezlojHNCtsjFZgo9J5Pcwvcq4BQkSyOB+inb0Dyrrejgcu83NtmG1RKpqacfQiCJezHuwEx5O5ND6L/g+kkuw3mg/0whhL/4MSLpI5+6PM5mFv6RyvDleNtBUitpm34wH2mX+iY3eLNLjfWoR5rGI4lt1yaEkd5BjK9Fhyr2Xg==; 31:Hbl34HWxsVE1E1pXjUeZGWTrDAF4/lCiack6LO0Czo1ycuY2q09y/+XSE3NRLEiGLUVDagawldKVjcjfsF+7/mnP/luZ7cg4a9p4X+2k5jepxigM4Kv7w+Kx/1XHLYDWwkS8TVKdm/mR1d8uK+gq4kp4TcffMdDi3FxBvStMtoMIMtaM21d20qwCA6MwvDxh0u0YOz9tMFUJTEMjjKKYjFxI6x7pFZywb9+gbnNsdc4= X-MS-TrafficTypeDiagnostic: CO2PR07MB2519: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 20:eYMFwTnkhSE4h+LoU6rB35Oa9dOj5j1swbJ//O9MHWpMKfzarkSleBwspTVTzcT2FbKQPjLIlvDyF5Jfd4uyTRFfQbS1ddwuX5QsvdUBPD/1whmD8x5gXWSrdW1E7HkiuXwbncGmm62MPyUftJBztJtMTf8PFOLTiaP0Ra1yUgmcbNObxJ3LHwCHiNitS9y4RDs3HlBSfDvYzqbh81R5RaRQTeI1bO4EY8i3W8TXZbdNKrbehtuV3+fEkowULkGMUXEqJwPBOHAk1JYw7O+nHkPatfz19G7UWMc8AY/6ZbD+uz+wQe+is3bydB8WTk6/4X9bA6VO+e6vyrtlZbcrFBThYqyr5edU/W6FnO3Xzt/WcJImbBvPjqT9o9fpOSVN0P+UaAbYaSZtVx40QHzlP+LGoBhemXq7/Dlh1GTIhD6X8L8URemc7LQqzJMB+dGV//o2KWWbUG+W5xgEou10CMtR5bbbomwTupvD0ErMhBMQ+zaAevGYzxPk33fjzllnCvKLInKRqbHPpR0pKG4Y5Ye2r8VuUXu2IWcn6PVJH6hurRV8dZfLDegWDtxUP5lyK/4cxm3yEeeV8oCfBdIVme506yGkgMNj3zuqyp14Yps= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(3231023)(3002001)(10201501046)(6041248)(20161123555025)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011); SRVR:CO2PR07MB2519; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 4:t655mbbwPaMKoURRWbOSscGlFn7FrF+otLWMZQP/yW2luwo/qcyxbpRKG7F9xS+NcAUTKh+qWIdYjBwAY6ccjq6aFKowa6pzDAyPs2FMqT+BxeMrU145kyT1RrzPz739dm3navXaywPHigYqPe2ssPTl1jII3BkeSz01SHeO2sudGir1x0KZ/wWS5cOiqXjfzHLh0dK1GfVbf/InSBixqKcdZiljbFcG5vfwNWBFovObqf6xp1nArC98ge8m3EXeVWUFBNy2A6tF8qJXPt0g3H7QMrR9jMqM0KnZsDliMKU0a9lsnl93lPpIOkrhpBZAo8rLF/YdltD6dzcNLLWwwQDe8KA8BDoUpChj0bUbe6A= X-Forefront-PRVS: 0525BB0ADF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(39850400004)(346002)(13464003)(199004)(189003)(8676002)(7736002)(5009440100003)(33656002)(6496006)(33716001)(305945005)(33896004)(59450400001)(50466002)(105586002)(25786009)(6116002)(97736004)(386003)(76176011)(3846002)(68736007)(5660300001)(2950100002)(106356001)(52116002)(47776003)(81166006)(6916009)(81156014)(23726003)(42882006)(6666003)(1076002)(229853002)(316002)(55016002)(478600001)(83506002)(58126008)(72206003)(4326008)(2906002)(9686003)(8936002)(8656006)(16526018)(16586007)(6246003)(66066001)(53936002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2519; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2519; 23:p6IJp1/0eKQtb3cLQS7r9YY2Mo6JY0se+i/LqdXmn?= =?us-ascii?Q?P18hdszdVo//VlAKGIyMEwrQFT/SBZ73JFb04J91CwVOR1EP+q36u0Fznho/?= =?us-ascii?Q?ePlfrFaWvUjYWk/d/rA4Na6DwHRFmPMMOXmWp/FIBABxV4/d5tpo2g7WLcZb?= =?us-ascii?Q?oCdrzZpogEgWGDvZgGxacTUsxeWw646vJgF2ck2dgg/loJtwNi/caW+z3Imq?= =?us-ascii?Q?bfI1ylBZZybJFkNqtNQDqSuAg+r50UlnqmVZxfH6FBKRkINRqaZDauYMoYss?= =?us-ascii?Q?Nvj14p+lJY5NwDS2zM9x71lA8uTtrAIULa2oixpjgJPM7S48Y1aspPXr8IBf?= =?us-ascii?Q?GK1BcA+XTc/5hYvsFygaS2QqGKAuJFlEBAOF77x0zQsh+MtWwewBcomE0M2h?= =?us-ascii?Q?wxbINbDMiv9n+asAGLSprNEqVt/fcMeetCySP1MztmC2iXZsYvs7O9vkxeu5?= =?us-ascii?Q?/rGRyEFxsFik/FUqmi83sYXeKiE1RC2HUvFlCxeM5ToRzqcgnVdYCup2Zxtg?= =?us-ascii?Q?be+wrNro4+5FxsnXUA+9i8xt71edqA9YzhrQOXPhhB7AhJxkeJqILhYaieRk?= =?us-ascii?Q?ZI5QW5l4WVvu8n6tWfn5njP0DeoIhVQAKmQtQEPw60+wLAWEhVqL9cmVXWDh?= =?us-ascii?Q?j7faYqlvO8+v4czL16kR52+vM2ROFe5gaN3vjTwstM1B5MfH3THKwwYkY6Z4?= =?us-ascii?Q?J7iuepdolMxffh3WxuN7bayLxHkcPsxiC2YqTZ4LVLR2QY/ic0lylyyYNGjK?= =?us-ascii?Q?xnq5hs7OQYjeqK5HJVjfSmSQDNHIakoMOF7DL6hp8jPpewOa9fwNT/ggAud/?= =?us-ascii?Q?H6SbvbOD+/ngmZrvU1T0Lm3L7BV8oIny/ZDsj0wn6xrK5FW2teOY7tXO6Wao?= =?us-ascii?Q?QCwAma25aFwR3M97jwXgeShqe0GzZcaI+lDSfBYMoQ+dLfIBqniYJgOuZIXO?= =?us-ascii?Q?TM6GJHUTsaYXpMWv7d9EiOt77FoAMcwbq1+Gv2e6RS3wktXNU+FM9OVkDIOU?= =?us-ascii?Q?FAWO221Ktafq40VMmkbuidVhmC0ErC7WCoLQ0YNonIM2Pd4DRpAsFBjeImbp?= =?us-ascii?Q?SQBUxt7RHo0jfbbt5o4wO65+Jb6lWS787eSMylAdCAFNXuXolaJ1W4B4VU+A?= =?us-ascii?Q?htkqkr3EzalCfVH5L3jmfYRBMqLi1x+2et/H7SJwd5rBb4b75rG6TnrpCW/L?= =?us-ascii?Q?MzpD0FBUEGo32qr6uwMyB3mWBwxyiF0A9f0aakopeC2QGiLmXIM5BXH1scsZ?= =?us-ascii?Q?QE1xHmhuTB/B+VsP7k+hOfRfvN2urRLhy/TrChkhSlk9AHGbtgnzC8ypRptp?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 6:7gK3L11C8e80b+mXjZjk1NFKDZUBSJ3z9yQPlLtgq5d1/LCywr0nZ4TcOohEJrNWvGIOfI0kTm1qTT+lLFJXboGuhtl/Voac4/Zd7DwCePC7jEJvHnJnzqs5gBDX5HVcpHyGq/3+eLhGOmoPiCiWYRqGmDBecGJnznOBgQzeV89QLTDcOzSPDcOoPH9I1ZAn/fM9gJtlJ/uIJCK40TeRpI26nyc18HfUP2m9bzcg0dmd7KxLR9u5m0HcjJZoHyl1WkQbpJkgoZ9770sagFj8bw09cHrX4/1Ltj7/rTPVi5zJg2Tio2ARd9Pwu+DLWYutEEF462XTlfKwBtH3AzvE7bL1Z1Rf89ltDWOqvxnKj9U=; 5:1WrgC8XpnPv0sGWGXVvFDCy6MWdX+gNzK/Ieq6N7vZBomzB4BNhHSnYo8f2RfauNdmldNfO1bcezSuYMc2qcZOmuglrZqJEcwzBBqa0MUvhprU2Oua/lzLsGigggaWLWWFVDxrLsOKKDXxem7EUnY//kP4owPyuU7RWQfLPwuq0=; 24:1sEFxFoxLlGo1gSQPN8XLdYIhS7vy8yz2G5oNV+4PmrvNQSSFqZOSQM0HmhkkyABInu/1TlksP9lmmt1jGdmRSwOdR1XxsrveJO2wUQD4ZA=; 7:S+b6lRbtXk0+zZ6wsT0G2c0GOk+Z3Rn+U69rybx9hljl0IOHg3GaFgzo0WxBcAsjigjx+nI4NGZ2ygjxdg/2RIdjUhjNPCwRYmVNcYB9gN+FCbCbwd+DpHLLHMFvB8yQs1k9dNeU9Htk4GCVvohbshkUsUH+Ya6B6cUwpIu8QZThnIhgYCd6tD0sOXMnDdUbyw8a7Pi3ZlczL5O5E+OwRsuOwK/db3MNU3q5tuUop6m16RsNCwzX2AFzrQo6t09y SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2017 08:57:59.9566 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afbf6b86-7404-48e3-fa57-08d545f571a0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2519 Subject: Re: [dpdk-dev] [PATCH 2/2] dpaa2: register dpaa2 mempool ops as active mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 08:58:04 -0000 -----Original Message----- > Date: Fri, 15 Dec 2017 15:54:43 +0530 > From: Hemant Agrawal > To: olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com > CC: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] dpaa2: register dpaa2 mempool ops as active > mempool > X-Mailer: git-send-email 2.7.4 > > Detect if the DPAA2 mempool objects are present and they can > serve as default mempool. > > Signed-off-by: Hemant Agrawal > --- > config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 - > drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 6 ++++++ > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 ++ > drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 2 +- > 4 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc > index 91f4993..703e8b3 100644 > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > @@ -53,7 +53,6 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=n > # Compile Support Libraries for DPAA2 > # > CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y > -CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="dpaa2" > CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n > > # > diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > index 334e1f5..5a6f292 100644 > --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > @@ -64,6 +64,7 @@ dpaa2_create_dpbp_device(int vdev_fd __rte_unused, > { > struct dpaa2_dpbp_dev *dpbp_node; > int ret; > + static int active_pool; > > /* Allocate DPAA2 dpbp handle */ > dpbp_node = rte_malloc(NULL, sizeof(struct dpaa2_dpbp_dev), 0); > @@ -100,6 +101,11 @@ dpaa2_create_dpbp_device(int vdev_fd __rte_unused, > > RTE_LOG(DEBUG, PMD, "DPAA2: Added [dpbp.%d]\n", dpbp_id); > > + if (!active_pool) { I think, this global variable can be avoided. Why it needs to be under active_pool?