Re: [dpdk-dev] [PATCH v4 2/3] examples/ipsec-secgw: add target queues in flow actions

["Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>]

Hi Anoob,

On Mon, Dec 18, 2017 at 01:53:50PM +0530, Anoob Joseph wrote:
> Hi Nelio,
> 
> 
> On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote:
> > Mellanox INNOVA NIC needs to have final target queue actions to perform
> > inline crypto.
> > 
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > 
> > ---
> > 
> > Changes in v4:
> > 
> >   * remove Egress code.
> > 
> > Changes in v3:
> > 
> >   * removed PASSTHRU test for ingress.
> >   * removed check on configured queues for the queue action.
> > 
> > Changes in v2:
> > 
> >   * Test the rule by PASSTHRU/RSS/QUEUE and apply the first one validated.
> > ---
> >   examples/ipsec-secgw/ipsec.c | 53 ++++++++++++++++++++++++++++++++++++++++++--
> >   examples/ipsec-secgw/ipsec.h |  2 +-
> >   2 files changed, 52 insertions(+), 3 deletions(-)
> > 
> > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
> > index 17bd7620d..8e8dc6df7 100644
> > --- a/examples/ipsec-secgw/ipsec.c
> > +++ b/examples/ipsec-secgw/ipsec.c
> > @@ -142,6 +142,7 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
> >   							rte_eth_dev_get_sec_ctx(
> >   							sa->portid);
> >   			const struct rte_security_capability *sec_cap;
> > +			int ret = 0;
> >   			sa->sec_session = rte_security_session_create(ctx,
> >   					&sess_conf, ipsec_ctx->session_pool);
> > @@ -201,15 +202,63 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
> >   			sa->action[0].type = RTE_FLOW_ACTION_TYPE_SECURITY;
> >   			sa->action[0].conf = sa->sec_session;
> > -			sa->action[1].type = RTE_FLOW_ACTION_TYPE_END;
> This is reverted in the second patch, right? Are you planning to revise the
> patch fixing this? I'm fine with the changes, otherwise.
<snip>

Yes I will send a v5 fixing this point.

Thanks,

-- 
Nélio Laranjeiro
6WIND