From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 06095271 for ; Mon, 18 Dec 2017 10:57:13 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id p69so4642469wrb.8 for ; Mon, 18 Dec 2017 01:57:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HM4eB7+0/l4LZ/70YaEBhLwwv/Xo686a8AroOrbTqSg=; b=OwVqPJsrsTxfw2/xIy5uT/H2cIksnRdsDOhiTxHE4y6cJYhoiAmY20OG2GYtcN9VI7 7N/aHThkelOJsdUbS1L7l6F22Bd/teCZoBzda9TAko3X7vvtMOMRKz4PYmZf9B7Uy/Aj N2TLClhLF4PnYdOA6kSenfqjSn1qyVrb92ptTQ+E9vAC5FbJ+5HlKL1nUKBmZXwaUYNA OlpIgSwDRQwem2pM0njqhCC189xmqn22F9cndaYjjak150zL5UhEzHyHqXK7qs2ngfrc Ma24I4kAZix3I/qI8umnHUr/lSz86cYb80ieTPUIRPGiP4INrCipo/S4E7QPpyku8F9T 5+Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HM4eB7+0/l4LZ/70YaEBhLwwv/Xo686a8AroOrbTqSg=; b=jaN1jtFm+ijBDt7wYap8rLkSSQumIA+3i7HeS3/KxqteubLrqt00GZgcII/f6PbnqK ylHiVJEQj0e27zow086Rk/V+H/3cCN6EPbfQHkMjCp8cq0vkF6up+KicAtbG58qHg0tA G30JXh5faZgp52NmQRertfhAlrrhraAjzckNven2bKucw3e890bNShMeuuMBz2sK2SQu EfFRFWwSJ7OVo5kixACnO+b8ZKkSt4c9WN/8TRpE6mBfiZBA0qcGOwmZKIFQELa8Y681 FXTNg+o67cpeXMcgMjGOUJTzdsXr5pZDNVX7CtSkcy4MI0f5hU8lZ5LKDEkJ4b30f9GF 4uDg== X-Gm-Message-State: AKGB3mIAqwOOrUlyhS1e8tgyKJxqYO8fIe9KHCioRd9+DYlLJ4c92rRr zDG71C3bUDiltVRYxlUzBksr X-Google-Smtp-Source: ACJfBounDhkF/rOz31kHT4nS6CLHtmnTUzejIHCHqLxk0+XsW7zvnd2zrjeLKXgVlLlZPydHPZzw/g== X-Received: by 10.223.138.195 with SMTP id z3mr3807539wrz.152.1513591033617; Mon, 18 Dec 2017 01:57:13 -0800 (PST) Received: from shalom (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y42sm147260wrc.96.2017.12.18.01.57.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:57:12 -0800 (PST) Date: Mon, 18 Dec 2017 10:57:51 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Anoob Joseph Cc: Sergio Gonzalez Monroy , Radu Nicolau , dev@dpdk.org Message-ID: <20171218095751.jwnlk443qb6jyiws@shalom> References: <5d3fdd0c05d5f8afd3f8e38ca03eaf25187d5c98.1513000931.git.nelio.laranjeiro@6wind.com> <8467f1cab647d72d9e52fe03faffd408761e66d9.1513264386.git.nelio.laranjeiro@6wind.com> <0f1dcd1e-6c15-fb6e-e4b6-fb7a0383cd54@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f1dcd1e-6c15-fb6e-e4b6-fb7a0383cd54@caviumnetworks.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 2/3] examples/ipsec-secgw: add target queues in flow actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 09:57:15 -0000 Hi Anoob, On Mon, Dec 18, 2017 at 01:53:50PM +0530, Anoob Joseph wrote: > Hi Nelio, > > > On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: > > Mellanox INNOVA NIC needs to have final target queue actions to perform > > inline crypto. > > > > Signed-off-by: Nelio Laranjeiro > > > > --- > > > > Changes in v4: > > > > * remove Egress code. > > > > Changes in v3: > > > > * removed PASSTHRU test for ingress. > > * removed check on configured queues for the queue action. > > > > Changes in v2: > > > > * Test the rule by PASSTHRU/RSS/QUEUE and apply the first one validated. > > --- > > examples/ipsec-secgw/ipsec.c | 53 ++++++++++++++++++++++++++++++++++++++++++-- > > examples/ipsec-secgw/ipsec.h | 2 +- > > 2 files changed, 52 insertions(+), 3 deletions(-) > > > > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c > > index 17bd7620d..8e8dc6df7 100644 > > --- a/examples/ipsec-secgw/ipsec.c > > +++ b/examples/ipsec-secgw/ipsec.c > > @@ -142,6 +142,7 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa) > > rte_eth_dev_get_sec_ctx( > > sa->portid); > > const struct rte_security_capability *sec_cap; > > + int ret = 0; > > sa->sec_session = rte_security_session_create(ctx, > > &sess_conf, ipsec_ctx->session_pool); > > @@ -201,15 +202,63 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa) > > sa->action[0].type = RTE_FLOW_ACTION_TYPE_SECURITY; > > sa->action[0].conf = sa->sec_session; > > - sa->action[1].type = RTE_FLOW_ACTION_TYPE_END; > This is reverted in the second patch, right? Are you planning to revise the > patch fixing this? I'm fine with the changes, otherwise. Yes I will send a v5 fixing this point. Thanks, -- Nélio Laranjeiro 6WIND