From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 67A7E271 for ; Mon, 18 Dec 2017 22:17:55 +0100 (CET) Received: by mail-pl0-f66.google.com with SMTP id s3so5589552plp.4 for ; Mon, 18 Dec 2017 13:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xUdNl73ycLXiYzSrwPkLiWySoqIh9O7Rj50yCWI9RHA=; b=udLv+hqY1ieJE8VOr/5zQYyENsX+e0KFYinExy48cTPVtrDyHfEIM23fNNyiviVUYE QDS6ZqAxRwVd7E2uqjCvK1iilmPP+hbbm37XsYM7aUew9oWuRg7J6c9hrvj0TTlAJv5j LfcyrgtTdxKOCydhWHFu69F+dHM+bFt6vQZgv/JH9ubZ5TmXxiXuIBDMPwRyQVBRPUq3 KB8wPXumbCQ94ee2HGoy41q4i471pbIlb1DrgV4MdY/54dxMTG44+vzmbUx7e7LCMG8h 5XmEDfFMURox+hY7kk6hUK/a8bZHHRoK6agRZTgZ2+sZIoIAsHzRaLL9eTSy20TGbr+5 jd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xUdNl73ycLXiYzSrwPkLiWySoqIh9O7Rj50yCWI9RHA=; b=eDxIwSsPqdnNV+SU94jSqyBOs1qtSDZ2Z9KBcMSwPXpYRSUF+KAjMtfqb7sWV/GLDW yUIYiQ7AXA1yXea620hOcaXLtqhoHEYTEEBT7XzVlYgXJw6TFvn0soMmDQS3/kMil4/k g/wtreNbnCexA851z1qw8NJjR/N+EJfFwJNmQL7XnnI+3Ax9Zxs1Mt0Z0k8NrZiWsub8 q3vpsXhQQuPK90TUIspWU2E0hYWqNKpDy7JQy9/BKu6lHGJaA0su9NQvyVNuNhBMxLgD oTLPNwHd+vJLGUePgZsGaorJcPegmtdkgmkDnXL4iO02H+ZNPk6qWW7A1ugpvGXqMOVp Xusg== X-Gm-Message-State: AKGB3mLqgsHAlAsIMceCAAQn2izBseak+p7MfUDMqtiLHaoX4ErfA+7S OYF1jRZECgO0W1XW9beVPekZDQ== X-Google-Smtp-Source: ACJfBoszRKWDX3YklYcS6OJO81J0whxAZRZJkA3MvckA2bMQDRxPyp9jNkp0QmuWI9Kyt4KNviqK3g== X-Received: by 10.159.234.138 with SMTP id d10mr996954plr.280.1513631874610; Mon, 18 Dec 2017 13:17:54 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id r11sm23854036pgf.79.2017.12.18.13.17.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 13:17:54 -0800 (PST) Date: Mon, 18 Dec 2017 13:17:51 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Adrien Mazarguil , dev@dpdk.org, Ferruh Yigit Message-ID: <20171218131751.5c5d9467@xeon-e3> In-Reply-To: <7420927.98Cnld71HS@xps> References: <20171124172132.GW4062@6wind.com> <20171218162443.12971-2-adrien.mazarguil@6wind.com> <20171218102835.7602545f@xeon-e3> <7420927.98Cnld71HS@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 21:17:55 -0000 On Mon, 18 Dec 2017 20:54:16 +0100 Thomas Monjalon wrote: > > > +#endif /* RTE_LIBRTE_HYPERV_DEBUG */ > > > + > > > +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__) > > > +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__) > > > +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__) > > > +#define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__) > > > + > > > > Please don't use DEBUG() etc macros. It makes it easier for tools that do > > global updates or scans if all drivers use the same model of PMD_DRV_LOG > > The new standard is to use dynamic logtype. Agree, please use dynamic logging, and also don't redefine new macros like DEBUG/INFO/WARN/ERROR. Instead use PMD_DRV_LOG or equivalent macros. The base rule here is that all drivers should look the same as much as reasonably possible. This makes reviewers of other subsystems more likely to see problems. It also allows for later changes where some developer does a global improvement across many PMD's. Drivers should not be snowflakes, each one is not unique.