From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0074.outbound.protection.outlook.com [104.47.40.74]) by dpdk.org (Postfix) with ESMTP id 9B3A723D for <dev@dpdk.org>; Mon, 18 Dec 2017 16:42:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iyYh0dUxC4B5pfzQbGVqseUJ6SMbEuvkYGNi5IBBCuo=; b=hE+1ikhYYNGBZYXy07CdftQs1vXc2sZVT7tDeWQL1wLI+BlDIM1CN9mmtKmTEpXR9zMChn1qVhFNDxQ6meFnTMAJnV/PUAWmQ2O7zkEq+U7+VF9xhHIpvOXFk35GRvtK2i3q+ys8SmMtVzQIwpXod+tdjbqvqyVjPTOPHNGY/b8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CY1PR07MB2524.namprd07.prod.outlook.com (10.167.16.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Mon, 18 Dec 2017 15:42:20 +0000 Date: Mon, 18 Dec 2017 21:11:50 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com> Message-ID: <20171218154149.GA18012@jerin> References: <1513598038-148115-1-git-send-email-harry.van.haaren@intel.com> <1513598038-148115-2-git-send-email-harry.van.haaren@intel.com> <20171218145918.GA14509@jerin> <E923DB57A917B54B9182A2E928D00FA650FE308A@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FE308A@IRSMSX102.ger.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0035.INDPRD01.PROD.OUTLOOK.COM (10.174.214.21) To CY1PR07MB2524.namprd07.prod.outlook.com (10.167.16.15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d15decb-cb75-4c5c-51df-08d5462dedba X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:CY1PR07MB2524; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 3:cNfa4aoOp5N5R9ih8TIn+EW37EMtYD6upPLro0OV5d5Y8t65bYCMGHqBqImaY72bSqMuEwdoVJA73LpVIydmPeuOk/WhDjGB9B9HwIcro/9CDWfVdaAnp4rjlYIZS75uhdpaETgiY5b1R+/qGTTUWTZ0YtLNeIgrF3Q2GSYLkeQlTVCN6KpZ8OCTwhJtDYC8i213jdVpIu7LPnomcdkS+JQEEEx/cBOM8ZpJkw5aMvkH91dvroqFfO6mU3s+1Vqd; 25:FjRLOD5IDEfrBKldy/PwK4N0QxMI6kxVNUWpDGCyrZBoyymDCsiPpzMjEMzFAXigICRZ+fW+6E0X0R2KK1cVK/XDJYvbaN8xp0ucFc1dJhGhwsTXKbvdkchokFVSseIZ9+uaTrAqVRdL7xDYgQ7/64PI0FWB2Q+7nmaknZsw3hAnXHldNkhXjRyWW/uXl+JY9SCk7KnBdpwaPaGLtTy/e75Mx1tDuWsPWGfdA2ZfvMDW5IN5n6tX9msGCXOJ6b6PXnTM8ZBnv0pGZTD1EOYa/vpPRG5nTpkH7QkVi3qQhewgsZ0FNgVwmb2sQIbZXd5LfZL04+NYoWipQGa3w87QrA==; 31:JvAuwkIAIP62u/x40oyVbyGvWxbbhEXiVFvIRe3pYzfkK4fbeQK8GhjQWNXBlBVE7R+Wl1AvfxUXWgSmti1aOwI9yyCWfb653WltB7m6Vm29f3is5aGwI5P6AjxYNmvjUo4p9i/+k2DOQIMeZpUdGnJ85kg+PVX4d2JiYdublc3g4pHcMkHmOa4LXFPyjJ3eFYP1w8uA0VRHSjbQAoMJaK5PdvVM9Kn+v5XgJ8HJ/E0= X-MS-TrafficTypeDiagnostic: CY1PR07MB2524: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 20:ngTFdl4oY5qnK90s0Q9gfNlkxuFCd/FbM+2U0x8Cn8f5UsdZfEa2oreXDvfxlE5DsJFsITl92P54pAdWSlanpRKalQH4qIzvSmtFyMK3gSdtGz6VyrfhvTwiRGlnna25JYhk4My76UOZTGkXMhUZLVFVkwzNE81cU+YoBQ+P0pPZ3gWR1LAt9hY2qD0br240e2rOLAY6zw5FfJge/CcsPjZ0SEUALBj8Q1e7GPfJv5DItLGfjrES7enHd4JANxRxq8IxT2SF9W3s0J6p4DdlLEildhPFPUXXR3Zil11iCQDokFFtpA8w+3rvQwXe7bpins3luQsu5TuBG7+XNqcA+zeb3OLCtBeZ2rRW2KgHvsp1mDtmM1f2NHA57QBGy4y6qgPLq3zazuQ7P0a80EN4fL7I5jpP9+dF40zbZq2BJNJy2ZpIttATIyyoY+FXswMYzwRG3vGS1uUk6/FcavoEdI1TlYYx8tPUacv9xSVOmKjJ9Fuxvjd5XOAER4pggHEwB36K6xgAk0YIOXxKlc+UCdFst2CL1+H6Y6j5U/qYY90vn4AVMKVDv116CPGHLPyATxfdiM6fxUysBQZMMxT80zpqfRE31rTVpInw4JhvxNs=; 4:Pa/FNuIjvbLR0sndCYTejsQk6M0HlnxjEp5oBwgDrcyHcza8wEXKSLZchKHZZYNIjP7ANln0b1nfAt6thKoeecL4RHDNHKR6gzTFa/JODdaZlLs5a8lNRTXsXsbNyUrjrXoMDPfUO/Wbn9qsX9PUweiqry1WWAevWSG3le9Z3WblnQXL3O+AJn8uMSnadvanJOrzEXhyo9KJc++Jt2ZBk4TutNjDbSbexBceMVMTFZx51q1Wg4wA5yS5qhwTJR1Yu0D1mWB2vScm7fLL/MgQNs3sdZIF4mq9wbcWqfX3Yp9gI1mZAPV+jxHPIZ2ga7d9 X-Microsoft-Antispam-PRVS: <CY1PR07MB2524B161DD6143CD0EA09729E30E0@CY1PR07MB2524.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(3231023)(10201501046)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011); SRVR:CY1PR07MB2524; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR07MB2524; X-Forefront-PRVS: 0525BB0ADF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(396003)(189003)(199004)(13464003)(316002)(8936002)(16586007)(5660300001)(58126008)(6666003)(33716001)(23726003)(229853002)(33656002)(9686003)(105586002)(66066001)(2906002)(52116002)(47776003)(55016002)(97736004)(72206003)(106356001)(478600001)(68736007)(42882006)(8676002)(33896004)(6916009)(76176011)(386003)(16526018)(54906003)(81166006)(50466002)(7736002)(83506002)(93886005)(1076002)(6496006)(81156014)(6116002)(25786009)(305945005)(3846002)(4326008)(53936002)(5009440100003)(2950100002)(53546011)(6246003)(118163002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2524; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2524; 23:XLlCi9XZtsugOlVLLpO8nR3OkPCgmK5uyOiS4tJKn?= =?us-ascii?Q?SqqHNKAurDWnlFf2VtjnX7PgZ3FldJSUJrdjO0l79TCvxTSCf9p1KnFtzp0Q?= =?us-ascii?Q?HSIPwjOb9BRIGZ94TFaBDAzVGxB1Y1nvVWfHQGNMTn8hpIvwrumG8NbDPzB1?= =?us-ascii?Q?HbjdjcxlgGjK4LqKflgn2cApM97VDLCYVb9BLoWnne1rRtKaIMUKIMIarAHE?= =?us-ascii?Q?Pwr4Q1DMNl5CQVO634pfqhXOy2CRy1amWbdSObjiBiXkedbC46yesgoNtp69?= =?us-ascii?Q?5+Jb9H4FdmSH3b7Lfn//2VERCximXjrdpzlChjkV0AEpv0crD/hupGLTsWID?= =?us-ascii?Q?H5vy8DqE9Jgl07nZn4AyjWOqF1a2h1ViSrIYMToJAjTA1IKiX6NHwgLGsosG?= =?us-ascii?Q?tw2yAu5a/K1dlYsqxpHslcugtAObpggHilRa8Ayzgo0Z5j4Er2cIly5VSOo3?= =?us-ascii?Q?c2xIe9LkHa6vKJ2iuxGPbqWxpfJ5omaPqRhiOH5tJyne+Xx0s49vdgZIiyu8?= =?us-ascii?Q?9wSLx1/2HLGMVdZwG+akMZc9L9GkmDPdKvg94KBdEYLZO7khSEbBCVXkXRY2?= =?us-ascii?Q?2i15ICept2uOCQ8f8tkRXvIXSC9FvZn7xxr41Iu+OZlLz/FIpym8fO6AbcOJ?= =?us-ascii?Q?djVeVdzQhj+hVhaLXDWa6El+usB8F2Nloutk5cI3K+bc3Axg/VyeFNIonQOZ?= =?us-ascii?Q?LEXWQZV06KDI5jd7VcYko1EZYub+rrCXX8BJxgyF7DGOB816ZolCTZxMK8s5?= =?us-ascii?Q?EvM1HwukaOLvzebvjGNUryOQPAZlBaFhik65B4QWLPTatt61JhZPAovF6Nd9?= =?us-ascii?Q?bqP9Xh7QxYBFyoX/lRyF6qY6PDOazCUYdX+VUb6nkaB2IHxjJfaHunY8Ybrk?= =?us-ascii?Q?ampw78UATeXwE8QFRTS7Rh4jhekfiXcDDzpmdI9wULJ/Grmv1Rw6hJQnPOvs?= =?us-ascii?Q?d1fV2f4NDSqSTASQc/8c2N3TdIpRDlhWpGygf5JRY3w139M0xeWkWTRepZPO?= =?us-ascii?Q?nAsy8jQ+Ao3XSTyCwo12CIZRS26Uc4oEzf1KBZg+J3b5zt52V3CIUeQ69IlO?= =?us-ascii?Q?VP9p4aOx8Yb2kzrmDa06V4G+M8LkOjyI4+xZavUaEjswXqUTvuwmeSdXhbkJ?= =?us-ascii?Q?64g7nGhKiFdlOyN/Jg9padg9vy65Yl4AQOh5Cq8oYL5nadKWjpGmWwcMtSyJ?= =?us-ascii?Q?oinyBxTHsVctYK1EKutBx7BJOIGo4lJs8uVtFNU7AK3aOE+2dRS1mY3tW7FY?= =?us-ascii?Q?J3RPv1/XIc/olld2DgxMlhntag0Kv4JMZWorY48IgO2z7q83HJa/lnNJpDBk?= =?us-ascii?Q?I/7c/gopOzJknhTg8t9lLtpEqeRlb0VXvj71B+StAjZ?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 6:NgKNLsWmdcFn6Ub4mnv3C8iXFGstoZmkEsG4zrvq9Ff6H1tjGxCC5kD3h4DjG2Ho/rjzFo0dcTc5JprO1epX380iJ8ldWBKF0LNilZhhm3JRmJ2J6WCW2cJfXWE8JFC9YsdutYUF+X4ezUhINT1FEG4TX268EnRXG0FiMdn84ytCC7o4sSnZYy3Yso3QpUQpZG9EolXNh1IQz07dAKltYYxVPuSMRGYZPWZYOHgUdVib6onBWvJz3h4zn3Z0eadtoSrUxeOJ+GnorpCQnKr0Edb6uCYqh0XucfJ5A9+NI05uWEKjqYI9jMrcjWSBIgcw4rptV697BwWneKT8LqiBRl+Oj5WPr+lqaHp7jJG0NAM=; 5:3N8LWnUFPSDQ7vQfRsi+yobivPOGCC8BbjTryEqYifhf7F70lf7bCC8sIQndj40PJMnGrs8+ZUU1ufTMxW6dvBkyNAxGoiuohsYXx828aawFM0I0G3g3PaneS9vw7m6tsNervlXH98Um4C2AZAvxwiIw9xqyf/QCmzNv6DgVLUw=; 24:uc/1nl+nYkFkrKk5h8tAMSKFSthAUkhms6Oxu5wcKuVvxXpKEHKVyAmWiwjET5BaZdTahP8WflV3kNczt2GEXWxa8OwNShiyP3larnTFl4k=; 7:AXjOnIw69EcDlGOiEaDSWgRpFj8xGAbH5/PNxJG04irydl7P/dvfD05U8sgvH5R9Js33j759+b+jzfbY3hmhMpoON6hJaf96DJi75wzxVUFz8l1H00Hgdn6sYV2QxrWce51AoTAmAJYvjbESMSTWVF3k9m/VPLWop3mzY/yG8BA322mPcoeUFyKq6LTthagZRyNPeMl1/CCmWXPTrCg62PjLtPoSMxxBn3wqHBR78pfzSzq2aEgHV54E5oQ4aVyf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2017 15:42:20.2270 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d15decb-cb75-4c5c-51df-08d5462dedba X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2524 Subject: Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 18 Dec 2017 15:42:24 -0000 -----Original Message----- > Date: Mon, 18 Dec 2017 15:24:22 +0000 > From: "Van Haaren, Harry" <harry.van.haaren@intel.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" > <bruce.richardson@intel.com> > Subject: RE: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if > set > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Monday, December 18, 2017 2:59 PM > > To: Van Haaren, Harry <harry.van.haaren@intel.com> > > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com> > > Subject: Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if > > set > > > > -----Original Message----- > > > Date: Mon, 18 Dec 2017 11:53:57 +0000 > > > From: Harry van Haaren <harry.van.haaren@intel.com> > > > To: dev@dpdk.org > > > CC: bruce.richardson@intel.com, Harry van Haaren > > > <harry.van.haaren@intel.com> > > > Subject: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set > > > X-Mailer: git-send-email 2.7.4 > > > > > > This commit paves the way for the meson tests in the next > > > patch. With this patch the test binary checks the DPDK_TEST > > > environment variable and if set, the contents of the var > > > are inserted on the test app command line, and run. > > > > > > This allows testing of various different unit tests without > > > manual interaction with the RTE>> test prompt, instead automating > > > it using the DPDK_TEST environment variable. > > > > Another alternative is to pipe the command. > > example: > > echo "eventdev_common_autotest" | sudo ./build/app/test > > > With the current implementation, meson handles which tests to run, and the command line. This gives us a clean interface from which to run tests. Note that the following command will run the tests requested: > > $ meson test ring_autotest ring_perf_autotest acl_autotest > > Meson itself supports two methods of launching tests from the same binary: argv and env variables. In this implementation, the DPDK_TEST env is set by the test runner - and the user doesn't have to use it manually at all, and it is not exported in the shell after the tests have run. > > In short - I don't see added value in reworking this to argc argv, or in using terminal tricks like echo "test" | sudo ./test. > > Actually, the current method has an easter egg included: > If a developer is focused on a single test-case (TDD anyone? :), then they could use the DPDK_TEST env var as a feature, $ export DPDK_TEST=ring_autotest and run that test automatically when the binary is launched. Yup. I don't see any harm in exposing DPDK_TEST means of test selection.