From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 219581B016 for ; Tue, 19 Dec 2017 11:02:03 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 02:01:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="13540761" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by orsmga003.jf.intel.com with SMTP; 19 Dec 2017 02:01:53 -0800 Received: by (sSMTP sendmail emulation); Tue, 19 Dec 2017 10:01:52 +0000 Date: Tue, 19 Dec 2017 10:01:51 +0000 From: Bruce Richardson To: Hemant Agrawal Cc: Thomas Monjalon , dev@dpdk.org, stephen@networkplumber.org Message-ID: <20171219100151.GB7384@bricha3-MOBL3.ger.corp.intel.com> References: <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com> <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com> <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com> <4147827.fBL4TnQB7r@xps> <53f0f426-2d0b-1cbb-2161-0d03ba0b76f9@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53f0f426-2d0b-1cbb-2161-0d03ba0b76f9@nxp.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 10:02:04 -0000 On Tue, Dec 19, 2017 at 10:59:26AM +0530, Hemant Agrawal wrote: > On 12/18/2017 10:00 PM, Thomas Monjalon wrote: > > 18/12/2017 16:52, Bruce Richardson: > > > On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: > > > > --- a/GNUmakefile > > > > +++ b/GNUmakefile > > > > @@ -1,33 +1,6 @@ > > > > -# BSD LICENSE > > > > +# SPDX-License-Identifier: BSD-3-Clause > > > > # > > > > # Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > > > > > > Actually, minor comment, can we remove the blank line between the SPDX > > > identifier and the copyright? Given that in the majority of cases, we > > > will only have one line each, having a space between them is a) probably > > > unnecessary, and b) looks weird IMHO. > > > > > > I'm currently working on a patchset to update the meson.build files, and > > > I think having: > > > > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2017 Intel Corporation > > > > > > looks better as a header than two one-line paragraphs. > > > > +1, I agree with Bruce > > > I will fix it. > However, I will suggest to not enforced it as a policy. Let the copyright > owners decide, how they want to place the copyright. Ok, I can live with that. I've started work on automatically replacing the license text for Intel copyright files. Those patch (when done) will use the 2-line, no-space version. :-)