From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 310011B168
for <dev@dpdk.org>; Tue, 19 Dec 2017 11:11:19 +0100 (CET)
Received: from core.dev.6wind.com (unknown [10.0.0.1])
by proxy.6wind.com (Postfix) with ESMTPS id 3E13511689B;
Tue, 19 Dec 2017 11:02:40 +0100 (CET)
Received: from [10.16.0.195] (helo=6wind.com)
by core.dev.6wind.com with smtp (Exim 4.84_2)
(envelope-from <olivier.matz@6wind.com>)
id 1eRErb-0005X6-K7; Tue, 19 Dec 2017 11:11:08 +0100
Received: by 6wind.com (sSMTP sendmail emulation);
Tue, 19 Dec 2017 11:11:07 +0100
Date: Tue, 19 Dec 2017 11:11:07 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: jingjing.wu@intel.com, dev@dpdk.org, andrey.chilikin@intel.com
Message-ID: <20171219101106.yg4s6jpruyvs3b3t@glumotte.dev.6wind.com>
References: <1511863976-126599-1-git-send-email-beilei.xing@intel.com>
<1511863976-126599-2-git-send-email-beilei.xing@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1511863976-126599-2-git-send-email-beilei.xing@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: support PPPoE and L2TP in software
packet type parser
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 10:11:19 -0000
Hi Beilei,
On Tue, Nov 28, 2017 at 06:12:55PM +0800, Beilei Xing wrote:
> Add support of PPPoE and L2TP in rte_net_get_ptype().
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++
> lib/librte_mbuf/rte_mbuf_ptype.h | 26 ++++++++++++++++++++++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c b/lib/librte_mbuf/rte_mbuf_ptype.c
> index a623226..e0f2a92 100644
> --- a/lib/librte_mbuf/rte_mbuf_ptype.c
> +++ b/lib/librte_mbuf/rte_mbuf_ptype.c
> @@ -47,6 +47,7 @@ const char *rte_get_ptype_l2_name(uint32_t ptype)
> case RTE_PTYPE_L2_ETHER_NSH: return "L2_ETHER_NSH";
> case RTE_PTYPE_L2_ETHER_VLAN: return "L2_ETHER_VLAN";
> case RTE_PTYPE_L2_ETHER_QINQ: return "L2_ETHER_QINQ";
> + case RTE_PTYPE_L2_ETHER_PPPOE: return "L2_ETHER_PPPOE";
> default: return "L2_UNKNOWN";
> }
> }
> @@ -92,6 +93,7 @@ const char *rte_get_ptype_tunnel_name(uint32_t ptype)
> case RTE_PTYPE_TUNNEL_GTPC: return "TUNNEL_GTPC";
> case RTE_PTYPE_TUNNEL_GTPU: return "TUNNEL_GTPU";
> case RTE_PTYPE_TUNNEL_ESP: return "TUNNEL_ESP";
> + case RTE_PTYPE_TUNNEL_L2TP: return "TUNNEL_L2TP";
> default: return "TUNNEL_UNKNOWN";
> }
> }
> diff --git a/lib/librte_mbuf/rte_mbuf_ptype.h b/lib/librte_mbuf/rte_mbuf_ptype.h
> index 5c62435..256f024 100644
> --- a/lib/librte_mbuf/rte_mbuf_ptype.h
> +++ b/lib/librte_mbuf/rte_mbuf_ptype.h
> @@ -153,6 +153,13 @@ extern "C" {
> */
> #define RTE_PTYPE_L2_ETHER_QINQ 0x00000007
> /**
> + * PPPOE packet type.
> + *
> + * Packet format:
> + * <'ether type'=[0x8863|0x8864]>
> + */
> +#define RTE_PTYPE_L2_ETHER_PPPOE 0x00000008
> +/**
> * Mask of layer 2 packet types.
> * It is used for outer packet for tunneling cases.
> */
> @@ -426,6 +433,25 @@ extern "C" {
> */
> #define RTE_PTYPE_TUNNEL_ESP 0x00009000
> /**
> + * L2TP (Layer 2 Tunneling Protocol) tunnleing packet type.
> + *
> + * Packet format:
> + * <'ether type'=0x0800
> + * | 'version'=4, 'protocol'=17>
> + * | 'destination port'=1701>
> + * or,
> + * <'ether type'=0x86DD
> + * | 'version'=6, 'next header'=17
> + * | 'destination port'=1701>
> + * or,
> + * <'ether type'=0x0800
> + * | 'version'=4, 'protocol'=115>
> + * or,
> + * <'ether type'=0x86DD
> + * | 'version'=6, 'protocol'=115>
> + */
> +#define RTE_PTYPE_TUNNEL_L2TP 0x0000a000
> +/**
> * Mask of tunneling packet types.
> */
> #define RTE_PTYPE_TUNNEL_MASK 0x0000f000
The patch looks good, but it should be renamed:
> mbuf: support PPPoE and L2TP in software packet type parser
The patch just adds the definition of the packet types, it does
not add the support of these packet types in the software parser,
which is located in rte_net_get_ptype().
So, I suggest this title instead:
mbuf: add PPPoE and L2TP packet types
Thanks
Olivier