From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0047.outbound.protection.outlook.com [104.47.42.47]) by dpdk.org (Postfix) with ESMTP id 47B6F1B040 for ; Tue, 19 Dec 2017 19:55:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MWzz3GuJkF4gkKYKsqgOZCGJgEdd3Ak9XusqtvdxOxI=; b=fF0DIAc1pa06JBBNIEncS5LxyzNK0lMK2yjpgsifts0liRWmRHgu4dQdAC+x55dxM0dcOMzKL4mCDjhhtkwpDhgO3XbVNi+3opNeb5dZBDGXGcL07ZYO3GYF8FoVYUhlVg50NleDOwcMTeNDdpR7s0DblcSYHtxMxttPFtXBvqs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by MWHPR07MB3472.namprd07.prod.outlook.com (10.164.192.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 18:55:30 +0000 Date: Wed, 20 Dec 2017 00:25:15 +0530 From: Pavan Nikhilesh To: "Van Haaren, Harry" , "jerin.jacobkollanukkaran@cavium.com" Cc: dev@dpdk.org Message-ID: <20171219185514.o5plwe4i6omoobi3@Pavan-LT> References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-8-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: HK2PR04CA0051.apcprd04.prod.outlook.com (10.170.154.19) To MWHPR07MB3472.namprd07.prod.outlook.com (10.164.192.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 274c09eb-59e9-4054-cdd9-08d54712146f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:MWHPR07MB3472; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472; 3:MB5BlPdpCqZx9ZwqLWoFjTCA7hzgwaPavamDScy3IFSRbFClwIV2mBCjLe2EuMdXeojJISuecQNp76iYNpYSEltgU7iAnoHplteoWKNaBQHbhijN9XAZhqtsZnQsUgC/a0zmm7qVk5tNIuNE4huoH4RDv1kod2E0/D+UmEHO0h1TghA9i6sdJmo1/SeiTRO0Q42QiLWzS5/vICb3HmHIhX9tKoas3vCQ/Xhrrlm/dXK1sZDYZ3sGe5aMpSeROEqE; 25:tWZ1cVOAm1372VS4Qpi8GQF8q21Hef27PMWQyM0hIqz16/F/TSbMsV4ueGT8jRXUEJYfBuVaVO41wL5HBht3oWZOQ99V/rA3K3TpvYDVYsgOYKbTWbhcu1DoKrkzwiHfJP5/NCUnRrC3b3mPIjirsgiF8Z8SGPKQN2aGCpv4+ZruW4rRkOWj5iNWQV/SXX6cQTtvEJsMT0I2Rq4SjUmSSZnkT/ze2Xyh+Ej0FXa3Re0ju7MLnrWqxxss2ADDT6Bu1Klyl+HjX1Z5NNiZrn+3MVZXIiJNagLZOqGNZnr895KnD7aYYJqeFDlIM4DvVgO61KVM6adQb/Qzy1U0tjLxzg==; 31:vf+PvVFmb6xVMRRoeLeLHFxsOGZsAJZvDcVY4fwsmSOa5ZFGWahGZM2KwyizduWRVD083yXzHVVha4iIJZJyAkmVJIj7qwPMGoBxgaQ4u8Ldi6in2s+78AbRYPCVT7Fhy91VPuPxt8qMtqn7OuF9wzeHkhxLGoqgdVdaiKLZ2v7vuqR8Gb0EOgBt0/erzVLudXTQZx33x6OMgBHmbh3/UGLRJnBxrzDOGQDlkFJaU50= X-MS-TrafficTypeDiagnostic: MWHPR07MB3472: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472; 20:AfXbA8UthqiSZvhVOs6rLJ8haWA8rguKDhvC5UV81vamAW9C/00GqlUbVcGBypSPRiKFqqB2+3gsg1+DAY/DO4lqH4e6/QOUGntAGrf4y3cEs06bcOv2jX6BxZPe5FetSaaq8Xqb8/xWooWiaLAPbcFGxFp1SA2SQ+kmpFteppCQw+pNFmsk1DTNYzUatLMRAbtZ0pN+2Nx3bps03jeSOoH/kB7z2dMIiZF7ldmm0YPJMfLd+MoETtDdZlQpCsSHZ9RkjdPhZq49OVhbMqJmTqKG8syNuocnyK/qUgtoNVLe6byd3U+4JRBBppOD7b2K6DN1G6cDUTriPitQZaaJJoH4OCuXjGWGgPzWyzbSEaGucNcobcbNe/azhBHsFk3w0ZUfLRQehvJU8zC/LK8BtY+nUPq3zhKjbNVXDTApSbdwa7lboH0JnVDXi//YfUt/Okvj5B5Ki0jaW1gNOxvznelRPGwNoV6fcCyO1nXUwZ4ZkTFwf8n4ZarbqonN5Yn4RJgLkwHJ6QRCv/dIlAgqYyIsVjqHCKwrYDNMhkMN6/SFSfo59K39SUx7GFfoML9AM0O6USJItQIQXpZgT8DVDb6wjk5n9NHgftNwV1IalYU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(3231023)(10201501046)(3002001)(6041248)(20161123555025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148)(201708071742011); SRVR:MWHPR07MB3472; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR07MB3472; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472; 4:qZC2/j/bcdsCRVH8Moi8uz9hu6TFt0pT1hmmwxMTpQwoXN3xZdkMqj2f1ZW6VOwgRevh3/p0o5yixkIatQKLFaiKMtgghNYNoX9vSOvqX/Fpbpo2uEJkZDfwt+02lk1wvjtMzDhlpmqnd0XmnWYJqwsc+cm+kIHzY53TZ1BXc9R8t+65+W5whsCSJj+AVs1JgHa09msR3jpx1SC4VY5i20tkAkCJhS1uxnzt70gVhZ77BYm6fljomE343+TAfoARrzJrfWIv9fLSsCrIXPfrtduIcCCyRKnYjCjTHiOeeopqBmKQkejyUADBiaVl6Xrv+QXYOudnXUcPLdRwDPAY87KMe770Ok6FRIhPbvFMSLU= X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39850400004)(376002)(346002)(396003)(24454002)(199004)(189003)(53546011)(3846002)(83506002)(1076002)(25786009)(2501003)(23726003)(6116002)(4326008)(16586007)(47776003)(106356001)(105586002)(16526018)(53936002)(58126008)(110136005)(316002)(5009440100003)(6246003)(33716001)(97736004)(55016002)(72206003)(52116002)(2906002)(8936002)(81156014)(229853002)(2950100002)(66066001)(8676002)(9686003)(42882006)(386003)(305945005)(7736002)(50466002)(5660300001)(76176011)(6496006)(81166006)(33896004)(6666003)(478600001)(68736007)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3472; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3472; 23:7EzbFcaXhWfp74T6nIaKXnTIHZAMp2u/S7qa6RyDB?= =?us-ascii?Q?E1UQdidn4yGPA/FPWzylA6nh49NTGod4MUmg7AA8hCWXLU1j0qqXVSV4N0A3?= =?us-ascii?Q?uyihBi22VcGnYyT68F50vy5o5dfpOHGLdkPvPceUkJdswPbgcdQukRWjgxWY?= =?us-ascii?Q?LThEpFDCNtm2iFDZWoO6NJ8WlX8DLB/KEGVVruCko1U9wI5N6lrub+P1lq0m?= =?us-ascii?Q?msWKO05g4a7cFRXX9WtWVIhGrk2WDlbNEf/l80h2c2IL+tXEAIFvzGnx37O1?= =?us-ascii?Q?LA2Rrc47V7LsHyZvRvwBtLKkzV0ALKL5Z1md/lgHwJHvpzjPZ1FK1N/eTy+6?= =?us-ascii?Q?bkes37HGQFtv0avBKDlM1+BxPDhKPmKPZSy7RKG+RHrBfamRLKeIsq0oeH/v?= =?us-ascii?Q?JgZSgZBpVJkEXIapNNl4X/+9vDdYvmiFtgiNmtCobbJ1sR8LW8Zn13JffoZh?= =?us-ascii?Q?Oen0EkcjI0KTW6Xxd4B6GuYdigEH/GfhTmJSwC/LVrt974xYvMbywod899tc?= =?us-ascii?Q?Vga8k4s1HaWZoSbaiXrz1lOzMGD9uURybyzNq235MtP6FGBD2zMsnmZ/7YvV?= =?us-ascii?Q?p+pEzBPFRDJ4M8d6MjwgQrUhT6k/sgC7b8UW2FjrEIeTzAIQyaZ1B53i81Js?= =?us-ascii?Q?eEyMPkxGedKhhiiCRyI5ngWn5Y6LZFdiJA6dG7lS16fKALy+wyWdPZHmGEWo?= =?us-ascii?Q?vUN22o6i68aCTwWS0MpbBzs/U8CDe1k6+j+oQaEzRwd49V7gpp693LCNh7uD?= =?us-ascii?Q?W/kqW4IwNT3I2kPWvhX4PELY92ArNn6xBA1cuA8kEKrRkW9fqXqz+nH432xe?= =?us-ascii?Q?oz2ufD8N+/VzxRhD6Or7KMCRN/mFi1c6Tp4tKU5qxzDGj1ki2EJzP1WiChg2?= =?us-ascii?Q?5Uy1bgSalXNQDvcwXCxbjIuhgofUhX1lJYLG7OKcoF7vH0GiR5mXMxrYBaua?= =?us-ascii?Q?bvbx05by9CLUspGWpOTPVuwmHumaqxCdiBJkcOYqyLJd1e07PJpXh6R7hsjT?= =?us-ascii?Q?3S8yZk3VtqB7AuEZETlB5LcYh02tMGVbyewQu6aQqVw13eLfDaSOy4GeESLK?= =?us-ascii?Q?XsOwtcpoQipZx+WIUGXcAptw+7gypAftzSKwFMbzOMcdw75ivM56E8m+ZIsv?= =?us-ascii?Q?aUbNSe9ZSDvPYlMXpz3m01bE7MhKj/6DYLj6MvWOYfwkyA6ONxCxCBeuvnwN?= =?us-ascii?Q?7PL00yoiJ5rjfbx7YCS7P9hCku88f5Qs0j8V0qEM0rOaettKEq8ackvBgw7Q?= =?us-ascii?Q?evJ+zMJ0G5YqkGrTP+MBnbXiEljZBkdwhc9yGkJdbRb0656rweeaIchtS0jI?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472; 6:PQ34nMa5fbKmXac7DEAVTd8XW43awlMAdksjOrDKLS1XvJcmDsPD2i6qyAgzVXefnmVrLwUItdfr/TGXCl44/gscFO+9YOchO5ahSbRrOz2uQhu08+b4FnIvEvojCfyGBXOgSKMcMCieUKIhnv7LVmCgdS/jbvkskjcNtDNPMIIFfwsqfm28+knsudGEPdk1vhVVmo6LydX7vJARMDQ/BKHgQizIfFz+K9NWOGhgASuDz3iCsTo8y52SIYxJkSh7m73TnWqs16HMBw9tpeSkJ5aQJak20l06fhYVZD12XitKZ3RT49lmEnj4SK4Rmj/ty6/AgQqMzTMXcdqg95UDA5JcC+kcvgL+Ad+cXdcOxSU=; 5:AKAbDK9vcFgu3mU9dsKDoQILTlls/jgRdH+B+egX/fC/K4DEeJE1c9lNJv6sN9NWDSpLpnGgEcT/XQWmnqM63Kn1aC7r1r1M02W812ElMPfRa0RDe60uOVCq3+DsYEbnGwyCKEVbVS2lxyx5SVuABk9+aQmoYEj/5f2NiSa91mM=; 24:OFOc1fd091UVJhCEeR3Kp/EpUaZZs6g+CrBdQmQPwxs7pq69npDinhkoUUGyqP1uuiij3ktLOQ29SLIGqFcQNNZQA/NMF9Fy7iZnrVvYftU=; 7:t0UlLRWCL1JPvZXz3ZiKbTX6UWEu8qbgaZKSO8krjrA2kRoEI6rQA6Ap3CuJyYMhqXmAdHHxPXdFEd3bYX8VQlRBBRlivthBNBXgKUO59CfmURKMETvdKmOUK87cIeIADoljb0A7O2zRfIhiqz5/ZRBTBj+uOxKgIs8ja09E56zv3pLGyo72oGJBhEC1MgCDJ+NgXeA5joDKxD8S/Aq/qCtYs8nUFmzVyEim0aJXSmv4h3YwyudYRrH7x7VRoaKZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 18:55:30.5023 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 274c09eb-59e9-4054-cdd9-08d54712146f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3472 Subject: Re: [dpdk-dev] [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 18:55:34 -0000 Hi Harry, Thanks for review and comments. Feedback inline. On Tue, Dec 19, 2017 at 12:00:02PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Thursday, December 7, 2017 8:37 PM > > To: Eads, Gage ; jerin.jacobkollanukkaran@cavium.com; > > Van Haaren, Harry ; Rao, Nikhil > > ; hemant.agrawal@nxp.com; Ma, Liang J > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline > > > > Add worker pipeline when Tx is multi thread safe. > > Probe Ethernet dev capabilities and select it it is supported. > > > > Signed-off-by: Pavan Nikhilesh > > > > > static void > > diff --git a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > index a5837c99b..0b27d1eb0 100644 > > --- a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > +++ b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > @@ -108,6 +108,7 @@ struct config_data { > > int dump_dev_signal; > > unsigned int num_stages; > > unsigned int worker_cq_depth; > > + unsigned int rx_stride; > > Perhaps comment what "rx stride" does? The others variables are logical enough to me, but this one I don't get.. Sure, will add comments explaining why we need rx stride. It would basically reduce congestion in entry queue when using multi ports. > > > +static int > > +setup_eventdev_w(struct prod_data *prod_data, > > + struct cons_data *cons_data, > > + struct worker_data *worker_data) > > I think this function name can be improved - what does the w mean? > I will redo the funtion name according to pipeline name. `setup_eventdev_worker_generic` `setup_eventdev_worker_tx` Pavan