From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0046.outbound.protection.outlook.com [104.47.33.46]) by dpdk.org (Postfix) with ESMTP id 9EC131B1A4 for ; Tue, 19 Dec 2017 20:01:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jJK5uc3KbUccI7eX6J/pYttUA1t8YDICQiuZBDwsEN8=; b=OqkXNx1X/9OA50cwxaJpzjwp6iQeApUX0eyQCVRFdDW0+s+HAFRuoCtOTw9dJYOfrSHIUArUnxSRSrsYz9r8Y0DjKj63tIOSbsMvTam32XuOFi4F3YFQUOv/B4ZATJLycP9cAgfkvaqhbIVNhByVPlQlqLQwFymn+vq/VvFRhj0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by BN6PR07MB3459.namprd07.prod.outlook.com (10.161.153.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 19:01:52 +0000 Date: Wed, 20 Dec 2017 00:31:27 +0530 From: Pavan Nikhilesh To: "Van Haaren, Harry" , "Eads, Gage" , "jerin.jacobkollanukkaran@cavium.com" Cc: dev@dpdk.org Message-ID: <20171219190126.d3rwzcwli3jbsvrn@Pavan-LT> References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-7-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR0601CA0001.apcprd06.prod.outlook.com (10.170.128.11) To BN6PR07MB3459.namprd07.prod.outlook.com (10.161.153.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba11cf18-acfd-4986-b49c-08d54712f816 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307)(7153057); SRVR:BN6PR07MB3459; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 3:mdBrtGS50za/z2FvYtMxoYK7tUzyLuBRqtXkCjSTQpp+GBmPh7vjFs9e7CeYF2raLeNsSz7j/Xv5m9/ANI28pXZE2fU4waIUR+jmOpoRUnJJlA4LkZQlNbViqYizzz/aOAwDrXdNOaXrbNY7RJVjcBl3pmJmcnz4eariwAmFCOlp7mNlyKXrE3LLvqia19mYCObv2pH4cyCON4pTpUsqZKNFAkTL561uY4rxGbeh39vhkx5CyhnF8Y1r4MlZLB0e; 25:GOhQ62+5T68zMZvYg35Jz9uHovD3iVXC15rV4sweerDkcZyrSdiPnne4YblBaz83cGJdjKg/StjAjxhuTbmpCqiZF5GBG4NYHmuJpWHWkWyzvu1UPfVmSMssQS/AzWn6Ovm4XAmVwQMaw0II2CCKVQnFqnad1bHLB9IPUBs9y2qZRWxPT9BRBi7XS/0vDQgjxmxYq5290tgrtSWAtlJvU07mL81HJDklOlhSPeMaRvW4S9TsiTIZ0d93KwRp5QBWYba+ViBNVDqfSUcIRVWMF9r+abXBIxuqG1ChIxR5i+TkDsZX47JhiFK3lmcZmiixaCleBaInYriCa9MykejvBQ==; 31:RzUfMNxWHbaXx6zodBOzLso8d3KXSJYYbEedfN/F7t7dtcw9u5+0CWClzZrnvV99XeO9NOGAGAEJ8+O3yJMGDEdETHv4AiraVcDMTZH+Zm5v99/3AKdhwm2mUP/Mt2u7GT80S/TdNtmhRbcaYxK5L9yVYJIovxU5euYGADPjroHqGu1eFn7aNESI3n7lDlXPULXJ59AIKSy9NWZfqafAdTmZM0NoA726zH6hrw0Xg9Q= X-MS-TrafficTypeDiagnostic: BN6PR07MB3459: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 20:R9UDEnoZAZI9K8btdKiRa/31vAEqDYDhqrVZSqoqpY7pDJ60UVkJWjfbe8YVmbgTJiJMsE6AB1DvSKwnrTXqPLQpgvWax478rOqHBmQojHvQqeTQ5BP0AVGJzX44r7u6PawZe3gAOVxI41BbCaZrFo51pEySEzjjODpqljXUij7VTgkBCfxoh5a/L0w/jhYFKHbdiTbyRFPP5/AHZ9R9lgkDxbz0cCZ/sR5KoV+NKPrg/DKgMOxvbiQqUaUKgo7qqNgGzI2F7r00yRmo2BKbm/tMKfqQ1o87hkys12B53b0oBMWGRtqeYTj+9lfXmb31UYPLNfgmtLx+YiopzqhYiUFi7PTiULC85fYOwfry3HW+B264rHnAC34Yes/NZSQkeYfwjaA3+YvLRM80aKH3aNcu+ijB1BefE6ofj0d7c906/c033lgMnBDsL3jP2iCzrPjnjSM7WX0KXKaQSeTd+PDftDv3cJsdgg3Ztvjp/s80+2ezS8cYCRsB12lwvPz+/zvQhQX6CQFUR1AfbyNL8nwSJAV+fvs4+FXkpWo+EdP9s+S//fQyvwuookvP+OYVhib37097sKVKnCBO45OlOqcEDdooRXDNpNVOpYCkVGg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231023)(93006095)(10201501046)(3002001)(6041248)(20161123555025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148)(201708071742011); SRVR:BN6PR07MB3459; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN6PR07MB3459; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 4:qJ43QEY8+Stm8+BFwQzUOsyfQjAFIk6tiDoyasx0buKC0t7338bGzMQv/mm/CuhF7kuyhJk1VTZTErDdyuoTrozEuuxwh2JTnKMcozLaglZUr/sAFBsRo2IVxo7wYsyWdm/4/ciikG+gmLc2fH3y1W9QSTATYs+r8t9J0YILoAB0EBdkDQ2kaPolVGOXWV0+/efMxIzMyfkoVuA3wg3310P2kCoGro6hJE54NMkWSrEAfvrQOA3OVg5ji8pqvtIIeAe8swsm66E/yU0tWcu2Bkewc1GIsHydLRGAc0jtPGZMEEGB1h7bXvxVw+5VIEQDkZ4UzyMvaHs+TdgXhcoqIUnk41wxmSgBB5KPeoo5ywU= X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39850400004)(199004)(24454002)(189003)(2501003)(8676002)(1076002)(3846002)(42882006)(97736004)(6116002)(105586002)(23726003)(2906002)(53936002)(25786009)(6246003)(83506002)(316002)(16586007)(33716001)(386003)(58126008)(59450400001)(4326008)(53546011)(72206003)(478600001)(33896004)(50466002)(7736002)(229853002)(68736007)(5660300001)(76176011)(110136005)(305945005)(9686003)(81166006)(106356001)(6666003)(6496006)(2950100002)(47776003)(8936002)(81156014)(66066001)(5009440100003)(16526018)(55016002)(52116002)(41533002)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3459; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3459; 23:SUSx5Vfdg6oemPoiiSb/8i1hz0aHXE81rA4WE01ST?= =?us-ascii?Q?yW4lqS7Q0YtAZNzHpHKfSVF9y2SiKnwQnZMbunid/mzOUupqi8RSKgQoczvH?= =?us-ascii?Q?WDZr/5gY64RZ5iVTSPmIq+MbzbHRd/Dk53D0ZVMy1g7QX/PIZs8GcQoijd8A?= =?us-ascii?Q?DxAfCGNlG+TkM6X73PJBUf3200n7cWfvj5rS5/3HVrg81cqUBJYZRUc1ucUd?= =?us-ascii?Q?NAsEHa6Ma6MU+F5lidS1jCtmDcTlEHiZzo7lJDiz2QELVHgV68M29kzm9m+/?= =?us-ascii?Q?n9BXrAeW907NDpi2t6j7K28f3XIrDEsTLZ+Bwdy0SfR5A0ruL/t1cc1hI8+8?= =?us-ascii?Q?elxGI8uP7fnle7BOgUITfeNy7p7K5IUhuZL3pBTTXaXA3qbIqcy6wpOnyPSQ?= =?us-ascii?Q?/WQE75WfZLwQEVJKXg3c2xff8pgMqKpkLlW8TVxkWIiCVV83vo+nffpLfGSM?= =?us-ascii?Q?KkAoIxo37vsZ0sjTnzQpMU5sWS8YoEkv6HdCD+ym9uxwbezNudQCYEbPjkyH?= =?us-ascii?Q?WQR4zmjc2F324qX7elJvDTW9X/BuGfEgYn7o6SeD8HEy0IpjgILxAsACtRGw?= =?us-ascii?Q?yU1Iu3KiLAUKiPlzmOsEm8Qml+T0ToVQPU7Y9JKGWXxSJbDcbzIqN8zk//G1?= =?us-ascii?Q?8YPJzftUsvxgJ7AjnLcRu96mhLqoH5JBgeJzdwLFFRF55D/7KwqURK6TtcmL?= =?us-ascii?Q?2c69eQ7lvJvOIV5V7Eu9GlT/ZGvOiNVkWBFhjhAJnrPHWbugbPWfL3zTO+PP?= =?us-ascii?Q?Xs+Gxl8kx09NBASg4gmjj5Xlg7PxMSWiODYc5emts9A8JAOsr4iYDsR/yumE?= =?us-ascii?Q?fkmGJZc3u9QgvP1Or7SHtr1fcYJkQEl3WJFrJnhDFLZhfNsJZs0Hib7lpldM?= =?us-ascii?Q?XUoaEnPu56K50XQ5wYzdG43s9KSbKP/x6Fp3V6vzn7Olv1omKmdehHJgbUcO?= =?us-ascii?Q?OQHmFOcPSMWFpvYf7wm87lnzlteU4RpoRO+BQgJ+zahJnAt+7q3kxAMEqODC?= =?us-ascii?Q?om0ULoqQRwAqeseIgPNMfnvd2cma+hzyTa1G4lYGy0Mad+PKYH+uwLJY2RKe?= =?us-ascii?Q?GSjW+r7/5AV70Q6ab3B+n0T29Q2/Cw66P4A2tHqO3WQzzxdgvpH1eGW4PWXN?= =?us-ascii?Q?Iys8uU5+qouSfavUsyafW8yD3VR8L3tttVGrDifekQgQ6WjyU8kUkEYZYa1o?= =?us-ascii?Q?jtBjmflRcBYxW1ctG4b4jU36O9JEBwmEBbUdfasDAP4aUZbPM8sMkpcmy6yy?= =?us-ascii?Q?4o/iPGu7kln5FiBkC6nIi+j1gJJd0GxpVvPYJ7yFG29xw5zrynCzWDWnJeWd?= =?us-ascii?Q?Va0jhR6P4RaCW0JQ83RXvCbW4t01HGeHg4je3FB3obK?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 6:LBhXAkE6QOhAm/lLMkgb0zzqRJUl3w2W4TQw5m+3z4xKshg6tqhSW3CJcyZhuK8B7vVkJjLPLALIN3RhXlrFtj2oxSA5BozdF2CQfoF6S5VaJTEXWeQ8YyyidzmJOOLFQ8DcxRAF0Oo01DcdMA6jWeoAoPyVGMxWzkio52Ne+72uzPEMx+lFl4Z9uWjwK5yawpP83eaqU0OXPluv5v6vFR3oL6c+brRYvliIlMMJKyov4Brw8CyfcsSgDDICq5/bx/CH3iz9yjtm/HnEkA9syqFBg71lLmtksKyFFX7R1jEDxWmHe4k/D487S6+Ic2jv/n1dthKvj5/PkwWLEIjWWujxKPEez63UgoLNd5dmC4w=; 5:X4alHVh4vU742H2oFqFD5lVnyr9DO8lQ4dhS3few7LZvgpSitKXr+WRO4ABwDfq8ygmUipPFXh9LV3zbYAfWwtL1F24PwvytUyiHWnQbiqk5DjdRPyGUZ4C4GRYpg9JvH6iSSjJcOjzDZMf6HF6juiKPZKUFep2Ya6r5uW3mkok=; 24:Rpq54hMq2j9ZOl0n3WQ+H3wbhyEEnMpp0ZabHiQrDBXKDBnAxFwv5gyPvzvZ0sdzFvQDHvfvWbIBB8qofdidV/JWuaB0TrXVrQEwIDor7kQ=; 7:65t6GuhELtzBCxd/1zmh5hJLr/pu4OV4Uj87nqv9tf8BDa1tMB8so+E2mFDyZH5arDDPqueOwDTFB8/3IrOm8ogMILMK8JOucx5cN4ANdZOvBusjnFXLgAzGl6+ckLpCnGbSMIRVvUhe8sMmlYXeiQhzREHof2J5Ma1F8nV72cxJnP0iREmYS03XovSIuRva7Jy77BOFK5yzcDclTkSZzr8UCdoIT/OmGePhss/q9CTT6OmxrO5veGkJDZE8nCBV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 19:01:52.1420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba11cf18-acfd-4986-b49c-08d54712f816 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3459 Subject: Re: [dpdk-dev] [PATCH 06/13] examples/eventdev: add non burst mode generic worker X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 19:01:56 -0000 On Tue, Dec 19, 2017 at 01:26:30PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Thursday, December 7, 2017 8:37 PM > > To: Eads, Gage ; jerin.jacobkollanukkaran@cavium.com; > > Van Haaren, Harry ; Rao, Nikhil > > ; hemant.agrawal@nxp.com; Ma, Liang J > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH 06/13] examples/eventdev: add non burst mode generic worker > > > > Currently, worker uses burst dequeue and burst enqueue to forward events. > > Add a non burst mode based on the event dev capabilities. > > > > Signed-off-by: Pavan Nikhilesh > > > > > diff --git a/examples/eventdev_pipeline_sw_pmd/pipeline_worker_generic.c > > b/examples/eventdev_pipeline_sw_pmd/pipeline_worker_generic.c > > index a72b7b2f9..5998aae95 100644 > > --- a/examples/eventdev_pipeline_sw_pmd/pipeline_worker_generic.c > > +++ b/examples/eventdev_pipeline_sw_pmd/pipeline_worker_generic.c > > @@ -1,5 +1,91 @@ > > +/* > > + * BSD LICENSE > > + * > > + * Copyright 2016 Intel Corporation. > > + * Copyright 2016 Cavium, Inc. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyright > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above copyright > > + * notice, this list of conditions and the following disclaimer in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of Cavium, Inc nor the names of its > > + * contributors may be used to endorse or promote products derived > > + * from this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > + */ > > + > > Adding a license to an existing file? Also can now be updated to SPDX style > We still need to get approval from legal once we are good to go we will update it to SPDK style. > > static __rte_always_inline int > > consumer_burst(void) > > { > > @@ -412,9 +555,13 @@ generic_opt_check(void) > > void > > set_worker_generic_setup_data(struct setup_data *caps, bool burst) > > { > > - RTE_SET_USED(burst); > > - caps->consumer_loop = consumer_burst; > > - caps->worker_loop = worker_generic_burst; > > + if (burst) { > > + caps->consumer_loop = consumer_burst; > > + caps->worker_loop = worker_generic_burst; > > + } else { > > + caps->consumer_loop = consumer; > > + caps->worker_loop = worker_generic; > > + } > > This won't scale well. See notes on future patch (9/13 and 10/13)