From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id E43081B1AB for ; Wed, 20 Dec 2017 19:58:43 +0100 (CET) Received: by mail-pf0-f194.google.com with SMTP id j28so12927049pfk.8 for ; Wed, 20 Dec 2017 10:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nzfoAvnUl7FnjDkR0lfm2UVzjBwT94knTGjFNFl0M3Q=; b=rR7oP/oC0AlVHivXQPs/ji/5dIoIpkRzzXxGX0aAZTy1t5zofJJnuAkkgHiQduT9X2 /FTqWuR2e61Z/DSk4gBuDPbfwylvC9df/Q5pPzCPg+OwGSeQLooM/v2mCviatKplIr5b 1t4/cmUh4Bmp1c29WbnVEAH7wQrY+bm60ceXvMAgMhF1FrSIPTgiogNU0TArk7kZK5YN YTqMtCOlsgWwDh5nXPV/ZUTBUylCBgvh5z/wUAOfDRx3AlkzkTZabWI1PRj6MCflrgV8 cvbWJVp7iq7e+7s72uGM7LI69CiW/CMAU7GBQfFXC1hlF95sZQGpyttdIJiIOp46AvGL lUUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nzfoAvnUl7FnjDkR0lfm2UVzjBwT94knTGjFNFl0M3Q=; b=khIoHy9TXnDI59e98LWYzj+owgpNnBdRuUzAzKuBV5GvnnVPY2mRZzjGh43nw3/pkK QyRKvchY6zqMdoLnpWOw8/946C6r0RIouq6qaSAyXWVoPCdNM+A8BsH/OtT4o2peDQOO BTFrAygppQkD0fAyJPyf/PXkwomXjVZKZQWzL1t2friW3aMvMN7S/dqR8FpPnVkMP6lH PfQ0Ezwd2nGmNzKktPB2FP5zQYi2tLNi/5LkPwFkvTnp0I3JtFfpXAec+x87kMwsGuzw Gl8axS1dsYQvOG8NZCvsnof3UuJFescsgDIuQ6iGDNPQlqK3jKu4LwxdbVe+EJIyaN3M LBuA== X-Gm-Message-State: AKGB3mJTs7M1scvE94S4a4gPxqSz35BMoRMI3rRVOn1d3BIUKpBHayoQ zuM+PgpGfU/JRjh8Tvz2HmTnaw== X-Google-Smtp-Source: ACJfBovrxaDtGdaV35kRdOfNvyF30X+wzHSMcUqzafhDqi+kSmENrq3saOYT3AcFeyQgYSU+tdKYxg== X-Received: by 10.99.111.203 with SMTP id k194mr3772889pgc.21.1513796322935; Wed, 20 Dec 2017 10:58:42 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id k80sm39944124pfh.30.2017.12.20.10.58.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 10:58:42 -0800 (PST) Date: Wed, 20 Dec 2017 10:58:40 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20171220105840.42c3974b@xeon-e3> In-Reply-To: <18dc54df-4a30-da3c-209c-9794f01f8ab3@intel.com> References: <20171219063840.18981-1-stephen@networkplumber.org> <20171219063840.18981-3-stephen@networkplumber.org> <18dc54df-4a30-da3c-209c-9794f01f8ab3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/11] bnx2x: implement dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 18:58:44 -0000 On Tue, 19 Dec 2017 17:51:46 -0800 Ferruh Yigit wrote: > On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > > Replace compile time option for init and driver log with > > dynamic value. > > > > Signed-off-by: Stephen Hemminger > > --- > > config/common_base | 2 -- > > doc/guides/nics/bnx2x.rst | 8 -------- > > drivers/net/bnx2x/bnx2x_ethdev.c | 15 +++++++++++++++ > > drivers/net/bnx2x/bnx2x_logs.h | 17 ++++++----------- > > 4 files changed, 21 insertions(+), 21 deletions(-) > > > > diff --git a/config/common_base b/config/common_base > > index f775ec96184c..82d1f9ac47ef 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -244,8 +244,6 @@ CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 > > # Compile burst-oriented Broadcom PMD driver > > # > > CONFIG_RTE_LIBRTE_BNX2X_PMD=n > > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG=n > > There are a few "#ifdef RTE_LIBRTE_BNX2X_DEBUG" usage remains in the code which > is causing build error. Ok, I didn't see that. Will remove the ifdefs