From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id A51C51B1B8 for ; Wed, 20 Dec 2017 21:07:43 +0100 (CET) Received: by mail-pf0-f196.google.com with SMTP id n6so13009015pfa.4 for ; Wed, 20 Dec 2017 12:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OslT9vaLRCJ08JgASoBqAFTgR0sZDgRo0aXrxWe9y58=; b=CLFm0c3CJCyhkAg7n2RS2MIhKEutw4iQ/jyZDP0gqmE3hX1T+IWo3AKf7RYzPVR9a7 tbbm+NLpvRgGHRKxN6JYqKCmwtTKYJYiVb6cXuzHmFpEFY/GWPnEePIxQfDLUSm/87/j vmP5bIw4Dn6uaXR+xBwrsgXjpgulq3G8RfT49mHa3+oK9/4iYWNzQrvoeWGjCKXt1BfN S2XLR4RjiilYek1/giHpvXSi9Aytg8goPyNZZuPLnNAhudBRN2pF2jjQ2l9FjIkaJVJg rYANq1Rn+KeaEMxXkzmqiSDnUFP22jvE1EOsZVEbzguuX8NQqtAEfiwkH9VbgbuVkDbn 2x5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OslT9vaLRCJ08JgASoBqAFTgR0sZDgRo0aXrxWe9y58=; b=Q8dX+Mp+XcKytauO79+DpEm1qNVs1+5+CbdEi4RCr0g5D4IVTzVAdF7V2Eekl1t85K QC0UoeT5OejqAw0EpDaaxkuLAVzpKUWRJPjo6DzNuuLfLEjHwtB3M4JygNe176CRhF2Q ZdmeJpA3coH4DiF8TqEKLBn7GSfakrqon19bmbESAR7okr2tSEnDS6oNuSgOdxYyp4tP kiv9acT6rAUjOw8fu6f3/l64U9jJyIz7/i7k9x/dhrb513sylx446X0PjjZ7rnc86M+Z nPoao+bm6kl42HN+i55rOPjirAjS9ZakQFGuVb+kA4my38sAtHSwZFOgjWLMEZGnDLaD k7ig== X-Gm-Message-State: AKGB3mJdVpxJFyPHH2vMi5qlPPVV+STYDB2WvJd0N7TmIJKjvHS4LOGO wNAAh80oepMYAYHVC2QjvRtLCg== X-Google-Smtp-Source: ACJfBouWblSMs35HqGmVfsQcEOA6AZ1+YL86FuEj7XR5b2UmvCbgsGGWd3NXBabVYsVJOZt+mqB8Ag== X-Received: by 10.101.91.78 with SMTP id y14mr2655400pgr.293.1513800462748; Wed, 20 Dec 2017 12:07:42 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id v82sm37665709pfd.111.2017.12.20.12.07.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 12:07:42 -0800 (PST) Date: Wed, 20 Dec 2017 10:59:55 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20171220105955.698bf9cf@xeon-e3> In-Reply-To: References: <20171219063840.18981-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/11] Dynamic logging (just do it) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 20:07:43 -0000 On Tue, 19 Dec 2017 17:51:22 -0800 Ferruh Yigit wrote: > On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > > This patch set implements dynamic logging for 11 drivers. > > All these patches are compile tested only. I don't have > > access to most of this hardware. > > > > It makes more sense to "just do it" for dynamic logging rather > > than keeping TODO lists in the documentation and expecting the > > vendors to fix their own code. The advantage of common repository > > is that global changes can be done. > > Hi Stephen, > > Thank you for the update, there a few minor comments in relevant patches, except > from them set lgtm. > > Overall do you think keeping todo list is a bad idea? > There are a few more issues like this and I am not sure how to communicate them > with PMD maintainers, any suggestion is welcome. Asking maintainers to fix things doesn't work well. The active ones such as Intel just do it anyway, and the inactive ones will never see it!