From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5725E1B262 for ; Thu, 21 Dec 2017 13:21:14 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 04:21:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,435,1508828400"; d="scan'208";a="14158344" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by orsmga003.jf.intel.com with SMTP; 21 Dec 2017 04:21:10 -0800 Received: by (sSMTP sendmail emulation); Thu, 21 Dec 2017 12:21:09 +0000 Date: Thu, 21 Dec 2017 12:21:09 +0000 From: Bruce Richardson To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , "Doherty, Declan" , "De Lara Guarch, Pablo" Message-ID: <20171221122109.GA8256@bricha3-MOBL3.ger.corp.intel.com> References: <20171221101510.181082-1-bruce.richardson@intel.com> <20171221101510.181082-3-bruce.richardson@intel.com> <20171221102253.GA11720@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 2/2] test/test: add return value to mark unit tests as skipped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 12:21:14 -0000 On Thu, Dec 21, 2017 at 10:48:22AM +0000, Van Haaren, Harry wrote: > > From: Richardson, Bruce > > Sent: Thursday, December 21, 2017 10:23 AM > > To: dev@dpdk.org; Doherty, Declan ; De Lara > > Guarch, Pablo > > Cc: Van Haaren, Harry > > Subject: Re: [PATCH 2/2] test/test: add return value to mark unit tests as > > skipped > > > > On Thu, Dec 21, 2017 at 10:15:10AM +0000, Bruce Richardson wrote: > > > Add in a TEST_SKIPPED return value for unit tests to mark the tests > > > as skipped, rather than just failed. Use this new skipped return value for > > > the crypto tests which can only run if they have a particular driver. > > > > > > Signed-off-by: Bruce Richardson > > > > +Declan and Pablo as maintainers of crypto code. > > Looks good to me, checked unit tests using old build system and binary, but 2nd Ack from crypto maintainers welcome :) > > Acked-by: Harry van Haaren Following IRC discussion this set is now superceded by a new set targeting these changes at the main tree. http://dpdk.org/dev/patchwork/patch/32560/ http://dpdk.org/dev/patchwork/patch/32561/ Patchwork has been updated to reflect this. /Bruce