From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 339B31B268 for ; Thu, 21 Dec 2017 14:00:06 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id y82so20047606wmg.1 for ; Thu, 21 Dec 2017 05:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=FtBM/HE6eSJ1zVRVYZDeUkBGC8pi8TxQ8+Usl6skX3g=; b=QT2IOkUve8dMVW/KbTycwj3tvpX3c3OyQMVnt3poqmeLpfFqx2oSh1Oo73t90wU+0R zHkljCu0Oexk87B5wqmFMlpTsvJa/isJqn6dCp+CzrlHywrM/BEfL8ZU6oQk/nD3cGAM 7Gk/QzynDqNYZtBrm7TgzJxoFCSu/kjldyZGQPz/0+e96bvpAYhJQ6+6+Tu6FuXC9BlZ 2gAs4/KM9zez8En7CXbpX4FkAaxNeEsIshlAzCblOIM5xq/Xtb3dr67XjOJyJuTEfxA+ OIwM4lXD7iNfsr7mZX0mnMeE5PAV3Cz2VZLbmga8bdFfeHgjsQ+vsx/DLV0AdRKU73Kd RTkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=FtBM/HE6eSJ1zVRVYZDeUkBGC8pi8TxQ8+Usl6skX3g=; b=ckLUEHrknQYxCCiEY44XNoMx7C7cogt5ADIBXRYAJQavP1YtjVn23/okakbNtAVDp2 sY2w5SBqMzhNKER3DPt0WWJ0kGJujkLgm0euPsU5DCfvzuolV8bCzXmp3r38zkgsUUEm f4nKAueAg637DDM96QvAm1XOuUlmDTRM6/LvzmMsCZbHVqQqb/59vrG9wd4NA/3oF5nE Mj09ZPOU95eQqjuhdttvE4RvrBF/EgA5Tsbok7OOg0tiE540JDoQKTnGGMHb06Dd+Ezc LXSt5vvkvTkZJ/v07hEZXwXG/W49AFH8xG8EfRQnOHC9WXzdCDaSiUuB2SmA+dJnwkgd KsSQ== X-Gm-Message-State: AKGB3mLEWDGTaiYRm4FFkOTStiRNfcL7gXsp+XXO6JtFzB7feEaXu6VI ehuUFijQHPAscjAzgGyZL5GA9qVx X-Google-Smtp-Source: ACJfBosiEutcsUWCuUGANFiIXfPMK+XUxQKmFAlgD8Ls2a5pRifjb4ZLbiwRN3L7WA3VKs3BW6Urpw== X-Received: by 10.80.174.143 with SMTP id e15mr10478497edd.10.1513861205677; Thu, 21 Dec 2017 05:00:05 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y3sm18097008edb.37.2017.12.21.05.00.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Dec 2017 05:00:04 -0800 (PST) Date: Thu, 21 Dec 2017 13:59:52 +0100 From: Adrien Mazarguil To: dev@dpdk.org Message-ID: <20171221122458.811-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v1 0/6] Address various issues with exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 13:00:06 -0000 Exported header files are installed system-wide and must be as clean and self-sufficient as possible. In particular they must not conflict with other system headers and cannot assume specific command-line options will be provided to the compiler by users, unless their absence is detected and triggers appropriate #error messages. This series addresses the following issues: - The lack of rte_config.h inclusion in most of them. - The inability to combine rte_ether.h with system's net/ethernet.h, preventing applications from using the ether_ntoa() family of functions. - A couple of GNUisms (e.g. named variadic arguments in macro definitions). Adrien Mazarguil (6): devtools: update check-includes exceptions net/i40e: fix issue in exported header flow_classify: fix issue in exported header member: fix issue in exported header fix missing includes in exported headers net: fix rte_ether conflicts with libc devtools/check-includes.sh | 1 + drivers/net/avp/rte_avp_common.h | 1 + drivers/net/i40e/base/i40e_osdep.h | 1 + drivers/net/i40e/rte_pmd_i40e.h | 2 +- drivers/net/ixgbe/base/ixgbe_osdep.h | 1 + drivers/net/qede/base/bcm_osal.h | 1 - lib/librte_cmdline/cmdline_cirbuf.h | 2 ++ lib/librte_cryptodev/rte_cryptodev.h | 1 + lib/librte_cryptodev/rte_cryptodev_pmd.h | 1 + .../common/include/arch/x86/rte_atomic.h | 1 + .../common/include/arch/x86/rte_byteorder.h | 1 + .../common/include/arch/x86/rte_cycles.h | 1 + .../common/include/arch/x86/rte_memcpy.h | 1 + .../common/include/arch/x86/rte_vect.h | 1 + .../common/include/generic/rte_byteorder.h | 1 + lib/librte_eal/common/include/rte_bitmap.h | 1 + lib/librte_eal/common/include/rte_common.h | 2 ++ lib/librte_eal/common/include/rte_dev.h | 1 + lib/librte_eal/common/include/rte_eal.h | 1 + .../common/include/rte_eal_memconfig.h | 1 + lib/librte_eal/common/include/rte_keepalive.h | 1 + lib/librte_eal/common/include/rte_lcore.h | 1 + lib/librte_eal/common/include/rte_log.h | 1 + lib/librte_eal/common/include/rte_memory.h | 1 + lib/librte_eal/common/include/rte_service.h | 1 + .../eal/include/exec-env/rte_kni_common.h | 1 + lib/librte_ether/rte_ethdev.h | 1 + lib/librte_ether/rte_ethdev_pci.h | 1 + lib/librte_ether/rte_ethdev_vdev.h | 1 + lib/librte_eventdev/rte_eventdev.h | 1 + lib/librte_eventdev/rte_eventdev_pmd.h | 1 + lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 + lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 1 + lib/librte_flow_classify/rte_flow_classify.h | 10 +++++-- lib/librte_hash/rte_fbk_hash.h | 1 + lib/librte_hash/rte_hash_crc.h | 1 + lib/librte_hash/rte_jhash.h | 1 + lib/librte_hash/rte_thash.h | 1 + lib/librte_ip_frag/rte_ip_frag.h | 1 + lib/librte_lpm/rte_lpm.h | 1 + lib/librte_mbuf/rte_mbuf.h | 1 + lib/librte_member/rte_member.h | 12 ++++++-- lib/librte_mempool/rte_mempool.h | 1 + lib/librte_net/rte_ether.h | 30 +++++++++++++------- lib/librte_ring/rte_ring.h | 1 + lib/librte_table/rte_lru.h | 1 + lib/librte_table/rte_lru_x86.h | 2 ++ lib/librte_timer/rte_timer.h | 1 + 48 files changed, 83 insertions(+), 18 deletions(-) -- 2.11.0