From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0074.outbound.protection.outlook.com [104.47.42.74]) by dpdk.org (Postfix) with ESMTP id C128B1B2A7 for ; Wed, 27 Dec 2017 06:19:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Za2RVbslLkbeVpGNrj+FlzOGnta0J5V1S/7fF8BObzY=; b=gYzRZPiLSMdldMaRqGSGkdYT4iiSGdlwQuC4uTAH/U5a/DbG5BYlA1V4ffP/rzr2AMtzTMgmFq9ZQjTEa8jguSp+q2gn0hQdwLtS69GGW2Ts/eGoGr1CahQkE55+y6ReqZiQJ18ivy2eKmfSmaJw/5JBGb2R7gCnwGCrz+Se9d0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (103.16.71.47) by CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Wed, 27 Dec 2017 05:19:05 +0000 Date: Wed, 27 Dec 2017 10:48:46 +0530 From: Pavan Nikhilesh To: Neil Horman , jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, gage.eads@intel.com, liang.j.ma@intel.com Cc: dev@dpdk.org Message-ID: <20171227051845.dxmrfk7mszta4epb@Pavan-LT> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171225191738.17151-1-pbhagavatula@caviumnetworks.com> <20171225191738.17151-4-pbhagavatula@caviumnetworks.com> <20171226141156.GB15284@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171226141156.GB15284@neilslaptop.think-freely.org> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: HK2PR02CA0221.apcprd02.prod.outlook.com (10.171.30.161) To CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09b46a9c-f849-4c82-2dab-08d54ce95b08 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:CY4PR07MB3462; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 3:9XOoVRtoSeqLpvHVUBoRNhG4eUiZbyDuAkBxHVEHcnd/1pdcN8nrSd2QJk62szQPDSHFAAwqd+d5CCqe/tXJNPf8GV9zpZqdRh0pVgVY6h4uBLTS7ntIZ5EJUNON2nx99wTX7HX0/piJkxUI8wxNPuwvnvbkQoldKxmPI9obQ/urtIZC0KneinqNXwMLEtQtBN3fI70cbmXfXwPDYbeEB5ChFW5NPEJsaPJQjKpazjtYW60DDeGLNYlYFjhiabtX; 25:z0kj1HeMXhgvFkUE+yTXRLo+fLKDrwgE+i0N74ANuVgR9CTM7/hIMogU54pMbwgwCf1CuvdRggnbd+EZRM7zGwVZWziNqwM225O0BI/qgyKkElyxTJh9tYPT92jE/s+k3tFI2nGj8dhAZEfNTqV8OZ7P0F8mHxHjMKRA3q3qWjktuitNEsDUX4RFWRPp9sQDbMRCO7VxrNtTBzxZvbR3UI6+fqEhzYVW7sr8Yd/VXjdSdUayWhgQaZZiViQcAcI5y7Jqz1lfDmi/YS479AdKUpxQKBxmio+WZDjealrsPU1wWT6oWxhmMb0RLeP4bKf/+f70dyTNopLrLf4yzZpeJQ==; 31:lT7Vjou2LQRda0vOBxGqYg9Bcn2xl/vq5m+lcpLVPgypufGMejIoGp0XkNES5+OG2wASTwqVyqdF0Q3ZSxX298zBti17n5DAHc8xSzWV9eMmGPZtyWRMtwiXZT+24A7yCHXbrkOBnKbh2CLAMo1Ba2aRzEBpywTlUlKyip9CuZJL3UUYuQsPvHB7pjiHz2KFGkidoyZqz5CqXtAtfTBVljpvcGBJvRfgnBhaoJiDDDY= X-MS-TrafficTypeDiagnostic: CY4PR07MB3462: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 20:+IKf650K8evnGp0RQ1CsEo5b0NBIL4+rFwyRffIOxJp4eVPr0fzQNL5cHwdCb7WxZ+ZIK+A+GJQikLDBuqLbQp2IMeIc3h5QpplrVwWFI9Tim2YU/fUWXjCVQIF+A1QC8aM0+HsaVem4rLxDHDherDfiVXyzHL51E5pZ9XD4+amG0nF9UKoWtc5AlWDS6xVtmYzftY14TaSZXay1AzZBsGhmAqpiRUAlHgLZeqSBPoBDHBp+jwXKwLyb0At3xieg6C860teieudazUjiEIaQ8kCFE/rs0GK4DNF5S3dhkjLbq2skUCyWrb0JkSIxKXwDHNYNG1b1p10OQnL9l63VksUwEat+ge18sxyc10VdCOrIUC/gthHOhnQByRK5QwX/7vUBL4ne4SpjNMAcziaIGnfHkzKqypNuccf5ZMasbB05K/31bxA8L+mubxHK56vZcK44HYFwYo6P8BnoMK5Fk12ImVsLKgZ0Drar7mI+Rkt7MVfhIppU0wAbsE2pW1XDUaLhOuS8qN9uUR9/sMGlNLQbwH4RytPiHPW/iTeCqv9GMfEJZFkgOVTdNpIvKAWjZ4Ip/rB4nRTzzgEEbZeOxyDfsfdME1uwPWFFka1WMdo=; 4:Qg4SsIUbUuqX4GFDhDLLn20k5NWyk1wVFkTg8r9rk2hPFkYqUYcgEgDmxrAN+E/puKVnZcQVwRH3c9jy/X81jXGk5cb8NNAXd2Wa+Wrop+Pj804WqoQx5P3D/c4/4M//bt7WaKnBwwUQOByE9MhIrngFqTMdhOPUyZJSIxqPjFjcLzAPtdcFexDL6UmZJcmlLIVGhJ6SiUG2BYEdexuoFzAJTrqW8DQtplFflS//TYihrwj43h42OGWdjcMBnfie1GYr3/HYHf0kVLT6DYmhtg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(3002001)(10201501046)(3231023)(944501075)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR07MB3462; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR07MB3462; X-Forefront-PRVS: 0534947130 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(376002)(366004)(346002)(39850400004)(189003)(199004)(24454002)(6496006)(53936002)(50466002)(81156014)(47776003)(8676002)(81166006)(16526018)(25786009)(52116002)(33896004)(7736002)(83506002)(93886005)(386003)(66066001)(8936002)(76176011)(6116002)(6246003)(106356001)(16586007)(1076002)(3846002)(23726003)(4326008)(58126008)(68736007)(316002)(33716001)(105586002)(72206003)(2906002)(55016002)(229853002)(478600001)(305945005)(2950100002)(42882006)(6666003)(9686003)(97736004)(5660300001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3462; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3462; 23:l8teBpW50rIcafpdi2gae7L+Xo70QJVpZ6ztsCDYX?= =?us-ascii?Q?IRXheR1Y3SdS1uFWcPLYPjrTQm1sWs77HeTHEy6+OIsqxmOnYuijMhf7Jl8H?= =?us-ascii?Q?VIdA16edf8Da8YhO3BYv8iG0gHNlfW+9R0uRC1hZ1Nb5onb27t5zbCrELet5?= =?us-ascii?Q?JWUYiolgkvsc2RvzVg+dzHQGpk847D1lBhtzMaup7tmdPvhM3XTqjXgdkxtC?= =?us-ascii?Q?xh8AMtAUgSBggF7U/oZ68BvBfFmU3UhOv1YkH47XXZswSNdbB3VyWeOvIFQ5?= =?us-ascii?Q?SGr24M38iulYWF+f0vyWIyz/9xIJ/WjxcvDR4JAvQmxMTGKd+pxuRDlO4B2M?= =?us-ascii?Q?CqNqDXpd4/+r9knTkG88HlA5PxJXr+6xZokL3Hz5Pwh4cuSbMEf/lpv8F/yW?= =?us-ascii?Q?cf+/+BNIOjKX2bPTxp/qZu1GvXNmEFShEM6vyaAnrVnSQfi8eWw89VjjdHsZ?= =?us-ascii?Q?pWc4TSKWWM8tQJlhuPY7GsJHH3IgJoFbz+F4qB6O5i28lCBDmwku+qQIlaWH?= =?us-ascii?Q?jO87HRodlXsB9VpCPBeNSFjJya3ZkO+y1m1y2gAGxzEA1VJn+9030rGKesMD?= =?us-ascii?Q?M5aqFoSyUN6N/VtrTwBtNCEgEt1f2Xq7jpJEx1mQeBbnpebd3ZAg5DjXbvJP?= =?us-ascii?Q?h07cGwG+w8dLMKS/xpXiRGLz32QgZDT2Xf7BGv5ysClIhreDcgOFhJNKr0RY?= =?us-ascii?Q?ejtAkxLPwZY1NaPJYjwvA8fvoEXLjNA+PFvenjgsqO9KWav8nAZvNZMEpEZm?= =?us-ascii?Q?KPaLcg+OET/32Mbb9U1csQpZJ1e4KWdFvNYZg1AGNC7W9K9BUIKwZIlq4UOo?= =?us-ascii?Q?kfFTEqEJZj/kfFSnsbsAq2D5kyvxHRbKhXNffOt9wZEUuZGV5OZcO9dloLQc?= =?us-ascii?Q?mKNtI/7xqZRf5EqX46IhaxbViuouONH2jMUvdOgpJyIoaPF2uWLUQQn/lp58?= =?us-ascii?Q?fCi/EIGj6Jqw0X7lNJDhoLc802C2Hf7cYwQr8YhESaR3swhT1aq3uUXhcC5V?= =?us-ascii?Q?0ABGpmSKyBtoWFqYivHSKSEbAmj3A1yQKD2xzXsGFZSD41XEfj/ohC54XdBu?= =?us-ascii?Q?WNKJMCOt0CbgY8Y1f1o78xhe+ZirAA/Fg8CLw31x2cZJPywlw25P1o5LDjZ4?= =?us-ascii?Q?wCTfKnp7EgJ7Qv81zRYc+KDtHuiogM8YVH5V0fiLAesDSdjTTQcwivCeIJob?= =?us-ascii?Q?Xi5JpWKI13OQNo0QJb8ijGSH7nsu41MueElyS9qjFq/UociyNxUvJOiL8s3X?= =?us-ascii?Q?9+cseujImeHmAZj0fQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 6:+26UugWD2Uoe3ux1kxxMaVLQhnMP46PNplXyAFLwaetELg0PDowS69yvx7MxWlUMmUQKzTqa/F4Dzesydh2dlicjA0n03I9FUGawOvXCVlt+8kSAvYWxeXrLo/KqWl/uq3RSzS77aHlPufAFCS4sxeJnKD7juma0MdzO6P5C+lyb7LKrgtQaijkCytnZ/wSLDvl9j7mFElIA7dWB7SgUYrVQmh1qvdA0/0CdTttlnGtWFEA/vmUvKDGJqn9DjPEysiLjzLGiqmr7+IDYf5YtAVQv/3wN5pfFOi+/k2hJlQjp7dzvoizGD5g31rz7hVXopP7n9sNYOFUrpD93HP5tGfkOmUr6xnh/nCTtkaa5nYY=; 5:S2+BPk20kgmUJcq6512CqOmc4FN5bVQN02+SHdcHhMmZU2R3GmOUz2sC2wYdOuYPN4TOjeJSSrlhFnT21SIvnicaG0xGd3gnUWWEn9JlPKOD/TbSPIbSdp2dGii4gOqEKcZtVQEFRW3CeOANt7iNog78/+HJzqntcC+vfSTk6Ro=; 24:lZ3sWXGPlTkALhl27TiC74jNnv4obkfyX2iJHBWy5aykHYKPQwQ2zEUNpy2JtKNy7leA4KxAhNPEjbuy7O2T6kWDZr9j3xJp7bSvQe3I+Lg=; 7:kUpdM/0Y4H+IHtDwXuahR+WbINTujRH8uHBIZiVYST0cv3V4GnLrOCa2t5c9aZQM6DhJ7jmlsQpVqNV3FB9ScM79pC2HjQpYIF2pHjHYVHkuAKP0+z6Kw5Wgj4uMN5LD9q6HPQ0veVUgqF6FWZkVPRp1u3hboMyNZlS3efirKyi1VVKsI57ZzRa/0J+dooIUSpILrHuvyYN3yWw9kFJTV55i4Y1eNpRxClZcBvXu8k7+3SL32PSqYOTPpC9jKohn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2017 05:19:05.7552 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09b46a9c-f849-4c82-2dab-08d54ce95b08 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3462 Subject: Re: [dpdk-dev] [PATCH v3 04/11] event/octeontx: modify octeontx eventdev test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 05:19:10 -0000 Hi Neil, On Tue, Dec 26, 2017 at 09:11:56AM -0500, Neil Horman wrote: > On Tue, Dec 26, 2017 at 12:47:31AM +0530, Pavan Nikhilesh wrote: > > Modify test_eventdev_octeontx to be standalone selftest independent of > > test framework. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/event/octeontx/octeontx_evdev_selftest.c | 427 +++++++++++++---------- > > 1 file changed, 234 insertions(+), 193 deletions(-) > > > > > > static void > > @@ -177,31 +187,34 @@ _eventdev_setup(int mode) > > 512, /* Use very small mbufs */ > > rte_socket_id()); > > if (!eventdev_test_mempool) { > > - printf("ERROR creating mempool\n"); > > - return TEST_FAILED; > > + ssovf_log_dbg("ERROR creating mempool"); > > + return -1; > > } > > > > ret = rte_event_dev_info_get(evdev, &info); > > - TEST_ASSERT_SUCCESS(ret, "Failed to get event dev info"); > > - TEST_ASSERT(info.max_num_events >= (int32_t)MAX_EVENTS, > > - "max_num_events=%d < max_events=%d", > > - info.max_num_events, MAX_EVENTS); > > + RTE_TEST_ASSERT_SUCCESS(ret, "Failed to get event dev info"); > > + if (!(info.max_num_events >= (int32_t)MAX_EVENTS)) { > > + ssovf_log_dbg("ERROR max_num_events=%d < max_events=%d", > > + info.max_num_events, MAX_EVENTS); > > + return -1; > > + } > > > I'm not sure how any of this is particularly adventageous. You've replaced two > ASSERTION macros with one and an additional conditional. The assert macros are > just a flexible as their were previously (which is to say, not overly so). So > i'm not sure what the advantage of renaming them is. This is an unintended artifact while deciding between removing macros and moving them to rte_test, I will clean it up in the next version. Thanks for pointing it out. Pavan > > Neil >