From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yliu@fridaylinux.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 25DF31B293
 for <dev@dpdk.org>; Wed, 27 Dec 2017 15:39:14 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B8CE120BF7;
 Wed, 27 Dec 2017 09:39:13 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 27 Dec 2017 09:39:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org;
 h=cc:content-type:date:from:in-reply-to:message-id:mime-version
 :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; bh=OaeHIzVmSxtbBfdNC7Mj79mFn7nwuH2S2iYdrl1jyok=; b=RZPmsnBC
 Y3WfGV+KAfLTi5WMOT1NJLIH06HkidTScwd7FWl6i5J2I94+m3O8lncmxKV4k4Uy
 vAw/Z9pSE4L95kUcjUyHyTJ4GcyWQPK2pbloYQD5HDq4nLi6TQqBBNCryQ7jWrwW
 PsO3CW2CNz3VnX2UiAOthdfG+Ns2r/eGIwGvbrBcIVXyjJdNfsuAbsi+9sec/+mD
 dNL9fdmRyY99ChzzKsgSkcd/XOKXHW0bVBWwLhHcNDywtHNC29CO5a6AGY4pRHgi
 zd/G/6ljRtN2QfeUZGkH2eQhdnuTTIEp8kIzjSOZii4b2MHse50uVmLs5dL4fD+m
 nLeRgLUlWqMk+w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm1; bh=OaeHIzVmSxtbBfdNC7Mj79mFn7nwu
 H2S2iYdrl1jyok=; b=bh3SVxQQhEnaiBU2n2+0yYVGeiat1eCYCBIzZlACNvg8I
 sY6u4IH3uIjBtUuFDnsYlC9pBwoO6cE0sWpr1QJ2/VYm4dsdu90W8oANLoYELY+f
 9AFtpGWSJ4d0kPP2Bryjb1LocZzeCrS+Ut4WhWpuEzq9cn58L6+CpIHNQvfQlOs3
 H5kcnfC/1YG1HxCaEmaXEYzSAtKotatgqmZ9kbUGiO1v3I+BH6PPuqA0kgPiW3KV
 SYEx1R5smtUChG/UijsmyImj9b0ZKYTMou9VepJ2csdB+ZL7Rlw4gGaAYMr7viGk
 XhaCroDsdEh8WxIyzpt7FqBbxclmiRamcobQKB6iA==
X-ME-Sender: <xms:kbBDWgnGBo0vgy8Zp9WPmPTAhgN1fR3bK5GA0N-aZfNKd353Il5R7Q>
Received: from yliu-mob (unknown [115.150.27.225])
 by mail.messagingengine.com (Postfix) with ESMTPA id B1A1D24707;
 Wed, 27 Dec 2017 09:39:12 -0500 (EST)
Date: Wed, 27 Dec 2017 22:39:10 +0800
From: Yuanhan Liu <yliu@fridaylinux.org>
To: "Yao, Lei A" <lei.a.yao@intel.com>
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>
Message-ID: <20171227143910.GJ8818@yliu-mob>
References: <1511846913-72414-1-git-send-email-jiayu.hu@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A30617A@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A30617A@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Dec 2017 14:39:14 -0000

On Mon, Dec 25, 2017 at 01:53:29AM +0000, Yao, Lei A wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu
> > Sent: Tuesday, November 28, 2017 1:29 PM
> > To: dev@dpdk.org
> > Cc: yliu@fridaylinux.org; Tan, Jianfeng <jianfeng.tan@intel.com>; Hu, Jiayu
> > <jiayu.hu@intel.com>
> > Subject: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload
> > 
> > In virtio, Generic Segmentation Offload (GSO) is the feature for the
> > backend, which means the backend can receive packets with any GSO
> > type.
> > 
> > Virtio-net enables the GSO feature by default, and vhost-net supports it.
> > To make live migration from vhost-net to vhost-user possible, this patch
> > enables GSO for vhost-user.
> > 
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> Tested-by: Lei Yao<lei.a.yao@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu

> This patch has been tested on my server, after add csum=on, gso=on to qemu cmdline,
> Following offload are active in vm:
> udp-fragmentation-offload: on
> tx-tcp-segmentation: on
>  tx-tcp-ecn-segmentation: on
>  tx-tcp6-segmentation: on
> 
> > ---
> >  lib/librte_vhost/vhost.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> > index 1cc81c1..04f54cb 100644
> > --- a/lib/librte_vhost/vhost.h
> > +++ b/lib/librte_vhost/vhost.h
> > @@ -204,6 +204,7 @@ struct vhost_msg {
> >  				(1ULL << VIRTIO_F_VERSION_1)   | \
> >  				(1ULL << VHOST_F_LOG_ALL)      | \
> >  				(1ULL <<
> > VHOST_USER_F_PROTOCOL_FEATURES) | \
> > +				(1ULL << VIRTIO_NET_F_GSO) | \
> >  				(1ULL << VIRTIO_NET_F_HOST_TSO4) | \
> >  				(1ULL << VIRTIO_NET_F_HOST_TSO6) | \
> >  				(1ULL << VIRTIO_NET_F_CSUM)    | \
> > --
> > 2.7.4