From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8AE7B160; Fri, 29 Dec 2017 08:55:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Dec 2017 23:55:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,474,1508828400"; d="scan'208";a="162550739" Received: from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.198]) by orsmga004.jf.intel.com with ESMTP; 28 Dec 2017 23:55:15 -0800 From: Zhiyong Yang To: dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net, stable@dpdk.org, Zhiyong Yang Date: Fri, 29 Dec 2017 15:55:11 +0800 Message-Id: <20171229075511.33180-1-zhiyong.yang@intel.com> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20171228061210.64767-1-zhiyong.yang@intel.com> References: <20171228061210.64767-1-zhiyong.yang@intel.com> Subject: [dpdk-dev] [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 07:55:35 -0000 For virtio legacy device, testpmd startup fails when using uio_pci_generic. The issue is caused by invoking the function pci_ioport_map. The right intr_handle.type is already set before calling it, we should avoid overwriting the default value "RTE_ INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to other cases since it already is set to this value (0) at init. Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") Cc: stable@dpdk.org Signed-off-by: Zhiyong Yang --- Changes in V2: 1. reword the commit log. 2. remove the assignment operation which causes the issue. drivers/bus/pci/linux/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c index 5da6728fb..ec31216bc 100644 --- a/drivers/bus/pci/linux/pci.c +++ b/drivers/bus/pci/linux/pci.c @@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused, if (!found) return -1; - dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; p->base = start; RTE_LOG(DEBUG, EAL, "PCI Port IO found start=0x%x\n", start); -- 2.13.3