From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AD749239 for ; Mon, 15 Oct 2018 11:12:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B33EC219E6; Mon, 15 Oct 2018 05:12:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 05:12:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5cEKA93M7WcidBWPcoXHqSW7Pb4MWrRpbEGdea24UHY=; b=B1yp3nUz+efe TtMQLO1ch8IEgFk1lsyMwDW7dFMU+8qToc+pQuC17qn5ICaN0kzdBUsyX7bHolNR DdlxTOO0yE7Sh5+4hXiBeSQS2iVXlum9toPpcg3aXvS4Oc/bljdsUE2arjJlRxG+ Ibz/WG0MeSq7p0JiaJDxR0ELCKXAR1E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=5cEKA93M7WcidBWPcoXHqSW7Pb4MWrRpbEGdea24U HY=; b=Ry63eEO3CsIUhtOqwmlOxVXHNOQkm7LlFbxRZFkvhcmnEwhcP4Wg9fnHN vbsG1R1Qv4AJD00QiNxyL4NHRfVOhHEK6T7LMJiEmwgDhwHz4H67WbZgA28GngBF ipEG8Za5Pu4DVOSIExZndK5KI/0xyvcyjyIX2rfVeOVj+EzQHyihRCGs1l5sk2Ok jKazYPxIYRSJ+H9hRjZmWijOnNHeUDhvbNUey3g5+VIf94rEIvyKBWEzCKaMqm6e 9HOyFv8sgnTtxMmQdMZLpV1T5lyUhP2DXMkB4iBGEATsCr93Hqdt4oOMODw77SVC S3t8BKxrweIez40tiDgVaX8bZpWOA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B4535E43AC; Mon, 15 Oct 2018 05:12:03 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, anatoly.burakov@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com Date: Mon, 15 Oct 2018 11:12:04 +0200 Message-ID: <2017914.N0vOHbfrR3@xps> In-Reply-To: <1538635483-92222-4-git-send-email-jia.guo@intel.com> References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1538635483-92222-1-git-send-email-jia.guo@intel.com> <1538635483-92222-4-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/4] pci: add req handler field to generic pci device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 09:12:09 -0000 04/10/2018 08:44, Jeff Guo: > There are some extended interrupt types in vfio pci device except from the > existing interrupts, such as err and req notifier, they could be useful for > device error monitoring. And these corresponding interrupt handler is > different from the other interrupt handler that register in PMDs, so a new > interrupt handler should be added. This patch will add specific req handler > in generic pci device. > > Signed-off-by: Jeff Guo > --- a/drivers/bus/pci/rte_bus_pci.h > +++ b/drivers/bus/pci/rte_bus_pci.h > @@ -66,6 +66,7 @@ struct rte_pci_device { > uint16_t max_vfs; /**< sriov enable if not zero */ > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > char name[PCI_PRI_STR_SIZE+1]; /**< PCI location (ASCII) */ > + struct rte_intr_handle req_notifier_handler;/**< Req notifier handle */ We had intr_handle, should we name this one req_notifier_handle? May we improve the comment to better explain? (and add a space before) Maybe we need to update the comment of the other handle? struct rte_intr_handle intr_handle; /**< Interrupt handle */