DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
@ 2017-11-23  1:26 Yanglong Wu
  2017-11-23  1:57 ` Yang, Zhiyong
  2017-12-22  6:45 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
  0 siblings, 2 replies; 11+ messages in thread
From: Yanglong Wu @ 2017-11-23  1:26 UTC (permalink / raw)
  To: dev; +Cc: Yanglong Wu

the port_id was allocated as a inccrete number,
for init function was passthroughed a wrong
size of parameter

Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
  2017-11-23  1:26 [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue Yanglong Wu
@ 2017-11-23  1:57 ` Yang, Zhiyong
  2017-11-23  2:05   ` Yang, Zhiyong
  2017-12-22  6:45 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
  1 sibling, 1 reply; 11+ messages in thread
From: Yang, Zhiyong @ 2017-11-23  1:57 UTC (permalink / raw)
  To: Wu, Yanglong, dev; +Cc: Wu, Yanglong

Hi Yanglong,

Good catch!  Thanks for your patch.

Thanks
Zhiyong
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, November 23, 2017 9:27 AM
> To: dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> 
> the port_id was allocated as a inccrete number, for init function was
> passthroughed a wrong size of parameter

The commit log is not clear enough.

> 
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f71d96301..8990ebf6b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
>  			      tp_id, UINT16);
>  cmdline_parse_token_num_t cmd_vlan_tpid_portid =
>  	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> -			      port_id, UINT8);
> +			      port_id, UINT16);
> 
>  cmdline_parse_inst_t cmd_vlan_tpid = {
>  	.f = cmd_vlan_tpid_parsed,
> --
> 2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
  2017-11-23  1:57 ` Yang, Zhiyong
@ 2017-11-23  2:05   ` Yang, Zhiyong
  0 siblings, 0 replies; 11+ messages in thread
From: Yang, Zhiyong @ 2017-11-23  2:05 UTC (permalink / raw)
  To: dev; +Cc: Wu, Yanglong



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong
> Sent: Thursday, November 23, 2017 9:57 AM
> To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> 
> Hi Yanglong,
> 
> Good catch!  Thanks for your patch.
> 
> Thanks
> Zhiyong
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> > Sent: Thursday, November 23, 2017 9:27 AM
> > To: dev@dpdk.org
> > Cc: Wu, Yanglong <yanglong.wu@intel.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> >
> > the port_id was allocated as a inccrete number, for init function was
> > passthroughed a wrong size of parameter
> 
> The commit log is not clear enough.
> 

Except that,  you can add
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>

> >
> > Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> >
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > ---
> >  app/test-pmd/cmdline.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > f71d96301..8990ebf6b 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
> >  			      tp_id, UINT16);
> >  cmdline_parse_token_num_t cmd_vlan_tpid_portid =
> >  	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> > -			      port_id, UINT8);
> > +			      port_id, UINT16);
> >
> >  cmdline_parse_inst_t cmd_vlan_tpid = {
> >  	.f = cmd_vlan_tpid_parsed,
> > --
> > 2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH v2] app/testpmd: fix port_id alloction issue
  2017-11-23  1:26 [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue Yanglong Wu
  2017-11-23  1:57 ` Yang, Zhiyong
@ 2017-12-22  6:45 ` Yanglong Wu
  2017-12-22  7:48   ` Yanglong Wu
  1 sibling, 1 reply; 11+ messages in thread
From: Yanglong Wu @ 2017-12-22  6:45 UTC (permalink / raw)
  To: dev; +Cc: zhiyong.yang, Yanglong Wu

In the feature of increasing port_id range from 8 bits to 16 bits,
vlan port_id allocation function was forget to substitute UINT8 with
UINT16, so the vlan port_id was allocated as a invalid number.

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
modified commit message
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH v2] app/testpmd: fix port_id alloction issue
  2017-12-22  6:45 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
@ 2017-12-22  7:48   ` Yanglong Wu
  2017-12-23  0:04     ` Ferruh Yigit
  2018-01-02  5:35     ` [dpdk-dev] [PATCH v3] " Yanglong Wu
  0 siblings, 2 replies; 11+ messages in thread
From: Yanglong Wu @ 2017-12-22  7:48 UTC (permalink / raw)
  To: dev; +Cc: zhiyong.yang, Yanglong Wu

In the feature of increasing port_id range from 8 bits to 16 bits,
vlan port_id allocation function was forget to substitute UINT8 with
UINT16, so the vlan port_id was allocated as a inccrete number.

Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
modified commit message
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix port_id alloction issue
  2017-12-22  7:48   ` Yanglong Wu
@ 2017-12-23  0:04     ` Ferruh Yigit
  2018-01-02  5:35     ` [dpdk-dev] [PATCH v3] " Yanglong Wu
  1 sibling, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2017-12-23  0:04 UTC (permalink / raw)
  To: Yanglong Wu, dev; +Cc: zhiyong.yang

On 12/21/2017 11:48 PM, Yanglong Wu wrote:
> In the feature of increasing port_id range from 8 bits to 16 bits,
> vlan port_id allocation function was forget to substitute UINT8 with
> UINT16, so the vlan port_id was allocated as a inccrete number.
> 
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>

Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>

(carrying existing review tag)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
  2017-12-22  7:48   ` Yanglong Wu
  2017-12-23  0:04     ` Ferruh Yigit
@ 2018-01-02  5:35     ` Yanglong Wu
  2018-01-05  0:58       ` Lu, Wenzhuo
  1 sibling, 1 reply; 11+ messages in thread
From: Yanglong Wu @ 2018-01-02  5:35 UTC (permalink / raw)
  To: dev; +Cc: zhiyong.yang, Yanglong Wu

In the feature of increasing port_id range from 8 bits to 16 bits,
vlan port_id allocation function was forget to substitute UINT8 with
UINT16, so the vlan port_id was allocated as a inccrete number.

Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
v2:
modified commit message
---
v3:
add review tag
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
  2018-01-02  5:35     ` [dpdk-dev] [PATCH v3] " Yanglong Wu
@ 2018-01-05  0:58       ` Lu, Wenzhuo
  2018-01-09 23:27         ` Thomas Monjalon
  0 siblings, 1 reply; 11+ messages in thread
From: Lu, Wenzhuo @ 2018-01-05  0:58 UTC (permalink / raw)
  To: Wu, Yanglong, dev; +Cc: Yang, Zhiyong, Wu, Yanglong

Hi,


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Tuesday, January 2, 2018 1:36 PM
> To: dev@dpdk.org
> Cc: Yang, Zhiyong <zhiyong.yang@intel.com>; Wu, Yanglong
> <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
> 
> In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id
> allocation function was forget to substitute UINT8 with UINT16, so the vlan
> port_id was allocated as a inccrete number.
> 
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
  2018-01-05  0:58       ` Lu, Wenzhuo
@ 2018-01-09 23:27         ` Thomas Monjalon
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2018-01-09 23:27 UTC (permalink / raw)
  To: Wu, Yanglong; +Cc: dev, Lu, Wenzhuo, Yang, Zhiyong, stable

> > In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id
> > allocation function was forget to substitute UINT8 with UINT16, so the vlan
> > port_id was allocated as a inccrete number.
> > 
> > Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Cc: stable@dpdk.org

> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
  2018-02-05  7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu
@ 2018-02-05  8:00   ` Yang, Zhiyong
  0 siblings, 0 replies; 11+ messages in thread
From: Yang, Zhiyong @ 2018-02-05  8:00 UTC (permalink / raw)
  To: Wu, Yanglong, dev; +Cc: shahafs, Lu, Wenzhuo, Wu, Yanglong

It seems that the patch has been applied by Thomas. Please check mail list.

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Monday, February 5, 2018 3:53 PM
> To: dev@dpdk.org
> Cc: shahafs@mellanox.com; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu,
> Yanglong <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
> 
> In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id
> allocation function was forget to substitute UINT8 with UINT16, so the vlan
> port_id was allocated as a inccrete number.
> 
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
  2018-02-05  2:33 [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail Yanglong Wu
@ 2018-02-05  7:53 ` Yanglong Wu
  2018-02-05  8:00   ` Yang, Zhiyong
  0 siblings, 1 reply; 11+ messages in thread
From: Yanglong Wu @ 2018-02-05  7:53 UTC (permalink / raw)
  To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu

In the feature of increasing port_id range from 8 bits to 16 bits,
vlan port_id allocation function was forget to substitute UINT8 with
UINT16, so the vlan port_id was allocated as a inccrete number.

Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
v2:
modified commit message
---
v3:
add review tag
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-02-05  8:00 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-23  1:26 [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue Yanglong Wu
2017-11-23  1:57 ` Yang, Zhiyong
2017-11-23  2:05   ` Yang, Zhiyong
2017-12-22  6:45 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2017-12-22  7:48   ` Yanglong Wu
2017-12-23  0:04     ` Ferruh Yigit
2018-01-02  5:35     ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2018-01-05  0:58       ` Lu, Wenzhuo
2018-01-09 23:27         ` Thomas Monjalon
2018-02-05  2:33 [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail Yanglong Wu
2018-02-05  7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu
2018-02-05  8:00   ` Yang, Zhiyong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).