From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7388D7D30 for ; Tue, 2 Jan 2018 12:26:07 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 03:26:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,496,1508828400"; d="scan'208";a="7227677" Received: from jdonoghu-mobl.ger.corp.intel.com ([10.252.21.32]) by orsmga007.jf.intel.com with SMTP; 02 Jan 2018 03:26:02 -0800 Received: by (sSMTP sendmail emulation); Tue, 02 Jan 2018 11:26:01 +0000 Date: Tue, 2 Jan 2018 11:26:01 +0000 From: Bruce Richardson To: Jiayu Hu Cc: dev@dpdk.org, jianfeng.tan@intel.com, junjie.j.chen@intel.com, konstantin.ananyev@intel.com, stephen@networkplumber.org, ferruh.yigit@intel.com, lei.a.yao@intel.com Message-ID: <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com> References: <1513219779-100115-1-git-send-email-jiayu.hu@intel.com> <1513927544-97241-1-git-send-email-jiayu.hu@intel.com> <1513927544-97241-2-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513927544-97241-2-git-send-email-jiayu.hu@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jan 2018 11:26:07 -0000 On Fri, Dec 22, 2017 at 03:25:43PM +0800, Jiayu Hu wrote: > - Remove needless check and variants > - For better understanding, update the programmer guide and rename > internal functions and variants > - For supporting tunneled gro, move common internal functions from > gro_tcp4.c to gro_tcp4.h > - Comply RFC 6864 to process the IPv4 ID field > > Signed-off-by: Jiayu Hu > --- > .../prog_guide/generic_receive_offload_lib.rst | 246 ++++++++------- > doc/guides/prog_guide/img/gro-key-algorithm.png | Bin 0 -> 28231 bytes Rather than binary PNG images, please use SVG files (note, real SVG, not an SVG file with a binary blob pasted into it). Thanks, /Bruce