From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 980DE1B1E4 for ; Wed, 3 Jan 2018 16:22:00 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id 81so796026pgf.6 for ; Wed, 03 Jan 2018 07:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bE36OiBS6Irz1LhbKgAIsr4DpbYBs6LZ77Joo44OuNk=; b=nxzXWydNFG9UEinsUfBbC2hwRsiNVVkNKPVmIWzYPkx/gN5E9DZFiMTk7qPGE3wpjV ZgLtgShdK1+WEjfJbenRCe+FIw9UVNRRKES8TPFovpLAq+qGobewEGp2tN0tpdGklZwK 5YKJaOhMbd/X14Q1PwP5ZGbrgbIhUjJpoHlWhW2OlZ/IGZFB/6Rj+g3i7cdAKPvysLJs 55qaga7dDX2iMcjz7AlPygXhK3gz9UDI7+aitu8HyIlDnf06g20gksflRZOIeamm3Ii2 ff+LGlscJFbemo9AQow4FHKNF0tTh2d5FwsxYkXMYaEtO4HP4v9OnvXiOVDI6NtKj80y NBbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bE36OiBS6Irz1LhbKgAIsr4DpbYBs6LZ77Joo44OuNk=; b=Vu0rLKPDYLYlae3zTYuCekzIP7Sb2GFHlwI7q/zawqczUdoOSf2J9ZSqiff82VOoL0 n5OyKAvrgthtPxPMVso86eVUUFzWex6Ms6cAA603hwBRDk0PWudHBxB0Tc3JeEDVv0Iy VtsDZn/fro1fV69kccnz6JwQWvwHC55rsXRKJhRhNaMdyWkWvHfRQkOfCyUIM16Caj7r i+60X83QkfZ1Jqh6ubeLG8SFvV8AGTSpQ2gYXIaSdIHlqW90cdCFu09g5PxhFIv+sIlc RKeirCar9pLiZ4rmj+aQkOSNpSeUoqRHp4GsBjOcmXMLfl/2QWrLhwIUNJJC9SL5rtZ6 A8Tw== X-Gm-Message-State: AKGB3mJLRwlhyRQJBfV2Sku81uEIf+mkevFYjdK4YpoVxlJvdumrwmwo LPpo6etUvEVXk30/1uogvwyKdw== X-Google-Smtp-Source: ACJfBosBPeVP72I6Ro3cFtb8Ah+siTlo+fV1b2bmRAgsDYXwgSU9sWfe3SzQxO6GB5jFt82QaeHRog== X-Received: by 10.98.138.149 with SMTP id o21mr1744683pfk.225.1514992919674; Wed, 03 Jan 2018 07:21:59 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id t4sm3983980pfj.56.2018.01.03.07.21.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jan 2018 07:21:59 -0800 (PST) Date: Wed, 3 Jan 2018 07:21:58 -0800 From: Stephen Hemminger To: Nelio Laranjeiro Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180103072158.4084e5d3@xeon-e3> In-Reply-To: <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com> References: <20180102205310.3586-1-stephen@networkplumber.org> <20180102205310.3586-2-stephen@networkplumber.org> <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 15:22:00 -0000 On Wed, 3 Jan 2018 08:35:23 +0100 Nelio Laranjeiro wrote: > Hi Stephen, > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > Since wait_to_complete is unused, don't pass it to helper functions. > > Use the standard RTE macro to indicate this is an unused parameter. > > I would suggest to use the (void) as it is done in the whole driver, a > specific patch should be done to use the rte_unused macro in all the > sources at once. > > Thanks, > There is a standard in DPDK using RTE macros. The whole driver should follow that rather than trying to be different.