From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id BF90B1B022 for ; Wed, 3 Jan 2018 08:36:10 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id f140so1066778wmd.2 for ; Tue, 02 Jan 2018 23:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=dflMF3l8FbolE1ZIlDBR8uidko4oz9szVDZMCBuKRuA=; b=mhF0n+zraRj9MR/gQ9xNsAe/eSuTUoLpRzyzYoJMUCCUoUljNhQA/gNh57Ouu0KBKG +J4fn50fRNbBiVp+S+VlG2PgTVeXuSKdSQ2toztgzhtS9u/mHYdf3hG4emuDRqfc5lCv 3BypixoRyYhcUjM8j/Azh2uSAZ6rIahrgIlOO2SPyhS8QtrbQYZw+3KdsC4sdX+S6kX+ HXj7ixZgkslp223v0FhNMc5ZZfdTIhFYve1vMIbiO/30nuNecHESfTy8VFkDrlj+hZ1e f0EMOa62nOoJK/RmvuMdFoACZDY/tON/oCcVGHx2e+Om5jS6+kCvJ9OuzvtsAkhCafUB zTeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=dflMF3l8FbolE1ZIlDBR8uidko4oz9szVDZMCBuKRuA=; b=RPqAzudBXupqoKkEAW1e1WcvwPFCh/xoijp4vbYJcXmyKlGO8bDh4sUANsPSclYwQT cn5ubm9HAaPYiczTujiDgxUTM7XPfwBehALDKXkd27drOjG3BR2sCJaTpOkhpFn/RXF9 +BOc0rnsRx+WEaNkz34Bn/Z4PnZ9TwftkI129rsEDGCbcKi3sOHvBzLtBNL30NHImUNe ax9cgn91O90pQ7fLn5lWsV9dDS0QjanYBDObAXKMtnbj5L9shKluYEb5yUMc5K3G3KvO 4HpIOXMAX6DI8nGEIk0kUQew88x7PeBLbirTUyIVUWPrReIVJ7UgiFx/FhQwU6mePcm1 9p8Q== X-Gm-Message-State: AKGB3mKshX/Orig6/psQjv+wEV5IXQLiNiKjJQNVxJoSDuTvUMOEmaj2 7t37rCYltKBRyUyx+t0Ambqw X-Google-Smtp-Source: ACJfBoscCcX2rVlmqUwNAN+2enjELQN3ql0Mqv9TRwFOvOLvlkAcCNVa3y6pNlwO4L4EOIBr/DY6lA== X-Received: by 10.80.186.97 with SMTP id 30mr1402040eds.275.1514964970507; Tue, 02 Jan 2018 23:36:10 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k42sm354184edb.94.2018.01.02.23.36.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 23:36:10 -0800 (PST) Date: Wed, 3 Jan 2018 08:35:23 +0100 From: Nelio Laranjeiro To: Stephen Hemminger Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com> References: <20180102205310.3586-1-stephen@networkplumber.org> <20180102205310.3586-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180102205310.3586-2-stephen@networkplumber.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 07:36:10 -0000 Hi Stephen, On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > Since wait_to_complete is unused, don't pass it to helper functions. > Use the standard RTE macro to indicate this is an unused parameter. I would suggest to use the (void) as it is done in the whole driver, a specific patch should be done to use the rte_unused macro in all the sources at once. Thanks, -- Nélio Laranjeiro 6WIND