From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id B7EF31B1A3 for ; Wed, 3 Jan 2018 09:30:41 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id t8so1251369wmc.3 for ; Wed, 03 Jan 2018 00:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GR3xYxyFM2sQfaOwsEKv5+wBi+a9celpjoAZW7mqoiA=; b=G5vV/lLxB//Jt5ERf7jlm5txtv35BwX21Bb/vez9eNSRzx7Db0b6MietOlysJrGzlc 3fmoQQmv55Bv6o8bc+/D3YtHspYm7oCxW9HeHX6rIGm7Ioe+pDBgtHF1gEKOwWwvFFSE HTe2qO7YB/tAHQzzlNQpwFUsX94vz28RoGQnFNvPMMC3QYgqwGwE4x7tkQPbm5ynYKI7 qCEdXJPVklUrW0EpgoezjGSwTet1Z5aMEaxB3NMeh9ZS+xVQj+05qx6nSkqzO8+4mLXk v10oypBWOyJdyTJyqayMSBV1C4xsilgRAyo4XLTV8O/4bC7QWBLA7KH53FAO9vpgTD09 E7Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GR3xYxyFM2sQfaOwsEKv5+wBi+a9celpjoAZW7mqoiA=; b=a4IFGHMZhtnbf2ek5EG44RTMFuzbo4FGusGtzV7cH8h7f6SGaSePotRntNgDpJLW7t NfUuZkYw7Hdy3xZFg22T2tz5jjvwXP2mLyjUOB6IT4yNp5QwbiQWXh5+DojYaMRZcCDp ppxu6elJn1aTQga3GIR+DaevHD3Ee1vFHmHyRyXHkDyjkbGPQ8EMi01wqObipoMSCw4w ImgOUZmWWUk4NfA66pdBTZn9kb/WXdZX3SBWi3JcTGvYdjUIeSn7Tns8CS4rmc9zpLHh bQIbFFUerjAk318+vd21I6ODk3rD0oABaQ9n/Ypz7ngJhDoqhdAC0vPpzjf6IlodVh4u NsmQ== X-Gm-Message-State: AKGB3mJaYwUCIpmXa1cwMJEadgtvEvtC3fZeS+IEbIiAgEXc7gQr4wG7 DsCHU2joJHZQ50J/vQyEui2v X-Google-Smtp-Source: ACJfBosuygZPftBHTH6kHPvbvOZZxJPemnem1pRA5CuKD8E0xead5CfbjE4e53ANz6u1L3n5p0jQFw== X-Received: by 10.80.142.17 with SMTP id 17mr1649729edw.147.1514968241446; Wed, 03 Jan 2018 00:30:41 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y3sm495792edb.37.2018.01.03.00.30.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jan 2018 00:30:41 -0800 (PST) Date: Wed, 3 Jan 2018 09:29:54 +0100 From: Nelio Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180103082954.jit4h7ioblhnm5fq@laranjeiro-vm.dev.6wind.com> References: <20180103080622.2063-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180103080622.2063-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 08:30:41 -0000 On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote: > Checking HW checksum offload flag for outer IP is missing. If flag is set > for only outer IP, this can't be set properly. > > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh > Acked-by: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_rxtx.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index e70d52361..90f129168 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -636,7 +636,8 @@ txq_ol_cksum_to_cs(struct mlx5_txq_data *txq_data, struct rte_mbuf *buf) > > /* Should we enable HW CKSUM offload */ > if (buf->ol_flags & > - (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) { > + (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM | > + PKT_TX_OUTER_IP_CKSUM)) { > if (txq_data->tunnel_en && > (buf->ol_flags & > (PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN))) { > -- > 2.11.0 > -- Nélio Laranjeiro 6WIND