From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id EEF011B1B8 for ; Wed, 3 Jan 2018 11:26:40 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id w68so1036256wrc.10 for ; Wed, 03 Jan 2018 02:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OXvTWDOuiOjNc4rOWnqRzAYSDGAhGlAK42dipEDW3L8=; b=PPvSfmNk5GjxuEdKecoGSJioGrYLbKe2UtpOs9Jr8aeoocbapgF4bvc1buN3ZJn1a2 vCOVHtsGpyN+VDkM431JEdrk/KwTJ7KpU+75FlaViWcKyqjXltnB1B5WwiGv2RLbZRIa jCMYS7nm5ce5vNBgSLnZb67stVI2qCkzOr4bLkVpWZnHSrbSrmDTaSP6zLcnLyR2RsDg JhkscZUisws4yHk0NY71jlw2fyHUurvZ3kPeYNTojjnNuwXCaMHhTtBn3d/PbGDx1kqV xpUtDRcy+iYKzwvyU1g2gtF6ULLHcZfgjnHYYlHg+PQ7LogcUPDfPmQct9dwE+1kMj+M RMBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OXvTWDOuiOjNc4rOWnqRzAYSDGAhGlAK42dipEDW3L8=; b=kgi9oAZg2gRbJHhoLrcuwVFdeGH7TWQFBiLZZPSZrM0RQIuyARdqTUfRvGelILHbRE 0nD42t1V0xKcWV6BbuMR3Xq+7t7gTasopbofR8v+tBAI/Dg2DEpIJWVEIhMF2+DOng5z Sk/rKKRQQUFYdrRGM/QaJ0/gKl3yKKHJx9+LHH4/ZAHdymJXfdmhDybqviYKyp1+9Umd bVZWasLKrejY8X6Q1wyg9k5wJHV6DbVRYSw2GqLoTIeSNb4c0QgKQIMOUi8SyKlK1szR ACWMFVtjqjhc+eZh9avtrVA/MIQhKxVihAnx09EncH8J11idv53Zs6LbubUJjttSlfit oDpA== X-Gm-Message-State: AKGB3mJMUvkm1jzEEUC3eXbdzUJNXc+w0bKiwWVyvD4Rs6w92FloLIdQ Gb0IacXpBktVqEhEjdylQv23 X-Google-Smtp-Source: ACJfBotHJOPfFXth24eQ3z+wzSR8AUiM8GtlxcLIZ1J+ZWCM0vNKIbVW8F85FelpuiDBOqxLr4j3tg== X-Received: by 10.223.142.40 with SMTP id n37mr993987wrb.255.1514975200501; Wed, 03 Jan 2018 02:26:40 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r64sm1668611wrb.62.2018.01.03.02.26.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jan 2018 02:26:40 -0800 (PST) Date: Wed, 3 Jan 2018 11:25:53 +0100 From: Nelio Laranjeiro To: Stephen Hemminger Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org, Shahaf Shuler Message-ID: <20180103102553.e2pa5qxtxlqwchj2@laranjeiro-vm.dev.6wind.com> References: <20180102205310.3586-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180102205310.3586-1-stephen@networkplumber.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 0/2] mlx5: remove dependency on kernel version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 10:26:41 -0000 On Tue, Jan 02, 2018 at 12:53:08PM -0800, Stephen Hemminger wrote: > Trying to eliminate all runtime calls to look at kernel version > to determine API because they are source of portablity problems > in distributions. > > Stephen Hemminger (2): > mlx5: don't pass unused argument to sub-functions > mlx5: don't depend on kernel version > > drivers/net/mlx5/mlx5_ethdev.c | 118 +++++++++++++++++------------------------ > 1 file changed, 48 insertions(+), 70 deletions(-) > > -- > 2.15.1 Hi Stephen, Thinking about one point, this PMD is able to work on current distribution releases using large version of kernels. This code was handling two points: 1. Compiling against a kernel before v4.5 is possible. As this situation is supported by MLNX_OFED it should remain. 2. Between v4.5 up to v4.9 the new link status API is buggee causing a wrong status. This was the main reason why the kernel version was verified. This series breaks those two requirements, Thanks, -- Nélio Laranjeiro 6WIND