From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 474CF1B1DC;
 Wed,  3 Jan 2018 14:54:26 +0100 (CET)
Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1eWjb4-0007e9-Fz; Wed, 03 Jan 2018 15:00:47 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Wed, 03 Jan 2018 14:54:11 +0100
Date: Wed, 3 Jan 2018 14:54:11 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Ivan Malov <Ivan.Malov@oktetlabs.ru>, Igor Ryzhov <iryzhov@nfware.com>,
 dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 Laurent Hardy <laurent.hardy@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org
Message-ID: <20180103135409.jwltlb45hfhnqwoh@platinum>
References: <20171214171531.10506-1-olivier.matz@6wind.com>
 <adea1787-9c1c-3942-3b9e-ea42a2e44728@solarflare.com>
 <CAF+s_FyBQfevMSaLHH9xOV=+DvTwk70XNcOrtGToumhKvs-kMA@mail.gmail.com>
 <acca024b-f96d-9d37-9f38-f63e5f7317f2@solarflare.com>
 <20171219092932.5k5sg3eemfghatkl@glumotte.dev.6wind.com>
 <b97fc717-99b4-d3e2-04e0-d64ecd47f08f@solarflare.com>
 <dab2e5aa-c3cf-81d4-bd2d-909084e3f9b3@solarflare.com>
 <20180103134358.rc4funbiws5mlimh@platinum>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180103134358.rc4funbiws5mlimh@platinum>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix setting of MAC address
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jan 2018 13:54:26 -0000

On Wed, Jan 03, 2018 at 02:43:59PM +0100, Olivier Matz wrote:
> I've walked through the PMDs as suggested by Andrew, and there was
> indeed some conflicts with the initial patch. I've just submitted the
> patch for vmxnet3 [1] and bnxt [2].
> 
> But there is still an issue with the qede driver, that overwrites the
> MAC address in dev->data by the previous one if it cannot be set. It
> seems it's the only driver that does this in error case, but anyway,
> this behavior will be broken by the initial patch.
> 
> So I submitted a v2 that only changes the behavior for i40evf [3].
> 
> I propose to include these 3 patches for 18.02, and announce an ABI
> change for 18.05 to add a return value to dev_ops->mac_addr_set() and
> move the ether_addr_copy() after the callback, only in case of success.
> 
> Any opinions?
> 
> 
> [1] https://dpdk.org/dev/patchwork/patch/32855/
> [2] https://dpdk.org/dev/patchwork/patch/32855/
> [3] https://dpdk.org/dev/patchwork/patch/32855/

Sorry:

[1] https://dpdk.org/dev/patchwork/patch/32855/
[2] https://dpdk.org/dev/patchwork/patch/32856/
[3] https://dpdk.org/dev/patchwork/patch/32857/