Re: [dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list

[Olivier Matz <olivier.matz@6wind.com>]

On Fri, Dec 29, 2017 at 09:09:25AM -0800, Stephen Hemminger wrote:
> On Tue, 21 Nov 2017 01:42:41 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > To track modification:
> > 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> > 
> > Proposed deadline for PMDs is v18.02
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> >  doc/guides/nics/todo.rst | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> > index 61dd9cbc9..493a49ff2 100644
> > --- a/doc/guides/nics/todo.rst
> > +++ b/doc/guides/nics/todo.rst
> > @@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
> >   |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> >   |                   | | vmxnet3                      |          |                |                                   |
> >   +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> > + | | check new mbuf  | | af_packet, ark, avp, bnx2x,  | v18.02   | 380a7aab1ae2   | mbuf flag PKT_RX_VLAN_PKT renamed |
> > + | | VLAN flag       | | bnxt, bonding, cxgbe, dpaa,  |          |                | to PKT_RX_VLAN and its meaning    |
> > + | | PKT_RX_VLAN     | | dpaa2, e1000, ena, enic,     |          |                | changed, confirm PMD uses new     |
> > + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                | flag correct.                     |
> > + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
> > + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
> > + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> > + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> > + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> > + |                   | | vmxnet3                      |          |                |                                   |
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> 
> 
> NAK
> Fix the other drivers.
> 
> This open source, if you introduce a new behavior it is the responsibility of the person adding
> the new stuff to fix every other driver.

Actually, no new behavior was introduced. The meaning of the vlan flags
has been clarified. The purpose of this note is to ask the maintainers
to ensure that the behavior of the PMDs matches the API. This operation
is not easy to do for someone that does not know the hardware, and
that cannot test it.