From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 7D7EB2904 for ; Thu, 4 Jan 2018 09:52:49 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id g75so2066850wme.0 for ; Thu, 04 Jan 2018 00:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=0hBUZYa8pfiHAXWNWpJKr/E8yn6Oc+hpZtoL0BfDhzw=; b=nHqfeKB+t9jKpV3T6rPqMGO6Ued2Hv/cwqzvL3pKSD7aljNZrLvMHxX51I1qP98Wdp 19zbFhW0Yg6nsHlyodB3sVlKPOVBxQYWuS72F7ZD2Ezb53wCtyxySzmg9Zcwfckc0uob urA72fGTcdDtDsRrrp28b89aBspD8Wl5sWLCooh3NPVB82GpDErTes17W6SzNUiNBbwe Xx9lIHqIvxIhfIu/mGlvx7lfk8W1HQSHL5dqE+Wc8YrBjDriw3Sc8H2pmUtC4Hk+AZBb ML4B8FiwTbElruXHeiYz9QBhxDaBaigR8rc0Q7ci4z+Iiu6pvBJf/KNGThD3DcBjBf9N 1/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=0hBUZYa8pfiHAXWNWpJKr/E8yn6Oc+hpZtoL0BfDhzw=; b=ccHZiJRtxgSTe/XRLP7WrKVpBFJlE0/znLgQdBzP9eyslgo56y1i2SDa/L5MXre2aO 41W1SmgHz/+qCvg5XTVUiZTsy0NM2BKcMzV+bwM0yfzWTG7FXJiAJAAzcMksQ/ptA+Rs Mrg/gvoc2Oe6eECPhI3nT7yGx+TwdOISo8yrobpGLDGD1zztrXQ/K4QklPV2xYqNhwaH /HCX0ozLLmFiEFf7GslnVQi2i+J/tXccmVrhyRyz8ESKoF9RpVN1udGYV238G2dIZefF Q2AACQpD3hfE8vYixAvl35ATCrKugu7tOE2LueVFoG1hobdmaAm4KPPVEYDO/qhJhyVH v+EA== X-Gm-Message-State: AKGB3mJK3LqOf8jHQ/ZIWcdIrdqfbvv7gbgl/++0hh/gcyc9BlGH0FT8 1RIkNZn3x71or2fyRGl8oFWi X-Google-Smtp-Source: ACJfBotSre1b5Z/XMdFODvO6c6ojB6BRFgcoCtYf+VyzK2WhhZsAcx7GQj9Ge2cbTT0EMBOPYAPIBw== X-Received: by 10.80.174.143 with SMTP id e15mr6606101edd.10.1515055969308; Thu, 04 Jan 2018 00:52:49 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d92sm1646607edd.21.2018.01.04.00.52.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jan 2018 00:52:48 -0800 (PST) Date: Thu, 4 Jan 2018 09:52:04 +0100 From: Nelio Laranjeiro To: Stephen Hemminger Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180104085204.qxlkllnmhwhoiwwz@laranjeiro-vm.dev.6wind.com> References: <20180102205310.3586-1-stephen@networkplumber.org> <20180102205310.3586-2-stephen@networkplumber.org> <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com> <20180103072158.4084e5d3@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180103072158.4084e5d3@xeon-e3> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 08:52:49 -0000 On Wed, Jan 03, 2018 at 07:21:58AM -0800, Stephen Hemminger wrote: > On Wed, 3 Jan 2018 08:35:23 +0100 > Nelio Laranjeiro wrote: > > > Hi Stephen, > > > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > > Since wait_to_complete is unused, don't pass it to helper functions. > > > Use the standard RTE macro to indicate this is an unused parameter. > > > > I would suggest to use the (void) as it is done in the whole driver, a > > specific patch should be done to use the rte_unused macro in all the > > sources at once. > > > > Thanks, > > > > There is a standard in DPDK using RTE macros. The whole driver should > follow that rather than trying to be different. The standard was introduced after the driver have been submitted, I agree that a new way is present, but when it was introduced a modification on the whole code though DPDK should have been done to avoid mixed ways. I prefer to have a single commit replacing the (void)foo by __rte_unused, it will also help the backports to the stable branches. Thanks, -- Nélio Laranjeiro 6WIND