From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46]) by dpdk.org (Postfix) with ESMTP id 6EA7E1B010 for ; Fri, 5 Jan 2018 21:19:01 +0100 (CET) Received: by mail-pg0-f46.google.com with SMTP id j4so2391330pgp.1 for ; Fri, 05 Jan 2018 12:19:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=55KYwzHUCH8OQ1eIH5fAuGX+/XejkD8kBuzqovLdc0s=; b=qKvx+falhBawEO1YepAldvPWnY4kHNTsmQA2nozlBUNrgesytRxiEoOlF+M/WgnxHU uNvpQ1bAJ1zFSFR9xuIk8VNenGIyuJqa1u2VIORL60YglN6mEssp5psl0pO6VzrYMW9M d+aTGHlHBkEeuTmJLQB2ZjEBJALzWr7vZhHGJ1WmGnmsEr1vnjKw5u4F/boVTa0SbJeP Ix8bmca5yUgE4xtz44uI5CoES4wRc27kWlH4NNCwHf1OHXqWtiWVB/G8QUWQpojIfrwP TlqnY+oSr4hv2rOl8VSm1BZu/0Tra0UG1hhvSFL32JlLPh3a7/Chek/IJqsawyGrYuKC fXRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=55KYwzHUCH8OQ1eIH5fAuGX+/XejkD8kBuzqovLdc0s=; b=lutZBTB4nXF5jyr9ttjStDcn0xku5+dAlfR6yW5RLTRQ/yWDOlCRL+VyOxFWLCl+6K HoTO14zB6MGXPHuIbZkr4PsNAABdsq5g+4cRjJQHxfIDUL0iWRjU6P8rIPfO3VrIa3A+ +vVbLsgRmUV4FZBZgF58VOYRuaRHxPkf1D1APNqSu+6RAfE+7FiFRJIfPeLEFhEY1RyK vEYT+JPIirIpuX3KNU0mOQAYVoM0pgi+wym4MpIdUVMmIq9ckBz7WcbjeHTOjz4wpKk4 aIpeEkFmGfSPplQS5QCTajiZC9RHrvNDg1wwGN1cWWYzxIal7rlS7Cmn+qVjxpJ6CVhz DeSg== X-Gm-Message-State: AKGB3mIN8d4bbCfa11Jj2rw3SaKkHm/fWanxNaCKI9nH+s55Bm76eqQH 8uNKewB6L3ArsX5zui5dlUGwXA== X-Google-Smtp-Source: ACJfBouJ+pK+gkA9qGPnIGw03Z3wp8U9toaSuYh5BZXDRvK9xk2GZMWO+7Lb5TTrN+9gaz4M5dkTtw== X-Received: by 10.98.76.86 with SMTP id z83mr3951273pfa.170.1515183540560; Fri, 05 Jan 2018 12:19:00 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id d28sm15757069pfb.105.2018.01.05.12.19.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jan 2018 12:19:00 -0800 (PST) Date: Fri, 5 Jan 2018 12:18:58 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, arybchenko@solarflare.com Message-ID: <20180105121858.46b0afc6@xeon-e3> In-Reply-To: <3614502.L0iXJskvX9@xps> References: <20170714183027.16021-1-stephen@networkplumber.org> <3614502.L0iXJskvX9@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 20:19:01 -0000 On Fri, 05 Jan 2018 15:29:09 +0100 Thomas Monjalon wrote: > 14/07/2017 20:30, Stephen Hemminger: > > While writing new driver, I noticed a lot of unnecessary duplication of > > code in drivers for handling the eth_dev link status information. While > > consolidating this, it also became obvious that several drivers have > > bugs in this are because they don't return the correct value. > > Also, some drivers were not fully initializing all the space (including > > padding). > > Good initiative. > Please, could you spin a new version not RFC? > > > This is compile test only at this point, I don't have any of the hardware > > available (except virtio) to test. > > I think we should integrate it in 18.02-rc1 so everybody will be forced > to test it. > Let's change the name then to. rte_eth_linkstatus_set rte_eth_linkstatus_get