From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id DD61E1B00C for ; Fri, 5 Jan 2018 21:32:23 +0100 (CET) Received: by mail-pf0-f193.google.com with SMTP id p84so2630554pfd.3 for ; Fri, 05 Jan 2018 12:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zcFA+zYXuUiDq1fZMdcPyuVQt6ags+GcgSh9ejkxtAQ=; b=kFujXWeRgmHmxYxFSOPkLocFB8uGspOPhmzEYer/vS9A8PDiD9/iBBV4BH/sM5jAAC K2smOrT/z2PJk/R2KwMsg8yS+NpjAi33Tg2qRgM/NxbEZpn//j1IuvtUtZAQx3SZNCMm Dyct3/IvsfJ2LY7MW+Rg4DnYHq8ls1Fn3HYES/Kv3O/jy4gv9ta/n8r/8ihFNo1J10D+ qkqktvJTZV5aqFJzgUvvnblAKQbv1z7sq3E7pYb32DiMiiE9/WbspfABparbQylhqVAT pLEkj/48Ot4fREJTQrFuRRKGKdRjn+6ys07j3AZmYDR+kfRnC2WNWjYx/UTVzFB5G3CJ x//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zcFA+zYXuUiDq1fZMdcPyuVQt6ags+GcgSh9ejkxtAQ=; b=nMrTT+doB69aLFYLysttpiUzGQBCBpIAX0HcOK/YOhkOnPfjuyjkoBi5DtYIBlIHyd wFJJpEUqUQ2DtJ8HHLoF/rmW9aSamTDMWKBEIhVCXPp+642X7PXrvRow3TcxUTAgFEzh ED4vp0K6xQht3bLxPHVOquEkDykC2p6fkaFkbHocb1T295uxpQmHdNbdt8nTmvQn5bUI Z9Zwp7XSWu8NFi4VUs6u/lGVnPaGNBAI2nn5FOCYghJ6l766kAYpJLLyiUuEwCdLlIFy zytGARLnoNht7LJb9em/7Rk+V759dRwehwC7Y6NHwzyjFypLU0sVcRMO38jgOhS1YIpP xEgQ== X-Gm-Message-State: AKGB3mIGHLPIRCqolsilSbKKGTWFmSOhRY9A2t9x9fzSNXtGzTI/9yeo /AGs43NkH0l4QHgSdsoCmXaX5Q== X-Google-Smtp-Source: ACJfBosFVod/cpBpu29ROyco4Dl96Zbv1uHp/p9zb4F72Ez2ODNbuAbeCEBKdV4izrPwxzkw0w1wPw== X-Received: by 10.99.110.78 with SMTP id j75mr2670765pgc.96.1515184342975; Fri, 05 Jan 2018 12:32:22 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id s73sm15729012pfi.167.2018.01.05.12.32.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jan 2018 12:32:22 -0800 (PST) Date: Fri, 5 Jan 2018 12:32:21 -0800 From: Stephen Hemminger To: Ravi Kumar Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20180105123221.375aa4fb@xeon-e3> In-Reply-To: <1515145938-97474-16-git-send-email-Ravi1.kumar@amd.com> References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com> <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com> <1515145938-97474-16-git-send-email-Ravi1.kumar@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 16/16] net/axgbe: add support for build 32-bit mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 20:32:24 -0000 On Fri, 5 Jan 2018 04:52:18 -0500 Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- > doc/guides/nics/features/axgbe.ini | 1 + > drivers/net/axgbe/axgbe_common.h | 49 ++++++++++++++++++++++---------------- > drivers/net/axgbe/axgbe_ethdev.c | 10 ++++---- > drivers/net/axgbe/axgbe_ethdev.h | 8 +++---- > drivers/net/axgbe/axgbe_rxtx.c | 12 +++++----- > drivers/net/axgbe/axgbe_rxtx.h | 4 ++-- > 6 files changed, 48 insertions(+), 36 deletions(-) > > diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini > index 042ff1e..ab4da55 100644 > --- a/doc/guides/nics/features/axgbe.ini > +++ b/doc/guides/nics/features/axgbe.ini > @@ -15,4 +15,5 @@ L3 checksum offload = Y > L4 checksum offload = Y > Basic stats = Y > Linux UIO = Y > +x86-32 = Y > x86-64 = Y > diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h > index 294f2e4..78a055d 100644 > --- a/drivers/net/axgbe/axgbe_common.h > +++ b/drivers/net/axgbe/axgbe_common.h > @@ -1507,7 +1507,7 @@ do { \ > * register definitions formed using the input names > */ > #define AXGMAC_IOREAD(_pdata, _reg) \ > - rte_read32((void *)((_pdata)->xgmac_regs + (_reg))) > + rte_read32((void *)((uint8_t *)((_pdata)->xgmac_regs) + (_reg))) > Since rte_read32 is defined to take void * the cast should not be necessary.. Also in theory _pdata could be const here.