From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f44.google.com (mail-pl0-f44.google.com [209.85.160.44]) by dpdk.org (Postfix) with ESMTP id 029A51B010 for ; Fri, 5 Jan 2018 21:47:10 +0100 (CET) Received: by mail-pl0-f44.google.com with SMTP id n13so3705235plp.11 for ; Fri, 05 Jan 2018 12:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nk7Tr8vlRBWq8wjJMBCDnlffA/ouyUgfc5bJLcsxtsk=; b=fTv6U5yWgv4uwfDa/5d8WlrY8xOLcVl1qbQ3JppoeX8h0zKxi2VjSuFSa06mEyETF4 S3pHPnh5g31mA1GZpagNmepBJwCASMUJT4VLqiJbEwTeGAwxwfFjBQnSwBMsJRYJUxVY yn+yrhtyK06dchCLdxKgXAedtQblxOZzECACNoLlzsKGgmztuhyMYXzfck1chUNGbKEJ rx97OhbqJVI7VMqPTAMkM37y5stKtL/0G6iBBPhSBKUROYjSmWwRPmPiMXYPnW95CNzD N/2pp8sxHnEQ5NigRFw0Kcq6vlBDAHfdx1xj6BRLYFnWR4IyewpUoE7YLwWOg41zRTgV kfsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nk7Tr8vlRBWq8wjJMBCDnlffA/ouyUgfc5bJLcsxtsk=; b=L+eva7+tco5uEm8HzMdRAViHrjwHW7/uzfxMVOETGBcrst+xLYR+1y0m67aBebewul PgkvWv3GLYYOhDu8hrmRXLbWnX3eaM3xw5ffua0D/teWqv0qbJijdDkqWIQPe5bZ/4mx n3cFVHwJbl9ui0jLAWTCfMFdYp+6hyFWmIjD0aS9N0pYwP0JuEZM9PGNPtECBa20bRyJ Wczc0uaR13qNdz8cOVmAwXkTskz2n7n/7UDWCKqE90xF/LWUaz6bY3aKZGb3dCXkFd9K q212wYaoC13cOyxRXoHDoVnbwHPYu/7np1zzCtLCMmw1yMx9bnMfjmbabd6osptVo1zi xAWg== X-Gm-Message-State: AKGB3mKrZsZIAQxiAybMj/meL0bA6UmsEirvo3c/cLUwQS9SqwrhlJy6 gne3hCcuixoBaUuVB75OMeTyWA== X-Google-Smtp-Source: ACJfBotAdy0gBOBvdc1RzcNHF4hCynmWZf0x97IPHM0JFebdTpbMc5uxT8feB8kBzWpwlxUTSTxoDw== X-Received: by 10.84.215.22 with SMTP id k22mr4342812pli.46.1515185230044; Fri, 05 Jan 2018 12:47:10 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id 67sm12218476pgg.50.2018.01.05.12.47.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jan 2018 12:47:09 -0800 (PST) Date: Fri, 5 Jan 2018 12:47:07 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20180105124707.602256c5@xeon-e3> In-Reply-To: <20180105173855.25473-1-thomas@monjalon.net> References: <20180105173855.25473-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix link autonegotiation value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 20:47:11 -0000 On Fri, 5 Jan 2018 18:38:55 +0100 Thomas Monjalon wrote: > There are 3 kind of link data in ethdev: > - capabilities (rte_eth_dev_info) > - configuration (rte_eth_conf) > - status (rte_eth_link) > > A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and > configuration (rte_eth_conf.link_speeds). > Bits are defined in ETH_LINK_SPEED_*. > > Some numerical (ETH_SPEED_NUM_*) and boolean (ETH_LINK_*) values > are used for the link status (rte_eth_link.*). > > There was a mistake in the comment of rte_eth_link.link_autoneg, > suggesting ETH_LINK_SPEED_[AUTONEG/FIXED] which are 0/1, > instead of ETH_LINK_[AUTONEG/FIXED] which are 1/0. > > The drivers are fixed to use ETH_LINK_[AUTONEG/FIXED]. > > Fixes: 82113036e4e5 ("ethdev: redesign link speed config") > > Suggested-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon Thanks for clearing this up. Acked-by: Stephen Hemminger