From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5B7041B023 for ; Sat, 6 Jan 2018 04:10:37 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jan 2018 19:10:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,320,1511856000"; d="scan'208";a="8493691" Received: from debian-xvivbkq.sh.intel.com ([10.67.104.226]) by orsmga008.jf.intel.com with ESMTP; 05 Jan 2018 19:10:35 -0800 Date: Sat, 6 Jan 2018 11:10:08 +0800 From: Tiwei Bie To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20180106031008.pz65udjogohdu3fz@debian-xvivbkq.sh.intel.com> References: <20180106010656.9167-1-stephen@networkplumber.org> <20180106010656.9167-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180106010656.9167-4-stephen@networkplumber.org> User-Agent: NeoMutt/20170609 (1.8.3) Subject: Re: [dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2018 03:10:39 -0000 Hi Stephen, On Fri, Jan 05, 2018 at 05:06:44PM -0800, Stephen Hemminger wrote: > Use the new comon code in ethdev to handle link status update. Typo: comon -> common > > Signed-off-by: Stephen Hemminger [...] > static void > virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > @@ -1913,8 +1872,13 @@ static void > virtio_dev_stop(struct rte_eth_dev *dev) > { > struct virtio_hw *hw = dev->data->dev_private; > - struct rte_eth_link link; > struct rte_intr_conf *intr_conf = &dev->data->dev_conf.intr_conf; > + struct rte_eth_link link = { > + .link_speed = SPEED_10G, SPEED_10G has been removed on dpdk-next-virtio: http://dpdk.org/browse/next/dpdk-next-virtio/commit/?id=ed85aab5ee68d9be552e10fa123e9a0e35590389 I think you could use ETH_SPEED_NUM_10G directly. > + .link_duplex = ETH_LINK_FULL_DUPLEX, > + .link_autoneg = ETH_LINK_SPEED_FIXED, > + .link_status = ETH_LINK_DOWN, > + }; [...] > static int > virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) > { > - struct rte_eth_link link, old; > - uint16_t status; > struct virtio_hw *hw = dev->data->dev_private; > - memset(&link, 0, sizeof(link)); > - virtio_dev_atomic_read_link_status(dev, &link); > - old = link; > - link.link_duplex = ETH_LINK_FULL_DUPLEX; > - link.link_speed = SPEED_10G; > + uint16_t status; > + struct rte_eth_link link = { > + .link_speed = SPEED_10G, Ditto. Thanks for the work! Best regards, Tiwei Bie