From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02hn0203.outbound.protection.outlook.com [104.47.38.203]) by dpdk.org (Postfix) with ESMTP id 74BB41B024 for ; Mon, 8 Jan 2018 07:47:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5CedgT7LNIXuHxjYUdCIFdUlmEM5+mwwjwro1ZKfdCY=; b=ZH2ZOPmePFHhhxhCVcFNxmlaG1eUXUGAvg/B7CQGxgCRRXzAS5gFtWCnaXAfnbFFAv9m8giSXx3my2pplZpPNAG7FFzXNOn1Qi0DoCPMo3HZ6ccbT4B9nFi6FRR1nA2tfibVFUA3vluqsf32lG0ISmEWCaHv5uAYcmuaj8+X7vc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.61.92.144) by CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Mon, 8 Jan 2018 06:47:03 +0000 Date: Mon, 8 Jan 2018 12:16:45 +0530 From: Jerin Jacob To: Sean Harte Cc: Liang Ma , dev@dpdk.org, harry.van.haaren@intel.com, Bruce Richardson , deepak.k.jain@intel.com, john.geary@intel.com, "Mccarthy, Peter" Message-ID: <20180108064644.GB19071@jerin> References: <1513941830-186503-1-git-send-email-liang.j.ma@intel.com> <1513941830-186503-2-git-send-email-liang.j.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [171.61.92.144] X-ClientProxiedBy: BM1PR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (10.174.221.26) To CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e5194e1f-758b-426a-b4a6-08d55663a28a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 3:Cm1UTsMQlRujHJNg+YDiSp4TUvEI4G5mTDt1xqB3uBaPk4DDKx9SahvD6NYkz4EwXgg2iSQSUHUCXXOXj/uCISspy5RIqYs6AYyJY57r+RbUiHapzTSVqLOGeCYk/VPNd6gPcJ9Bm8Jh1xdSVYm0pLtZah54QLxYnGIWmdRtu8gjgeJdH5Wq3eSzlhIFdwGD8HAy0zu2Bw9TV26sVKX4s3I8Xo37cCkFhN4IuPvXsrhcBnhL1732xHTO39b/q3D1; 25:6+Wi4LFXqeTRnFpEuyVTT7LnH0HOZ9LD5Atfd6zIOHi/zb/oN3wmSwp1juyWh//oCb6I1e6O99dv4DRPK3arN8C5m/TwNdVrpS1mW6e+zDWZ9ZN08pjDgteON/R+n768AhFB7iMhougvXRphfjReXYAvcgRMw3YoGtc4ja/qORSAtAY9QdcaGxJMDc0BU1KXj0w6LApDQ1e4y/XpPTQWD90L1JzJPrQGaL6DBH8bO5jDvKwTutXz6nYSLSniJtHyJV83D7WM7FPFT/Wrvo/qBFNrnmbBMyFfWMRhia/MsOxWKd0EaDIaVLemck1ULTpt7DSHnipW+jLpsDaddB0cQQ==; 31:d6H4ZwKw9PjBb6B94PmqkOQNn06MmJFfaVNDgeVuMevPqc3nb72efNZWEg6rnQya4Zh+0NLnEwDS2/TxvpvV9pxYAeHB38LfTOsUWUv7G2j1NmEFXO5V1ZsF4lcki4Ay498SkkO1AdobKw11t4WAQu6yMzoxoERK5Vex5ICDKUzgHXlpVb4UkDGHaBohA1DPE9kqKesc4Kzx6Iy2Jyh0XJKNrZ7NgBM3l0+gnWR8FHY= X-MS-TrafficTypeDiagnostic: CO2PR07MB2520: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 20:q0ONXzq2/Ke+wxu+DJDCipDDHaDRTP2hN/4vgf50p+9H1oKE0Za1yxA1VbHbql71gIA/LuqtIN6qHg3Df1AZPHh4tBdMKIycVipJSvSWCWcrvuijd1HTNHuKgW5ntoNI3vKWWnJvFvwGJClG2gYSLz6uJqW6BSTnWaMWsuZGpu8GS7MQMMTMVKrxIatqasKaCaUlzxIkc8a9P+46aOt3DjJyZRIOiGOiOTjhzG90+98wMaTSSFvj6aJqFXcsG3N09y7UhLFA4ajpthwuO30hFdvE2gFQWttnNQeEBYShhQmevcgCR+O5tF+MNjRAuGlMYj1z638ByCneWEbuSJGnub32FQZoQi7FgdOhOJ5Fpxbpkod2xY1u9dTf2NqUBLgTAwRGBeQ50yfaBdE/+OOBU45g56SHismdN5YkfZmwJjlG4IzySHMq6Kod7Osukiz24ZOQNxL+V2GmiRo6/dSkcqF4e0gnapdoc5ua8H3FOU3TrMM3R6rvjQDewYY5i9BCRYCNO0W+raeoo42S2M4nYxvZZvoBXa1qndgUrHLUM9RFgtIDaqQqzJm+eAt+VILs3xnEc4tPiiMhFHDNQrMeVo/eiNK5z4+B9zXEUO0SX0k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(66839620246622)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(2230046)(2102002)(944501075)(3002001)(10201501046)(93006095)(6041268)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CO2PR07MB2520; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 4:CDVEkq5nGTAjClr/fVk6rL886AJok8cA9lxdA2xR997qoKg6HI8C5E4DkBRNMGmkne1UTkYnJvvaN97E77WEah6kVTbl1T8btDNWxqMF4wyIkVgBUYAg/1wrd+LhD9mVePfCUFd4kLfdKZNv/uP42giozRvhPYPXI6tRRm8vascx5UJzCQH+YPV/hm4gaaCLLgnAQ541SqPlQXPLFVwhduCEeFyxNJLGxpL6Z+fSTF5aRRR/njhlrWkBARffZdJfxTofxGsw1U9oyVnoo9B7XFI+53QpqzJy8wens0xBahD5Cnrq4wlNLNKQhZW/ijdXh2UdWrPS+zwXGOlS8NSjuUNtlbmnfIg7N9Wje4pNoVY= X-Forefront-PRVS: 054642504A X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(39850400004)(39380400002)(366004)(396003)(376002)(346002)(13464003)(189003)(199004)(24454002)(316002)(2486003)(54906003)(33716001)(966005)(7736002)(1076002)(50466002)(305945005)(53376002)(386003)(6246003)(83506002)(16526018)(33896004)(3846002)(4326008)(53546011)(6116002)(39060400002)(59450400001)(25786009)(72206003)(58126008)(478600001)(8676002)(52146003)(23676004)(66066001)(52116002)(33656002)(6496006)(8936002)(229853002)(105586002)(6306002)(6916009)(5660300001)(42882006)(6666003)(2950100002)(1411001)(97736004)(9686003)(2906002)(2870700001)(106356001)(53936002)(76176011)(81166006)(68736007)(81156014)(55016002)(47776003)(50929007)(18370500001); DIR:OUT; SFP:1501; SCL:5; SRVR:CO2PR07MB2520; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjA3TUIyNTIwOzIzOnhsbVMxWmVqYXdaZnFIN1U2eUd3c3JmZG1R?= =?utf-8?B?ZlRWbStDaW9vRkFGTExVSVdDcWZ3MWRzcFR6QXZwNVFKV1FTRkZZTGNXZENC?= =?utf-8?B?Wm9sNTRNNHV0ZDVvbVlpZ25LS0tyUGhYQnJGSGtXTmFlVEh4U2p6eVVPU09M?= =?utf-8?B?NE1UY3NaWTJzNlFkVFhGLzNaWXVyZ21DTDZXVW1Xa0FoUmQrUTFMNVQxSmNY?= =?utf-8?B?d0FDbHZ5REpRSzBUVVpyR21sTExFYlpjMkpRTDNhNnJ5aFFpTWFFdzJ2cmN5?= =?utf-8?B?ajkyWnRMa0VneEg1b291cWExNzUrQXdON3M3STNDdW9BVDdTTTRyckozc0Zp?= =?utf-8?B?Yzl0SjV4M3gyNC94VFdCM2ZKM0JWc3lGUWtEbEVpSldnbXQ5MHYyUkFKSi80?= =?utf-8?B?Ukx1ZHBsTktDNzI2VjJVUXV1WjZwcmlkckc3RmFCUG15VkNKeVBOcngrQTBD?= =?utf-8?B?WitEdG9HakduOTJQQ3I4NE5wN0lROVFqK1BQUlRoQXVoazZISDh1Y1FkSmFF?= =?utf-8?B?TUNleTBoQ1hQMFJlWE5SdW0rSk1Rb3Mxa0RhTHU4V1RVaEFKSkZScG94elRE?= =?utf-8?B?cmZQQkZ4VndDdjg4VzFuemhHdmloeGJaUXBWU0dyZWNHUThRTzFVSVNqUFlU?= =?utf-8?B?ckxLd1pJUXhuT3JlSitoNkF6SXh4U2ZISXpqZ0wwS1VwKyswb1krQUV3Zi9H?= =?utf-8?B?dEppaDNieFVUMmZlVVFXUXg0NDk1b0Z2aFIrbUpNbFNoS24vRVo0ME5zNTZI?= =?utf-8?B?Y203RWxGWG1mdVRiekFpRVJkNEZza0Q2NzNoVVcveWdicVVYaVFmeVFJZ0d2?= =?utf-8?B?L0d5TjlWOTZnVkZMZXNqcGUwcGpaK0gxL1hGM21tRWNYbEsxV2xRbFBhMjVT?= =?utf-8?B?SFMyNUh4WTFpMGxseVdSWUMzQ2Jyak9ablZVS2hTcDRVc3lTUXlOc0JhcWpB?= =?utf-8?B?dVVtdUNiUHozbXVlZjFrS1VHTnRpQzlUekJjTi9qMzhiN3UyeUtrMEk5Y0hz?= =?utf-8?B?Y2d0a3VYNWxkaHNjaHBaVXVmTXFENjJKMXZFV0crdUFFWm5iVlV2ZGxvT2tu?= =?utf-8?B?QVlsR1FPTU53ZFE1Q29mNEJ2VHdnQ2Q2emZyUUtQZzlBT01qSnZoUDZ0Z2xM?= =?utf-8?B?OE5HWHF6bEhYYWpBaVJDUDZTWllNYzEzOHB2YjFXM1ZhTTBTdW1OYkx4c0Nz?= =?utf-8?B?ZThseURVN0JjYWdSR3grTE81RDYyRHJYb2pwYW03K284QkxjRWdmSW8vRUpN?= =?utf-8?B?cjMyM0Z4V2t1aW9ONGNvLzZoZ084WFh6QlY1dnk3VVBrSVRhNS9wNkoyOVFF?= =?utf-8?B?bnZBUTRjVXMwOEVxLy9CQ05aL2FNa1Vwcm51S1ArbXcrdVJNVEIvVU41V1lm?= =?utf-8?B?UEJRNEYyV0lNeHo1YjIvN3hMLzcrZUVGakYyL3RPK2RxTHdBUk15bTUwREVk?= =?utf-8?B?T1FQWW5saE9NaVJRZDdvcnFUVE13d3FMZHpWLzdMS25pSmVoeWhGZ3QrWmRR?= =?utf-8?B?VkNwSXhKUU9mOVdtbXJlM1BEUTFOWm9wYXVzYkQ1VlJPSEJlUGFLWXFqbDB5?= =?utf-8?B?SjhoL0t5ZmJFVnRPSE4zRU04cURaTHBIMTVZQ0wwV0RhLzVWcCtlYUJha2tr?= =?utf-8?B?dGswOHN1dkZwdHBLNGw2ZEE3andCcXRkc3MwNGtacVJxOXc0TUpQd0c5NnVn?= =?utf-8?B?WG1OYlg3MGN1WDQyTURlaVFGZ21RL2prR08vTm0yUkEzeU5ONHNDMkd1RlEy?= =?utf-8?B?Q2h5UjVEWUI0TkcwVnpmYXV6TFFFUUREL3ZDTnMwTVR0clVTR0lORkxhcDhn?= =?utf-8?B?MHFycFBqTDJVWXRIUHMwVGgwNXBjZXJKU1dyVmMwMkZ1VTMrKzkzWFFRK1ox?= =?utf-8?B?akxCM3lXVzZ4UUZ1ZFlRMW1VMStiQThzTlgrdDlVc3pPNVRPTStXTG5TY0to?= =?utf-8?B?SlJtcGJsNTJHaDF0amFWanJJamwxaGIvZ2gzekZGNmRDTDNabHVxWll5bzF2?= =?utf-8?B?REx0YkQ3M08wWllqNEZmeEVQYjJDaUlnZzB3ZUlON0U0VWlPNFgrSEZCbGR0?= =?utf-8?Q?ZPKU+juhUMiLjUbONjOc2ij30?= X-Microsoft-Antispam-Message-Info: wY86zUDCFr37IoAiscCOKruINL8zVr03z3Lev15BF5nMfmEF2XChYqD4Rwt2Ei4XpfuSIi7Ag2VpeEFXC1u92GpW3+wleBDWJwea5f3MF22kFBPOJiJlESn4s4vDckNE X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 6:dhGOtxvZDOkDywpe59k6kEjv0CmqRzRIUokeCTTq04OyJ7OThXfkMum/ZBjvFaqiuN8yHxnkvmZ7khKZjyIlpvCJ53LJfb7dnY/aoy8PVeL1pxPcN5v1SKip9/X3EKee1FsWoK5E0jFVXWh0KNNew4xKsJ23Ax5eQ1j3y8Q1xFaq/wrFGaH6auIXeVTcHu2QWReLrMcEuOi5dh5VfQVeHuAI1uOdVV/DbJVZhCdWIba9oN2GSzLxkNnli/zTJpo90tEDfkTTolvvkJ4DkU0DmdHhv2Dix1sgpysO/Tm79DlI2vwodWfkr75YktO9bcuQ5NMer1fle5fKpBSMd5irhypzzB1iMbAdaUl6JjNEwck=; 5:7CQWYZspbIHWP98KeAaMb4rU1FVCFGlHQuAELDJjCn7V2tnpH/Fv6YF+IF3CTSwF47G17cnwxg73OC2FyL0mlTCwg9SgSO9COiwJn9C45lm0GEo6JhXDbtDSvxcizg/ideHQd/UhlSnhMuTZCrqxHxrS9y/ssVzEVmQ16269q1c=; 24:FFFocN7R4r4GSXgQGw0SZTc3yTueJks+bZ4EfMVcOLdZxTeZTSjFtXVLoSm0aAZ2a3VWqVPYJpY1IDJrgOeruw==; 7:7IT5T8fZIpO11MlpsWu42ladmapozasIf3waGcLJPWMEzHtD7zuKZRyS+nUtnq/b8wrkbJoPN305I8eihb9OSlDJtb5vys8SuTcbKWr7MP8E7kAfFyLz4zm/BMLQpWbIBvCVCfhVmvzbLq8P0iP+ztCqkbUYgPqXLAug0Mvq/tV+wwbUJGd7DsYASwHWDUbAleIM+qOoFuN9cV3rJFfgcyGnzDRoGlEdsfjAZNI/wLLwT3gySX/Rx1p8RG4FfIux SpamDiagnosticOutput: 1:22 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2018 06:47:03.9980 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5194e1f-758b-426a-b4a6-08d55663a28a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2520 Subject: Re: [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 06:47:10 -0000 -----Original Message----- > Date: Fri, 22 Dec 2017 16:02:42 +0000 > From: Sean Harte > To: Liang Ma > Cc: jerin.jacob@caviumnetworks.com, dev@dpdk.org, > harry.van.haaren@intel.com, Bruce Richardson , > deepak.k.jain@intel.com, john.geary@intel.com, "Mccarthy, Peter" > > Subject: Re: [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure > library > > On 22 December 2017 at 11:23, Liang Ma wrote: > > > > OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library > > provide the core data structure and core helper function set. The Ring > > implements a single ring multi-port/stage pipelined packet distribution > > mechanism. This mechanism has the following characteristics: > > > > • No multiple queue cost, therefore, latency is significant reduced. > > • Fixed dependencies between queue/ports is more suitable for complex. > > fixed pipelines of stateless packet processing (static pipeline). > > • Has decentralized distribution (no scheduling core). > > • Packets remain in order (no reorder core(s)). > > * Update build system to enable compilation. > > > > Signed-off-by: Liang Ma > > Signed-off-by: Peter Mccarthy > > --- > > config/common_base | 6 + > > drivers/event/Makefile | 1 + > > drivers/event/opdl/Makefile | 62 + > > drivers/event/opdl/opdl_log.h | 59 + > > drivers/event/opdl/opdl_ring.c | 1252 +++++++++++++++++++++ > > drivers/event/opdl/opdl_ring.h | 628 +++++++++++ > > drivers/event/opdl/rte_pmd_evdev_opdl_version.map | 3 + > > mk/rte.app.mk | 1 + > > mk/toolchain/gcc/rte.toolchain-compat.mk | 6 + > > mk/toolchain/icc/rte.toolchain-compat.mk | 6 + > > 10 files changed, 2024 insertions(+) > > create mode 100644 drivers/event/opdl/Makefile > > create mode 100644 drivers/event/opdl/opdl_log.h > > create mode 100644 drivers/event/opdl/opdl_ring.c > > create mode 100644 drivers/event/opdl/opdl_ring.h > > create mode 100644 drivers/event/opdl/rte_pmd_evdev_opdl_version.map > > [...] > > Reviewed-by: Seán Harte I think, the series is not addressed all the v3 comments. I think, the missing ones are 1) Use dynamic logging 2) Split the patches based on eventdev ops: example: See the example from latest dpaa eventdev driver: http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=Sunil 3) Fix check-patch and check-git-log.sh errors. Wrong headline format: doc:update 18.02 release notes Wrong headline prefix: eventdev/opdl: opdl eventdev pmd unit test function event/*: apply the three new capability flags for sw/dppa2/octeontx Wrong headline lowercase: event/opdl: add the opdl pmd main body and helper function eventdev/opdl: opdl eventdev pmd unit test function event/*: apply the three new capability flags for sw/dppa2/octeontx maintainers: add the opdl pmd maintainer information doc: add eventdev opdl pmd docuement Headline too long: event/*: apply the three new capability flags for sw/dppa2/octeontx ### event/opdl: add the opdl ring infrastructure library WARNING:LONG_LINE: line over 80 characters #451: FILE: drivers/event/opdl/opdl_ring.c:260: + PMD_DRV_LOG(ERR, "%u entries is more than max (%u)", n, s->num_slots); WARNING:LONG_LINE: line over 80 characters #1202: FILE: drivers/event/opdl/opdl_ring.c:1011: + ev_orig = (struct rte_event *)get_slot(t, s->shadow_head+i); WARNING:LONG_LINE: line over 80 characters #1203: FILE: drivers/event/opdl/opdl_ring.c:1012: + if ((ev_orig->flow_id%s->nb_instance) == s->instance_id) { WARNING:LONG_LINE: line over 80 characters #1206: FILE: drivers/event/opdl/opdl_ring.c:1015: + if ((ev_orig->event&OPDL_EVENT_MASK) != ev_temp) { total: 0 errors, 4 warnings, 2049 lines checked ### event/opdl: add the opdl pmd main body and helper function WARNING:LONG_LINE: line over 80 characters #1489: FILE: drivers/event/opdl/opdl_evdev_init.c:301: + opdl_ring_cas_slot(p->enq_stage_inst, &ev[i], i, p->atomic_claim); WARNING:LONG_LINE: line over 80 characters #2027: FILE: drivers/event/opdl/opdl_evdev_init.c:839: + opdl_pmd_dev_id(port->opdl), WARNING:LONG_LINE: line over 80 characters #2056: FILE: drivers/event/opdl/opdl_evdev_init.c:868: + opdl_pmd_dev_id(port->opdl), total: 0 errors, 3 warnings, 2309 lines checked ### eventdev/opdl: opdl eventdev pmd unit test function WARNING:LONG_LINE: line over 80 characters #247: FILE: drivers/event/opdl/opdl_test.c:189: + PMD_DRV_LOG(ERR, "%d: error creating qid %d\n ", __LINE__, i); WARNING:LONG_LINE: line over 80 characters #314: FILE: drivers/event/opdl/opdl_test.c:256: + PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n", __LINE__); WARNING:LONG_LINE: line over 80 characters #451: FILE: drivers/event/opdl/opdl_test.c:393: + PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n", __LINE__); WARNING:LONG_LINE: line over 80 characters #505: FILE: drivers/event/opdl/opdl_test.c:447: + PMD_DRV_LOG(ERR, "%d: deq none zero !\n", __LINE__); total: 0 errors, 4 warnings, 1102 lines checked