From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f53.google.com (mail-pg0-f53.google.com [74.125.83.53]) by dpdk.org (Postfix) with ESMTP id 317ED1B014 for ; Mon, 8 Jan 2018 16:27:41 +0100 (CET) Received: by mail-pg0-f53.google.com with SMTP id q12so5729929pgt.7 for ; Mon, 08 Jan 2018 07:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mqO6OkCnrF/I0SAntykTXeL6Mhfqkrhv9nTT92H2RB4=; b=kYIDZMmSXRtggzmKUzuk77HSiowcUjcf8mkeVvnKySXs4xELhyPcBr0ZY9LMFwh2L/ 0T8BWM2ZVFPFZ5rwRfsKm9B8Ig5816nNsEUzivHuK75PYXnMtZEdZDoqjoyxmnuqGjgC /bLA10aP3eRJkDNIyuvOrM6VdFC4ZemIGu62cg1nv/05zsUFMiMmobpKfLT3AnsUOrB9 6nhoX5+l9sZ1M1J01UBUUxQAa5C/+VV6KQ1dOvbtwMbfHL9FNA3mBY9tFoFSAyYskIP0 ZAawxEHTcShspyyVxwRUF8BHueMMsM18FJ8sHItkIbmk37Ie0zrYbLTkx/q7HrjjpIyz YDAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mqO6OkCnrF/I0SAntykTXeL6Mhfqkrhv9nTT92H2RB4=; b=j2p20/dZHd2dD0NNRxPAf/REoKaulzIfzjF3HrI0pBYB6yVRfFEO77yjLVeZFQ9H+N j0arikGkkmSChKDbsS04ymrrz09P8+A5WzZqUPatpAfmGhk+mk3kTMyKtEm9E3OKpOwH GSECMN3SBgs99l/d8hY2VM1VqMg7ime4xgCbFIQ5UleYn+KVc0u2B1QPDFlyb1jkqfiw j+pFC7Bp1gBpXbbT+y9peSkqd+GabsZ27QnZ65LiEnlKtW3jMYAaXV1W/WYBFcPZp4hJ RFelFBJEt+hbcBEinocetGErWhFcGdM+9Qm9aVZ7GYEknxhX9kZuQpwA9JbqmcNCuV6n 28UQ== X-Gm-Message-State: AKGB3mIEtqDKim+qiH/pBNO+0t5ilDKmZXpnNm137AxSMNQUh1iK6U/H PVvSD3wuXr598IILLkTSAZRYCcwJCmE= X-Google-Smtp-Source: ACJfBouOqKdf9cgxT6Zrccz1VV58q5RWWxeGxwbDn5E73cp3umnCfKpqmuTfLU4I40lXenWtHxRGzQ== X-Received: by 10.99.146.14 with SMTP id o14mr9587166pgd.267.1515425260336; Mon, 08 Jan 2018 07:27:40 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id x4sm25969646pfb.13.2018.01.08.07.27.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 07:27:40 -0800 (PST) Date: Mon, 8 Jan 2018 07:27:38 -0800 From: Stephen Hemminger To: "Lu, Wenzhuo" Cc: "dev@dpdk.org" , "Wu, Jingjing" Message-ID: <20180108072738.6250adfd@xeon-e3> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70A8E8@shsmsx102.ccr.corp.intel.com> References: <1511505206-97333-1-git-send-email-jingjing.wu@intel.com> <1515140505-38655-1-git-send-email-wenzhuo.lu@intel.com> <1515140505-38655-2-git-send-email-wenzhuo.lu@intel.com> <20180105122552.70da9a37@xeon-e3> <6A0DE07E22DDAD4C9103DF62FEBC09093B70A8E8@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 15:27:41 -0000 On Mon, 8 Jan 2018 01:06:36 +0000 "Lu, Wenzhuo" wrote: > > This function is way to big to be an inline. > Thanks for your comments. Let me explain. This is the base code, like what's in ixgbe, i40e ... We have to let it be so it's much easier for us to update it the next time. That's why the code style is a little different. And also some checkpatch problem not handled. > We have had some discussion about the copyright license here and internally. But unfortunately we don't achieve a conclusion internally so we have to keep the long license now and may change it later. If you have to have base code then put it in a subdirectory base/ that way reviewers and maintainers can separate DPDK part from ugly stuff.