From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 734881B1C8
 for <dev@dpdk.org>; Mon,  8 Jan 2018 16:39:44 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id e11so2470952pff.6
 for <dev@dpdk.org>; Mon, 08 Jan 2018 07:39:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=lteUc3XfHJbqBhFJJKk26WGFzM+156PWm+bz3YdOeSU=;
 b=LkPRBseB+UUcw2z2uvvCeiw24QQlglRp/tRJXleRWzkuF6tXhoQYXU4YXbsOI6YMJB
 g9dymrbJQtueqgLhu14Zlj6Ce24rBSAhP/x+KxhAmP47z0oNvOTDpGWTDqWGPZtYSPwj
 92bjJW+Ogr3eWNimTp+yTObjtvy9LsdJFW62+L58EvsuXKo6UPzpBG4M9qdbOMXEVfZ9
 Na+s3iwoVuLsIU4lGjOrJ8pp510VY7Fs3oLmditZkbr2APVn9EHLUHHFKeCrMTCR2dIT
 xCnCaGj4LUBSde6Utptc6rDjj0EzEcAAVzk3detsmydkLze/T5r9J6lCtN6FdpHmxB6r
 5pjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=lteUc3XfHJbqBhFJJKk26WGFzM+156PWm+bz3YdOeSU=;
 b=Wf7CQ2CQTPeNzQNEAE9ap7n5h7E2lwwOaluC0n6E1h8rp1c4PS49tu21ERaPiqp2DS
 Mxv0AQ0wxRpVh0FgrfQ8S5NzmLvQrSgq792fioSjJZ4Gtr2aqax8KIYISVvPdoTUEMiM
 GBCzNANy/OsVTSNz0k2hvCWzjQAzGvGXh1vO3HymOyYLRawuYvdzUGu1+HRrd/7gCyPA
 DdHRjmWUNUBAq4m2LLO75g+MRmD+dpbeeLGsS+9ofP9InMcqa6LcBZUPWGz8Cf9YRB+E
 jAkuvFgc1rF3zmC5ECstERvrbDByrHLUqa2k0anIAj5QqkLgq/QwikNvhblKq4y/uabd
 dJXQ==
X-Gm-Message-State: AKGB3mIUC6eDoWBY8/LaYmutROp5hmvcyf5RmsSem3NYASGKQ0q9BP2D
 lnM2N+73eMRkUDP6F/OSLwyacw==
X-Google-Smtp-Source: ACJfBovFN0pJ3Hcd38mTIMbIxjORdvFd97Fv6RIdYjqq2ofa+nm4mD0kcPmmXVkaVWAzotX0HsPoyw==
X-Received: by 10.99.110.10 with SMTP id j10mr9744399pgc.312.1515425983628;
 Mon, 08 Jan 2018 07:39:43 -0800 (PST)
Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133])
 by smtp.gmail.com with ESMTPSA id k2sm26276053pfg.53.2018.01.08.07.39.43
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 08 Jan 2018 07:39:43 -0800 (PST)
Date: Mon, 8 Jan 2018 07:39:41 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
Message-ID: <20180108073941.791cba4f@xeon-e3>
In-Reply-To: <20180108153423.57648-1-keith.wiles@intel.com>
References: <20180108153423.57648-1-keith.wiles@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mbuf:using sanity checks do not panic on
 null mbuf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 15:39:44 -0000

On Mon,  8 Jan 2018 09:34:23 -0600
Keith Wiles <keith.wiles@intel.com> wrote:

> +	if (!m || !f) {
> +		fprintf(stderr, "MBUF and/or FILE pointer is NULL\n");
> +		return;
> +	}

Calling with f of NULL is user error, let it still die in fprintf.