DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set
Date: Mon, 8 Jan 2018 09:03:38 -0800	[thread overview]
Message-ID: <20180108090338.796c7796@xeon-e3> (raw)
In-Reply-To: <20180106031008.pz65udjogohdu3fz@debian-xvivbkq.sh.intel.com>

On Sat, 6 Jan 2018 11:10:08 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:

> Hi Stephen,
> 
> On Fri, Jan 05, 2018 at 05:06:44PM -0800, Stephen Hemminger wrote:
> > Use the new comon code in ethdev to handle link status update.  
> 
> Typo: comon -> common
> 
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> [...]
> >  static void
> >  virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> >  {
> > @@ -1913,8 +1872,13 @@ static void
> >  virtio_dev_stop(struct rte_eth_dev *dev)
> >  {
> >  	struct virtio_hw *hw = dev->data->dev_private;
> > -	struct rte_eth_link link;
> >  	struct rte_intr_conf *intr_conf = &dev->data->dev_conf.intr_conf;
> > +	struct rte_eth_link link = {
> > +		.link_speed = SPEED_10G,  
> 
> SPEED_10G has been removed on dpdk-next-virtio:

Patch was intended for current release so not looking at -next

  reply	other threads:[~2018-01-08 17:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06  1:06 [dpdk-dev] [PATCH v2 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-06 10:49   ` Andrew Rybchenko
2018-01-06 14:24     ` Stephen Hemminger
2018-01-06 14:35       ` Andrew Rybchenko
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-06  3:10   ` Tiwei Bie
2018-01-08 17:03     ` Stephen Hemminger [this message]
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 04/15] vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 05/15] dpaa2: " Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 06/15] nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 07/15] e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 08/15] ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 09/15] sfc: use new " Stephen Hemminger
2018-01-06 11:10   ` Andrew Rybchenko
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 10/15] i40e: use " Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 11/15] liquidio: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 12/15] thunderx: " Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 13/15] szedata: " Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 14/15] octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-06  1:06 ` [dpdk-dev] [PATCH v2 15/15] enic: use _rte_eth_linkstatus_set Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108090338.796c7796@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).